scripts: waifulib: sdl2: avoid abspath usage that causes problems when the path is concatenated with something else

.cirrus.yml

@@ -1,13 +1,14 @@
 task:
   name: freebsd-14-amd64
   freebsd_instance:
-    image_family: freebsd-14-2
+    image_family: freebsd-14-0
   setup_script:
     - pkg update
-    - pkg install -y pkgconf git sdl2 python fontconfig libvorbis opusfile bzip2 libbacktrace
+    - pkg install -y pkgconf git sdl2 python fontconfig opus
     - git submodule update --init --recursive
   test_script:
-    - ./scripts/cirrus/build_freebsd.sh
+    - ./scripts/cirrus/build_freebsd.sh dedicated
+    - ./scripts/cirrus/build_freebsd.sh full
 
 task:
   name: freebsd-15-amd64
@@ -15,7 +16,8 @@ task:
     image_family: freebsd-15-0-snap
   setup_script:
     - pkg update
-    - pkg install -y pkgconf git sdl2 python fontconfig libvorbis opusfile bzip2 libbacktrace
+    - pkg install -y pkgconf git sdl2 python fontconfig opus
     - git submodule update --init --recursive
   test_script:
-    - ./scripts/cirrus/build_freebsd.sh
+    - ./scripts/cirrus/build_freebsd.sh dedicated
+    - ./scripts/cirrus/build_freebsd.sh full

.github/workflows/c-cpp.yml

@@ -15,39 +15,35 @@ jobs:
         include:
           # Linux build specifically want oldest Ubuntu as possible
           # to be crossdistribution compatible, otherwise use ubuntu-latest
-          - os: ubuntu-22.04
+          - os: ubuntu-20.04
             targetos: linux
             targetarch: amd64
-          - os: ubuntu-22.04
+          - os: ubuntu-20.04
             targetos: linux
             targetarch: i386
-          - os: ubuntu-22.04
+          - os: ubuntu-20.04
             targetos: linux
             targetarch: arm64
             cross: true
-          - os: ubuntu-22.04
+          - os: ubuntu-20.04
             targetos: linux
             targetarch: armhf
             cross: true
-          - os: ubuntu-24.04 # riscv64 would benefit from having latest compilers
+          - os: ubuntu-20.04
             targetos: linux
             targetarch: riscv64
             cross: true
-          - os: ubuntu-22.04
+          - os: ubuntu-20.04
             targetos: linux
             targetarch: ppc64el
             cross: true
-#          - os: ubuntu-aarch64-22.04
+#          - os: ubuntu-aarch64-20.04
 #            targetos: linux
 #            targetarch: aarch64
-          - os: ubuntu-latest
-            targetos: linux
-            targetarch: e2k-8c
-            cross: true
-          - os: ubuntu-latest
+          - os: ubuntu-20.04
             targetos: android
             targetarch: multiarch
-#          - os: ubuntu-22.04
+#          - os: ubuntu-20.04
 #            targetos: motomagx
 #            targetarch: armv6
 
@@ -70,7 +66,7 @@ jobs:
             targetos: apple
             targetarch: amd64
     env:
-      SDL_VERSION: 2.32.0
+      SDL_VERSION: 2.30.9
       GH_CPU_ARCH: ${{ matrix.targetarch }}
       GH_CROSSCOMPILING: ${{ matrix.cross }}
     steps:
@@ -91,7 +87,6 @@ jobs:
         path: artifacts/*
   flatpak:
     runs-on: ubuntu-latest
-    continue-on-error: true
     strategy:
       matrix:
         include:
@@ -105,7 +100,7 @@ jobs:
       with:
         submodules: recursive
     - name: Build flatpak (Compat.i386)
-      uses: FWGS/flatpak-github-actions/flatpak-builder@v6.3-fix
+      uses: FWGS/flatpak-github-actions/flatpak-builder@v6.3
       with:
         bundle: ${{ matrix.app }}.flatpak
         manifest-path: scripts/flatpak/${{ matrix.app }}.yml
@@ -124,6 +119,7 @@ jobs:
           --yes \
           --cleanup-tag \
           --repo "$GITHUB_REPOSITORY" || true
+        sleep 20s
         gh run download "$GITHUB_RUN_ID" \
           --dir artifacts/ \
           --repo "$GITHUB_REPOSITORY"

.gitmodules

@@ -27,16 +27,10 @@
 	url = https://github.com/FWGS/MultiEmulator
 [submodule "3rdparty/libogg/libogg"]
 	path = 3rdparty/libogg/libogg
-	url = https://github.com/xiph/ogg.git
+	url = https://gitlab.xiph.org/xiph/ogg.git
 [submodule "3rdparty/vorbis/vorbis-src"]
 	path = 3rdparty/vorbis/vorbis-src
-	url = https://github.com/xiph/vorbis.git
+	url = https://gitlab.xiph.org/xiph/vorbis.git
 [submodule "3rdparty/opusfile/opusfile"]
 	path = 3rdparty/opusfile/opusfile
-	url = https://github.com/xiph/opusfile.git
-[submodule "3rdparty/libbacktrace/libbacktrace"]
-	path = 3rdparty/libbacktrace/libbacktrace
-	url = https://github.com/ianlancetaylor/libbacktrace
-[submodule "3rdparty/maintui"]
-	path = 3rdparty/maintui
-	url = https://github.com/numas13/xash3d-maintui.git
+	url = https://gitlab.xiph.org/xiph/opusfile.git

3rdparty/extras/wscript

@@ -25,4 +25,5 @@ def build(bld):
 		name = 'extras.pk3',
 		files = srcdir.ant_glob('**/*'),
 		relative_to = srcdir,
+		compresslevel = 0,
 		install_path = install_path)

3rdparty/libbacktrace/wscript

@@ -1,188 +0,0 @@
-#! /usr/bin/env python
-# encoding: utf-8
-
-from waflib import TaskGen
-from waflib.Tools.c_config import DEFKEYS
-
-FRAGMENT_ATOMIC='''int i;
-int main(void) {
-	__atomic_load_n(&i, __ATOMIC_ACQUIRE);
-	__atomic_store_n(&i, 1, __ATOMIC_RELEASE);
-	return 0;
-}'''
-
-FRAGMENT_SYNC='''int i;
-int main (void) {
-	__sync_bool_compare_and_swap (&i, i, i);
-	__sync_lock_test_and_set (&i, 1);
-	__sync_lock_release (&i);
-	return 0;
-}'''
-
-FRAGMENT_GETPAGESIZE='''#include <unistd.h>
-int main(void) { return getpagesize() }'''
-
-FRAGMENT_GETEXECNAME='''#include <stdlib.h>
-int main(void) { return getexecname() != 0 }'''
-
-FRAGMENT_STRNLEN='''#include <string.h>
-int main(int argc, char **argv) { return (int)strnlen(argv[0], 10); }'''
-
-FRAGMENT_DL_ITERATE_PHDR='''#include <%s>
-int main(void) { return dl_iterate_phdr(0, 0); }'''
-
-FRAGMENT_FCNTL='''#include <fcntl.h>
-int main(void) { return fcntl(0, 0, 0); }'''
-
-FRAGMENT_GETIPINFO='''#include "unwind.h"
-struct _Unwind_Context *context;
-int ip_before_insn = 0;
-int main(void) { return _Unwind_GetIPInfo(context, &ip_before_insn); }'''
-
-FRAGMENT_LOADQUERY='''#include <sys/ldr.h>
-#include <sys/debug.h>
-int main(void) { return loadquery(0, 0, 0); }'''
-
-FRAGMENT_KERN_PROC='''#include <sys/sysctl.h>
-#if !defined(%s) || !defined(KERN_PROC_PATHNAME)
-#error
-#endif
-int main(void) { return 0; }'''
-
-FRAGMENT_LSTAT='''#include <sys/stat.h>
-struct stat st;
-int main(int argc, char **argv) { return lstat(argv[0], &st); }'''
-
-FRAGMENT_READLINK='''#include <unistd.h>
-char buf[100];
-int main(int argc, char **argv) { return readlink(argv[0], buf, sizeof(buf)); }'''
-
-def options(opt):
-	pass
-
-def configure(conf):
-	# add unsupported platforms here
-	if conf.env.DEST_OS in ['nswitch', 'psvita', 'dos']:
-		conf.env.DISABLE_LIBBACKTRACE = True
-		return
-
-	# win32 has it's own dbghelp-based backtrace, that's why we ship PDBs
-	if conf.env.COMPILER_CC == 'msvc':
-		conf.env.DISABLE_LIBBACKTRACE = True
-		return
-
-	if not conf.path.find_dir('libbacktrace') or not conf.path.find_dir('libbacktrace/config'):
-		conf.fatal('Can\'t find libbacktrace submodule. Run `git submodule update --init --recursive`.')
-		return
-
-	if conf.env.DEST_SIZEOF_VOID_P == 8:
-		conf.define('BACKTRACE_ELF_SIZE', 64)
-		conf.define('BACKTRACE_XCOFF_SIZE', 64)
-	else:
-		conf.define('BACKTRACE_ELF_SIZE', 32)
-		conf.define('BACKTRACE_XCOFF_SIZE', 32)
-
-	conf.define('_ALL_SOURCE', 1)
-	conf.define('_GNU_SOURCE', 1)
-	conf.define('_POSIX_PTHREAD_SEMANTICS', 1)
-	conf.define('_TANDEM_SOURCE', 1)
-	conf.define('__EXTENSIONS__', 1)
-	conf.define('_DARWIN_USE_64_BIT_INODE', 1)
-	conf.define('_LARGE_FILES', 1)
-	conf.check_large_file(compiler='c', execute=False, mandatory=False) # sets _FILE_OFFSET_BITS
-
-	conf.env.CFLAGS_EXTRAFLAGS = conf.filter_cflags(['-funwind-tables', '-g'], [])
-
-	if conf.filter_cflags(['-frandom-seed=test'], []):
-		conf.env.HAVE_FRANDOM_SEED = True
-
-	def check_header(hdr):
-		return {'header_name':hdr, 'msg':'... %s header' % hdr, 'mandatory':False, 'id':hdr}
-
-	conf.multicheck(
-		check_header('dlfcn.h'),
-		check_header('inttypes.h'),
-		check_header('link.h'),
-		check_header('sys/link.h'),
-		check_header('mach-o/dyld.h'),
-		check_header('memory.h'),
-		check_header('stdint.h'),
-		check_header('stdlib.h'),
-		check_header('strings.h'),
-		check_header('string.h'),
-		check_header('sys/ldr.h'),
-		check_header('sys/mman.h'),
-		check_header('sys/stat.h'),
-		check_header('sys/types.h'),
-		check_header('tlhelp32.h'),
-		check_header('unistd.h'),
-		check_header('windows.h'),
-
-		{'fragment':FRAGMENT_ATOMIC, 'msg':'... __atomic extensions', 'define_name':'HAVE_ATOMIC_FUNCTIONS', 'mandatory':False},
-		{'fragment':FRAGMENT_SYNC, 'msg':'...  __sync extensions', 'define_name':'HAVE_SYNC_FUNCTIONS', 'mandatory':False},
-		{'fragment':FRAGMENT_GETPAGESIZE, 'msg':'...  getpagesize function', 'define_name':'HAVE_DECL_GETPAGESIZE', 'mandatory':False},
-		{'fragment':FRAGMENT_STRNLEN, 'msg':'...  strnlen function', 'define_name':'HAVE_DECL_STRNLEN', 'mandatory':False},
-		{'fragment':FRAGMENT_DL_ITERATE_PHDR % 'link.h', 'msg':'...  dl_iterate_phdr function in link.h', 'define_name':'HAVE_DL_ITERATE_PHDR', 'after_tests': ['link.h'], 'mandatory':False},
-		{'fragment':FRAGMENT_DL_ITERATE_PHDR % 'sys/link.h', 'msg':'...  dl_iterate_phdr function in sys/link.h', 'define_name':'HAVE_DL_ITERATE_PHDR', 'after_tests': ['sys/link.h'], 'mandatory':False},
-		{'fragment':FRAGMENT_FCNTL,'msg':'...  fnctl function', 'define_name':'HAVE_FCNTL', 'mandatory':False},
-		{'fragment':FRAGMENT_GETEXECNAME,'msg':'...  getexecname function','define_name':'HAVE_GETEXECNAME', 'mandatory':False},
-		{'fragment':FRAGMENT_GETIPINFO, 'msg':'...  _Unwind_GetIPInfo function', 'define_name':'HAVE_GETIPINFO', 'mandatory':False},
-		{'fragment':FRAGMENT_KERN_PROC % 'KERN_PROC', 'msg': '...  KERN_PROC and KERN_PROC_PATHNAME defines', 'define_name':'HAVE_KERN_PROC', 'mandatory':False},
-		{'fragment':FRAGMENT_KERN_PROC % 'KERN_PROC_ARGS', 'msg': '...  KERN_PROC_ARGS and KERN_PROC_PATHNAME defines', 'define_name':'HAVE_KERN_PROC_ARGS', 'mandatory':False},
-		{'fragment':FRAGMENT_LOADQUERY, 'msg': '...  loadquery function', 'define_name':'HAVE_LOADQUERY', 'mandatory':False},
-		{'fragment':FRAGMENT_LSTAT, 'msg': '...  lstat function', 'define_name':'HAVE_LSTAT', 'mandatory':False},
-		{'fragment':FRAGMENT_READLINK, 'msg': '...  readlink function', 'define_name':'HAVE_READLINK', 'mandatory':False},
-
-#		{'lib':'lzma', 'define_name':'HAVE_LIBLZMA', 'uselib_store':'lzma', 'msg':'... lzma library', 'mandatory':False},
-#		{'lib':'z', 'define_name':'HAVE_ZLIB', 'uselib_store':'z', 'msg':'... zlib library', 'mandatory':False},
-#		{'lib':'zstd', 'define_name':'HAVE_ZSTD', 'uselib_store':'zstd', 'msg':'... zstd library', 'mandatory':False},
-		msg='Checking for in parallel'
-	)
-
-	conf.env[DEFKEYS].sort()
-
-	conf.write_config_header()
-
-	conf.define('BACKTRACE_SUPPORTED', 1)
-	conf.define('BACKTRACE_USES_MALLOC', 0)
-	conf.define('BACKTRACE_SUPPORTS_THREADS', 1)
-	conf.define('BACKTRACE_SUPPORTS_DATA', conf.env.DEST_BINFMT in ['elf', 'mac-o'])
-
-	conf.write_config_header('backtrace-supported.h')
-
-@TaskGen.feature('frandomseed')
-@TaskGen.after_method('propagate_uselib_vars')
-def process_frandom_seed(ctx):
-	tasks = getattr(ctx, 'compiled_tasks', [])
-
-	for task in tasks:
-		out = task.outputs[0]
-		task.env.CFLAGS = list(task.env.CFLAGS) # need a copy
-		task.env.CFLAGS += ['-frandom-seed=%s' % out.path_from(out.ctx.bldnode)]
-
-def build(bld):
-	if bld.env.DISABLE_LIBBACKTRACE:
-		return
-
-	# we specifically only want mmap-based allocators because calling malloc is not safe from signal handlers
-	sources = ['atomic.c', 'dwarf.c', 'fileline.c', 'posix.c', 'print.c', 'sort.c', 'state.c', 'backtrace.c', 'simple.c', 'mmap.c', 'mmapio.c']
-
-	if bld.env.DEST_BINFMT == 'pe':
-		sources += ['pecoff.c']
-	elif bld.env.DEST_BINFMT == 'mac-o':
-		sources += ['macho.c']
-	elif bld.env.DEST_BINFMT == 'elf':
-		sources += ['elf.c']
-	else:
-		sources += ['unknown.c']
-
-	task = bld.stlib(
-		source = ['libbacktrace/' + i for i in sources],
-		target = 'backtrace',
-		features = 'frandomseed' if bld.env.HAVE_FRANDOM_SEED else '',
-		use = 'EXTRAFLAGS lzma z zstd',
-		includes = '. libbacktrace/',
-		export_defines = 'HAVE_LIBBACKTRACE=1',
-		export_includes = 'libbacktrace/'
-	)
-

Documentation/cross-compiling-for-windows-with-wine.md

@@ -5,10 +5,5 @@ This can be useful to test engine in Wine without using virtual machines or dual
 0. Clone and install https://github.com/mstorsjo/msvc-wine (you can skip CMake part)
 1. Set environment variable MSVC_WINE_PATH to the path to installed MSVC toolchain
 2. Pre-load wine: `wineserver -k; wineserver -p; wine64 wineboot`
-3. Run `PKGCONFIG=/bin/false ./waf configure -T <build-type> --enable-wine-msvc --sdl2=../SDL2_VC`. Configuration step will take more time than usual.
+3. Run `./waf configure -T <build-type> --enable-wine-msvc --sdl2=../SDL2_VC`. Configuration step will take more time than usual.
 4. .. other typical steps to build from console ...
-
-> [!NOTE]
-> Notice the usage of PKGCONFIG=/bin/false here. We're disabling pkg-config so we don't accidentally pull
-> system-wide dependencies and force building them from source. In future builds we might set custom
-> directory to pull dependencies from, like ffmpeg...

Documentation/donate.md

@@ -2,27 +2,23 @@
 
 On this page you can find links where you can support each developer individually, who has provided public sponsorship information.
 
-## [a1batross](https://github.com/a1batross)
+### [a1batross](https://github.com/a1batross)
 
-Initial Xash3D SDL2/Linux port author, Xash3D FWGS engine maintainer, creator of non-commercial Flying With Gauss organization.
+* Initial Xash3D SDL2/Linux port author, Xash3D FWGS engine maintainer, creator of non-commercial Flying With Gauss organization.
+* Boosty page: https://boosty.to/a1ba
 
-* [Boosty page](https://boosty.to/a1ba)
+### [nekonomicon](https://github.com/nekonomicon)
 
-## [nekonomicon](https://github.com/nekonomicon)
+* [hlsdk-portable](https://github.com/FWGS/hlsdk-portable), [mdldec](../utils/mdldec), [opensource-mods.md](opensource-mods.md) maintainer and Xash3D FWGS [contributor](https://github.com/FWGS/xash3d-fwgs/commits?author=nekonomicon) (*BSD/clang port, PNG support, etc).
+* Boosty page: https://boosty.to/nekonomicon
 
-[hlsdk-portable](https://github.com/FWGS/hlsdk-portable), [mdldec](../utils/mdldec), [opensource-mods.md](opensource-mods.md) maintainer and Xash3D FWGS [contributor](https://github.com/FWGS/xash3d-fwgs/commits?author=nekonomicon) (*BSD/clang port, PNG support, etc).
+### [Velaron](https://github.com/Velaron)
+* [cs16-client](https://github.com/Velaron/cs16-client) & [tf15-client](https://github.com/Velaron/tf15-client) maintainer and Xash3D FWGS [contributor](https://github.com/FWGS/xash3d-fwgs/commits?author=Velaron) (Android port, voice chat, etc).
+* BuyMeACoffee page: https://www.buymeacoffee.com/velaron
 
-* [Boosty page](https://boosty.to/nekonomicon)
-
-## [Velaron](https://github.com/Velaron)
-
-[cs16-client](https://github.com/Velaron/cs16-client) & [tf15-client](https://github.com/Velaron/tf15-client) maintainer and Xash3D FWGS [contributor](https://github.com/FWGS/xash3d-fwgs/commits?author=Velaron) (Android port, voice chat, etc).
-
-* [BuyMeACoffee page](https://www.buymeacoffee.com/velaron)
-
-## [SNMetamorph](https://github.com/SNMetamorph)
-
-[PrimeXT](https://github.com/SNMetamorph/PrimeXT) & [GoldSrc Monitor](https://github.com/SNMetamorph/goldsrc-monitor) maintainer and Xash3D FWGS [contributor](https://github.com/FWGS/xash3d-fwgs/commits?author=SNMetamorph) (Windows port, voice chat, etc).
-
-* [Boosty page](https://boosty.to/snmetamorph)
-* [Other donation methods](https://snmetamorph.github.io/donate)
+### [SNMetamorph](https://github.com/SNMetamorph)
+* [PrimeXT](https://github.com/SNMetamorph/PrimeXT) & [GoldSrc Monitor](https://github.com/SNMetamorph/goldsrc-monitor) maintainer and Xash3D FWGS [contributor](https://github.com/FWGS/xash3d-fwgs/commits?author=SNMetamorph) (Windows port, voice chat, etc).
+* BTC: `16GAzK3qei5AwBW7sggXp3yNcFHBtdpxXj`
+* ETH (ERC20): `0xb580eeca9756e3881f9d6d026e28db28eb72a383`
+* USDT (ERC20): `0xb580eeca9756e3881f9d6d026e28db28eb72a383`
+* USDC (ERC20): `0xb580eeca9756e3881f9d6d026e28db28eb72a383`

Documentation/gameinfo.md

@@ -85,9 +85,6 @@ These strings are specific to Xash3D FWGS.
 As Xash3D accidentally supports GoldSrc games, it also supports parsing liblist.gam.\
 Xash3D will use this file if gameinfo.txt is absent, or if its modification timestamp is older than liblist.gam.
 
-> [!NOTE]
-> Starting from January 2025, Xash3D FWGS doesn't automatically generate gameinfo.txt from liblist.gam. The key conversion table still remains but if you wish to use gameinfo.txt instead of liblist.gam, you can execute `fs_make_gameinfo` in console.
-
 For game creators who plan supporting only Xash3D, using this file is not recommended.
 
 The table below defines conversion rules from liblist.gam to gameinfo.txt. Some keys' interpretation does differ from `gameinfo.txt`, in this case a note will be left. If `liblist.gam` key isn't present in this table, it's ignored.

Documentation/goldsrc-protocol-support.md

@@ -6,7 +6,7 @@ For connecting to GoldSrc-based servers, use this command:
 connect ip:port gs
 ```
 
-But keep in mind, there are requirement for server to be able to accept connections from Xash3D-based clients: it should use Reunion.
+But keep in mind, there are requirement for server to be able to accept connections from Xash3D-based clients: it should use Reunion or Dproto.
 Without this requirement, you will just get "Steam validation rejected" error on connecting.
 
 That is because proper authorization with Steam API is not implemented in engine yet (but we have plans on it).

Documentation/not-supported-mod-list-and-reasons-why.md

@@ -2,19 +2,10 @@
 
 |Name							|Version			|Why not working						|What was made for that
 |----							|-------			|---------------						|----------------------
-|Area 51						|Update 1			|Uses outdated BSP31 map format and custom HLFX SDK libraries.	|You can try [this tool](https://hlfx.ru/forum/showthread.php?threadid=5250) to convert maps but there no warranty if it works.
-|Arrange Mod: Rebirth					|v150				|No idea yet.							|
-|Blue Shift						|The latest steam release	|Uses vgui2 library which xash3d does not support.		|Recreated source code here: https://github.com/FWGS/hlsdk-xash3d/tree/bshift.
-|Counter Strike						|Beta 6.5-			|Uses an old WON HL 1.0.0.16- interface.			|
-|							|1.4				|Has encrypted blob instead of normal client.dll.		|You can try [this tool](https://aluigi.altervista.org/papers/hldlldec.zip) to decrypt client.dll but there no warranty if it works.
-|							|1.5				|Has encrypted blob instead of normal client.dll.		|Decrypted blob here: https://csm.dev/threads/cs-1-5-client-dll-decrypted-patched-for-usage.38845.
-|							|1.6(The latest steam release)	|Uses vgui2 library which xash3d does not support.		|Some work on vgui2 support was made here: https://github.com/FWGS/xash3d/tree/vinterface. Recreated Client Source Code here: https://github.com/Velaron/cs16-client.
-|Counter Strike: Condition Zero				|The latest steam release	|Uses vgui2 library which xash3d does not support.		|Some work on vgui2 support was made here: https://github.com/FWGS/xash3d/tree/vinterface. Recreated Client Source Code here: https://github.com/Velaron/cs16-client.
-|Counter Strike: Condition Zero - Deleted scenes	|The latest steam release	|Uses vgui2 library which xash3d does not support. Uses new sequences code on engine-side that was never used in any other mods before.		|Some work on vgui2 support was made here: https://github.com/FWGS/xash3d/tree/vinterface.
-|Day of Defeat						|The latest steam release	|Uses vgui2 library which xash3d does not support.		|Some work on vgui2 support was made here: https://github.com/FWGS/xash3d/tree/vinterface.
-|Half-Life: Extended					|Day One demo			|Uses many hooks to GoldSource engine and version check.	|Just wait new version or use more old version.
-|Icon of Hell						|Beta 0.99			|Uses outdated BSP31 map format and paranoia 2 libraries.	|You can try [this tool](https://hlfx.ru/forum/showthread.php?threadid=5250) to convert maps and use Paranoia 2: The Savior 1.51 libraries but there no warranty if it works.
-|Paranoia 2: The Savior					|All builds older 1.51		|Uses an old renderer interface and engine features.		|
-|Rebellion						|1.0				|Uses an old WON HL 1.0.0.16- interface.			|Recreated source code here: https://github.com/FWGS/hlsdk-xash3d/tree/rebellion.
-|Sven-Coop						|5.0+				|Uses custom GoldSrc engine.					|
-|Time Shadows						|Beta 0.1			|Uses Direct3D renderer.					|
+|Blue Shift						|The latest steam release	|Uses vgui2 library which xash3d does not support		|Recreated source code here: https://github.com/FWGS/hlsdk-xash3d/tree/bshift
+|Counter Strike						|1.6(The latest steam release)	|Uses vgui2 library which xash3d does not support		|Some work on vgui2 support was made here: https://github.com/FWGS/xash3d/tree/vinterface
+|Counter Strike: Condition Zero				|The latest steam release	|Uses vgui2 library which xash3d does not support		|Some work on vgui2 support was made here: https://github.com/FWGS/xash3d/tree/vinterface
+|Counter Strike: Condition Zero - Deleted scenes	|The latest steam release	|Uses vgui2 library which xash3d does not support		|Some work on vgui2 support was made here: https://github.com/FWGS/xash3d/tree/vinterface
+|Day of Defeat						|The latest steam release	|Uses vgui2 library which xash3d does not support		|Some work on vgui2 support was made here: https://github.com/FWGS/xash3d/tree/vinterface
+|Sven-Coop						|5.0+				|Uses custom GoldSrc engine					|
+

Documentation/opensource-mods.md

@@ -32,21 +32,12 @@ Version 1.9 mirrored on github - https://github.com/solidi/hl-mods/tree/master/c
 ## Cold Ice Ressurection
 Mirrored on github - https://github.com/solidi/hl-mods/tree/master/cir
 
-## Counter-Life
-Available on ModDB - https://www.moddb.com/mods/counter-life/downloads/cl-version-1-source-code
-
 ## Cthulhu
 Uploaded to github by Oleg Cherkasky - https://github.com/gunrunners-paradise/Cthulhu-HLmod-SDK
 
 ## Deathmatch Classic
 Available in Valve's Half-Life repository - https://github.com/ValveSoftware/halflife/tree/master/dmc
 
-## Delta Particles
-Available on ModDB - https://www.moddb.com/mods/half-life-delta/downloads/delta-particles-full-sources-maps-and-c-code
-
-## Earth Special Forces
-Alpha 2.0 - https://www.gamers-desire.de/details/2830
-
 ## ESHQ
 Official github repository - https://github.com/adslbarxatov/xash3d-for-ESHQ
 

Documentation/psvita.md

@@ -2,14 +2,11 @@
 
 ### Prerequisites
 1. Make sure your PSVita is [set up to run homebrew applications](https://vita.hacks.guide/).
-2. Install [kubridge](https://github.com/TheOfficialFloW/kubridge/releases/). It is recommended to use kubridge version `0.1`, because other versions aren't tested, we don't know are they suitable or not.
-
-   Worth to notice, we got reports that automatic plugins management app EasyPlugin have issues with installing kubridge plugin, so it's better to install it manually: by copying `kubridge.suprx` to your taiHEN plugins folder (usually `ux0:/tai`, but could be `ur0:/tai`) and add it to your `config.txt`, for example:
+2. Install [kubridge](https://github.com/TheOfficialFloW/kubridge/releases/) by copying `kubridge.suprx` to your taiHEN plugins folder (usually `ux0:/tai`) and add it to your `config.txt`, for example:
    ```
    *KERNEL
    ux0:tai/kubridge.skprx
    ```
-
 3. Install `libshacccg.suprx` by following [this guide](https://cimmerian.gitbook.io/vita-troubleshooting-guide/shader-compiler/extract-libshacccg.suprx).
 
 ### Installation

Documentation/touch-controls.md

@@ -1,149 +0,0 @@
-# Touch controls configuring
-
-## Introduction
-
-Thanks to mittorn, we have the ability to fully customize the controls in Xash3D. The new config allows you to not only add and change control buttons, but also create custom menus. There is also a built-in visual editor available, which simplifies the customization process without the need for manual file editing.
-
-## Editor mode usage
-
-1. Launch Xash3D and start the game.
-2. To enter the edit mode, click on the gear icon (command `touch_enableedit`).
-3. In the edit mode, the grid is displayed. The number of cells can be changed with the command `touch_grid_count` (default is 50). The grid can be disabled with the command `touch_grid_enable 0`.
-
-*Touch controls layout editor*
-![](images/editor.jpg)
-
-*Touch profiles window*
-![](images/touch-profiles.jpg)
-
-*Touch buttons parameters window*
-![](images/touch-buttons.jpg)
-
-## Layout editor features
-
-* **Moving buttons**: click on a button, drag it to the desired location, and release.
-* **Resizing buttons**: place your first finger on the top left corner of the button, and use your second finger to resize it.
-* **Hiding/showing buttons**: select the button (it will turn red), then use the menu:
-    * **Close**: closes the editing mode (`touch_disableedit`).
-    * **Reset**: resets the button to its default values.
-    * **Hide/Show**: hides or shows the button (`touch_hide <name>` / `touch_show <name>`).
-
-## Working with configuration files / console
-
-All changes made in the visual editor are automatically saved to the touch profile file. The files are located in the `touch_profiles` folder inside game directory. The file name depends on the selected profile.
-
-### Common commands in configuration files
-
-```
-// Comment: lines starting with // are ignored.
-
-// Swipe zones for movement. Specify how far you need to swipe to speed up.
-// The default values ​​are set to be optimal for a small swipe to immediately walk quickly.
-touch_forwardzone "0.060000" ; touch_sidezone "0.060000"
-
-// Sensitivity settings (pitch - horizontal, yaw - vertical).
-touch_pitch ; touch_yaw
-
-// Grid settings (see above).
-touch_grid_count ; touch_grid_enable
-
-// Draws a border around the button.
-touch_set_stroke <thickness> <c> <v> <e> <t>
-(<r> - red; <g> - green; <b> - blue; <a> - alpha/transparency)
-
-// Show (1) or hide (0) client buttons.
-touch_setclientonly
-
-// Removes all buttons from the screen.
-touch_removeall
-
-// Shows all available buttons in the configuration file.
-touch_list
-
-// Saves the config after editing. You can specify a new file name.
-touch_config_file command.cfg
-```
-
-*The full list of buttons in the standard `touch.cfg` file, displayed in the console when using `touch_list`.*
-![](images/example2.jpg)
-
-
-## Adding new buttons
-
-To add a new button, use the console command:
-
-```
-touch_addbutton "digits" "touch/key_1.png" "toggle_digits" 0.340000 0.782222 0.400000 0.888889 255 255 255 100 0
-```
-
-### Parameters of `touch_addbutton` command
-
-| Parameter | Description |
-| --- | --- |
-| `"digits"` | Unique name of the button. |
-| `"touch/key_1.png"` | Path to the icon file (`.png` format). If the icon is not needed, leave `""`. |
-| `"toggle_digits"` | Command to execute after clicking (for example, `"buy"` for purchase). |
-| `0.340000` | X coordinate of the upper-left corner of the button. |
-| `0.782222` | Y coordinate of the upper-left corner of the button. |
-| `0.400000` | X coordinate of the lower-right corner of the button. |
-| `0.888889` | Y coordinate of the lower-right corner of the button. |
-| `255 255 255` | Button color in RGB format. |
-| `100` | Button transparency (0 - fully transparent, 255 - fully opaque). |
-| `0` | Flags (see next section). |
-
-## List of flags
-
-Flags define the behavior of the button. Their values ​​are powers of two:
-
-| Flag | Value | Description |
-| --- | --- | --- |
-| `TOUCH_FL_HIDE` | 1 | Hides the button (not displayed in the game, but visible in the editor). |
-| `TOUCH_FL_NOEDIT` | 2 | Disables editing of the button in the editor. |
-| `TOUCH_FL_CLIENT` | 4 | The button is client-side (not saved in the main control file). |
-| `TOUCH_FL_MP` | 8 | The button is displayed only in multiplayer. |
-| `TOUCH_FL_SP` | 16 | The button is displayed only in singleplayer. |
-| `TOUCH_FL_DEF_SHOW` | 32 | The button is always displayed on startup. |
-| `TOUCH_FL_DEF_HIDE` | 64 | The button is always hidden on startup. |
-| `TOUCH_FL_DRAW_ADDITIVE` | 128 | The button colors are added together in blend mode. |
-| `TOUCH_FL_STROKE` | 256 | Enables outline stroke around the button. |
-
-Flags can be combined by adding their values ​​together. For example, `5 = 1 + 4` is the combination of `TOUCH_FL_HIDE` and `TOUCH_FL_CLIENT` flags, which is a hidden client button.
-
-*In the image below, the `spray`, `scores`, `messagemode` buttons are displayed simultaneously with the flag 8 and `loadquick`, `savequick` with the flag 16, and each is displayed in the corresponding game mode.*
-![](images/example1.jpg)
-
-## Useful commands
-
-* `touch_hide <pattern>`: hides buttons by pattern.
-* `touch_setcommand`: changes the command bound to a button.
-* `touch_settexture`: quickly changes the button image.
-* `touch_setcolor`: sets the button color.
-* `touch_exportconfig`: exports the current configuration, including aspect ratio.
-
-## Usage examples
-
-* `touch_hide menu*` hides all buttons with names starting with `menu`.
-* `touch_setcolor "attack" 255 160 0 128` changes the color of the primary fire button from opaque white to translucent orange, similar to the color of the HUD in Half-Life.
-
-    *Result of executing this command*
-    ![](images/example3.jpg)
-
-* Example of adding a new button with a custom icon (the `lastinv` command is used - quick change between weapons)
-    ![](images/example4.jpg)
-
-    *View of this button in layout editor*
-    ![](images/example5.jpg)
-
-## Tips
-
-* To prevent the `look` and `move` buttons from interfering with editing other elements, place them before the others in the configuration file.
-* And vice versa, to make a button appear on top of others, place it at the end of the configuration file.
-* You can assign commands to buttons that change other buttons, see the previous section "Usage examples".
-* After editing each parameter of each individual button in the Touch Buttons section, do not forget to press Save, otherwise the applied parameters will not be saved.
-* To create your own icon for the button, you can use any graphics editor (for Android, Photo Editor by iudesk is suitable). Saving conditions:
-    * Image format - `.png` with transparency (e.g. alpha channel)
-    * Aspect ratio / size - 1:1 / 256x256
-    * Path to the icons location - `touch/gfx` inside game directory.
-    
-### Additional links
-* [Handy palette for selecting color in RGB format](https://www.rapidtables.com/web/color/RGB_Color.html)

README.md

@@ -1,9 +1,8 @@
 # Xash3D FWGS Engine <img align="right" width="128" height="128" src="https://github.com/FWGS/xash3d-fwgs/raw/master/game_launch/icon-xash-material.png" alt="Xash3D FWGS icon" />
-[![GitHub Actions Status](https://github.com/FWGS/xash3d-fwgs/actions/workflows/c-cpp.yml/badge.svg)](https://github.com/FWGS/xash3d-fwgs/actions/workflows/c-cpp.yml) [![FreeBSD Build Status](https://img.shields.io/cirrus/github/FWGS/xash3d-fwgs?label=freebsd%20build)](https://cirrus-ci.com/github/FWGS/xash3d-fwgs) \
-[![Discord Server](https://img.shields.io/discord/355697768582610945?logo=Discord&label=International%20Discord%20chat)](http://fwgsdiscord.mentality.rip/) [![Russian speakers Telegram Chat](https://img.shields.io/badge/Russian_speakers_Telegram_chat-gray?logo=Telegram)](https://t.me/flyingwithgauss) \
-[![Download Daily Build](https://img.shields.io/badge/downloads-testing-orange)](https://github.com/FWGS/xash3d-fwgs/releases/tag/continuous)
+[![builds.sr.ht status](https://builds.sr.ht/~a1batross/xash3d-fwgs.svg)](https://builds.sr.ht/~a1batross/xash3d-fwgs?) [![GitHub Actions Status](https://github.com/FWGS/xash3d-fwgs/actions/workflows/c-cpp.yml/badge.svg)](https://github.com/FWGS/xash3d-fwgs/actions/workflows/c-cpp.yml) [![FreeBSD Build Status](https://img.shields.io/cirrus/github/FWGS/xash3d-fwgs?label=freebsd%20build)](https://cirrus-ci.com/github/FWGS/xash3d-fwgs) [![Discord Server](https://img.shields.io/discord/355697768582610945.svg)](http://fwgsdiscord.mentality.rip/) \
+[![Download Stable](https://img.shields.io/badge/download-stable-yellow)](https://github.com/FWGS/xash3d-fwgs/releases/latest) [![Download Testing](https://img.shields.io/badge/downloads-testing-orange)](https://github.com/FWGS/xash3d-fwgs/releases/tag/continuous)
 
-Xash3D ([pronounced](https://ipa-reader.com/?text=ks%C9%91%CA%82) `[ksɑʂ]`) FWGS is a game engine, aimed to provide compatibility with Half-Life Engine and extend it, as well as to give game developers well known workflow.
+Xash3D (pronounced `[ksɑʂ]`) FWGS is a game engine, aimed to provide compatibility with Half-Life Engine and extend it, as well as to give game developers well known workflow.
 
 Xash3D FWGS is a heavily modified fork of an original [Xash3D Engine](https://www.moddb.com/engines/xash3d-engine) by Unkle Mike.
 
@@ -44,7 +43,7 @@ For additional info, run Xash3D with `-help` command line key.
 ## Build instructions
 We are using Waf build system. If you have some Waf-related questions, I recommend you to read [Waf Book](https://waf.io/book/).
 
-**NOTE: NEVER USE GitHub's ZIP ARCHIVES. GitHub doesn't include external dependencies we're using!**
+NOTE: NEVER USE GitHub's ZIP ARCHIVES. GitHub doesn't include external dependencies we're using!
 
 ### Prerequisites
 If your CPU is x86 compatible and you're on Windows or Linux, we are building 32-bit code by default. This was done to maintain compatibility with Steam releases of Half-Life and based on it's engine games.
@@ -66,21 +65,21 @@ This repository contains our fork of HLSDK and restored source code for Half-Lif
 * Only for 32-bit engine on 64-bit x86 operating system:
   * Enable i386 on your system: `$ sudo dpkg --add-architecture i386`.
   * Install `aptitude` ([why?](https://github.com/FWGS/xash3d-fwgs/issues/1828#issuecomment-2415131759)):  `$ sudo apt update && sudo apt upgrade && sudo apt install aptitude`
-  * Install development tools: `$ sudo aptitude --without-recommends install git build-essential gcc-multilib g++-multilib libsdl2-dev:i386 libfreetype-dev:i386 libopus-dev:i386 libbz2-dev:i386 libvorbis-dev:i386 libopusfile-dev:i386 libogg-dev:i386`.
+  * Install development tools: `$ sudo aptitude --without-recommends install git build-essential gcc-multilib g++-multilib libsdl2-dev:i386 libfontconfig-dev:i386 libfreetype-dev:i386 libopus-dev:i386 libbz2-dev:i386`.
   * Set PKG_CONFIG_PATH environment variable to point at 32-bit libraries: `$ export PKG_CONFIG_PATH=/usr/lib/i386-linux-gnu/pkgconfig`.
 
 * For 64-bit engine on 64-bit x86 and other non-x86 systems:
-  * Install development tools: `$ sudo apt install git build-essential python libsdl2-dev libfreetype6-dev libopus-dev libbz2-dev libvorbis-dev libopusfile-dev libogg-dev`.
+  * Install development tools: `$ sudo apt install git build-essential python libsdl2-dev libfontconfig-dev libfreetype6-dev libopus-dev libbz2-dev`.
 
 * Clone this repostory: `$ git clone --recursive https://github.com/FWGS/xash3d-fwgs`.
 
 ##### RedHat/Fedora
 * Only for 32-bit engine on 64-bit x86 operating system:
-  * Install development tools: `$ sudo dnf install git gcc gcc-c++ glibc-devel.i686 SDL2-devel.i686 opus-devel.i686 freetype-devel.i686 bzip2-devel.i686 libvorbis-devel.i686 opusfile-devel.i686 libogg-devel.i686`.
+  * Install development tools: `$ sudo dnf install git gcc gcc-c++ glibc-devel.i686 SDL2-devel.i686 opus-devel.i686 fontconfig-devel.i686 freetype-devel.i686 bzip2-devel.i686`.
   * Set PKG_CONFIG_PATH environment variable to point at 32-bit libraries: `$ export PKG_CONFIG_PATH=/usr/lib/pkgconfig`.
 
 * For 64-bit engine on 64-bit x86 and other non-x86 systems:
-  * Install development tools: `$ sudo dnf install git gcc gcc-c++ SDL2-devel opus-devel freetype-devel bzip2-devel libvorbis-devel opusfile-devel libogg-devel`.
+  * Install development tools: `$ sudo dnf install git gcc gcc-c++ SDL2-devel opus-devel fontconfig-devel freetype-devel bzip2-devel`.
 
 * Clone this repostory: `$ git clone --recursive https://github.com/FWGS/xash3d-fwgs`.
 

android/app/CMakeLists.txt

@@ -1,39 +1,49 @@
-cmake_minimum_required(VERSION 3.22)
+cmake_minimum_required(VERSION 3.6)
 
 # Only used to build Android project
 
 project(XASH_ANDROID)
 
 # armeabi-v7a requires cpufeatures library
-if(ANDROID)
-	include_directories(${ANDROID_NDK}/sources/android/cpufeatures)
-	add_library(cpufeatures ${ANDROID_NDK}/sources/android/cpufeatures/cpu-features.c)
-	target_link_libraries(cpufeatures dl)
-endif()
+include(AndroidNdkModules)
+android_ndk_import_module_cpufeatures()
 
-include(FindPython)
+find_package(PythonInterp 2.7 REQUIRED)
+
+get_filename_component(C_COMPILER_ID ${CMAKE_C_COMPILER} NAME_WE)
+get_filename_component(CXX_COMPILER_ID ${CMAKE_CXX_COMPILER} NAME_WE)
 
 if("${CMAKE_BUILD_TYPE}" STREQUAL "Debug")
 	set(BUILD_TYPE "debug")
 else()
 	set(BUILD_TYPE "release")
-	list(APPEND WAF_EXTRA_ARGS --enable-poly-opt --enable-lto --enable-limited-debuginfo)
+	list(APPEND WAF_EXTRA_ARGS --enable-poly-opt --enable-lto)
 endif()
 
-if(ANDROID_ABI STREQUAL "x86")
-	# HACKHACK: I don't know why but engine gets built as 64-bit binary here
-	list(APPEND WAF_EXTRA_ARGS -4)
+if(CMAKE_SIZEOF_VOID_P MATCHES "8")
+	set(64BIT ON CACHE BOOL "" FORCE)
+	list(APPEND WAF_EXTRA_ARGS -8) # only required for x86 when testing this cmakelist under linux
 endif()
 
 set(CMAKE_VERBOSE_MAKEFILE ON)
 
+set(WAF_CC "${CMAKE_C_COMPILER} --target=${CMAKE_C_COMPILER_TARGET}")
+set(WAF_CXX "${CMAKE_CXX_COMPILER} --target=${CMAKE_CXX_COMPILER_TARGET}")
 
 # not cleanest way to get upper directory
 set(ENGINE_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../../")
 
-set(WAF_CC "${CMAKE_C_COMPILER} --target=${CMAKE_C_COMPILER_TARGET}")
-set(WAF_CXX "${CMAKE_CXX_COMPILER} --target=${CMAKE_CXX_COMPILER_TARGET}")
-set(WAF ${Python_EXECUTABLE} ${ENGINE_SOURCE_DIR}waf -t ${ENGINE_SOURCE_DIR} -o ${CMAKE_CURRENT_BINARY_DIR}/xash3d-fwgs)
+execute_process(
+	COMMAND ${CMAKE_COMMAND} -E env
+	CC=${WAF_CC} CXX=${WAF_CXX}
+	AR=${CMAKE_AR} STRIP=${CMAKE_STRIP}
+	${PYTHON_EXECUTABLE} waf configure -T ${BUILD_TYPE} ${WAF_EXTRA_ARGS} cmake
+	--check-c-compiler=${C_COMPILER_ID} --check-cxx-compiler=${CXX_COMPILER_ID}
+	-s "${ENGINE_SOURCE_DIR}/3rdparty/SDL" --skip-sdl2-sanity-check --enable-bundled-deps
+	WORKING_DIRECTORY "${ENGINE_SOURCE_DIR}"
+)
+
+add_subdirectory("${ENGINE_SOURCE_DIR}/3rdparty/hlsdk-portable" hlsdk-portable)
 
 # try to build minimal SDL. Enable features as we're gonna use them
 set(SDL_RENDER OFF)
@@ -46,50 +56,5 @@ set(SDL_VULKAN OFF)
 set(SDL_OFFSCREEN OFF)
 set(SDL_STATIC OFF)
 add_subdirectory("${ENGINE_SOURCE_DIR}/3rdparty/SDL" SDL)
-
-include(ExternalProject)
-
-# gradle passes backslashes to cmake, how does this even work for everybody else?
-string(REPLACE "\\" "/" CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
-
-ExternalProject_Add(
-	Xash3DFWGS
-	SOURCE_DIR ${ENGINE_SOURCE_DIR}
-	INSTALL_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}
-	BUILD_IN_SOURCE TRUE
-	DEPENDS SDL2
-	BUILD_ALWAYS TRUE
-	LOG_CONFIGURE TRUE
-	LOG_BUILD TRUE
-	LOG_INSTALL TRUE
-	LOG_OUTPUT_ON_FAILURE TRUE
-	LOG_MERGED_STDOUTERR TRUE
-
-#	USES_TERMINAL_CONFIGURE TRUE
-#	USES_TERMINAL_BUILD TRUE
-#	USES_TERMINAL_INSTALL TRUE
-
-	# NOTE: setting up WAFLOCK is important to avoid possible race conditions
-	CONFIGURE_COMMAND ${CMAKE_COMMAND} -E env
-		ANDROID_NDK=${ANDROID_NDK}
-		BUILD_CMAKE_LIBRARY_OUTPUT_DIRECTORY=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}
-		WAFLOCK=.lock-waf_android_${ANDROID_ABI}_build
-		${WAF} configure -T ${BUILD_TYPE} --android=${ANDROID_ABI},,${CMAKE_SYSTEM_VERSION}
-		-s "${ENGINE_SOURCE_DIR}/3rdparty/SDL" --enable-bundled-deps ${WAF_EXTRA_ARGS}
-
-	BUILD_COMMAND ${CMAKE_COMMAND} -E env
-		WAFLOCK=.lock-waf_android_${ANDROID_ABI}_build
-		${WAF} build -v
-
-	INSTALL_COMMAND ${CMAKE_COMMAND} -E env
-		WAFLOCK=.lock-waf_android_${ANDROID_ABI}_build
-		${WAF} install --destdir=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}
-)
-
-add_subdirectory("${ENGINE_SOURCE_DIR}/3rdparty/hlsdk-portable" hlsdk-portable)
-
-# a1ba: without this, xash3d target will be ignored as nothing depends on it
-add_dependencies(client Xash3DFWGS)
-add_dependencies(server Xash3DFWGS)
-
-
+add_subdirectory("${ENGINE_SOURCE_DIR}/" xash3d-fwgs)
+add_subdirectory("${ENGINE_SOURCE_DIR}/3rdparty/mainui" mainui)

android/app/build.gradle.kts

@@ -9,7 +9,7 @@ plugins {
 
 android {
     namespace = "su.xash.engine"
-    ndkVersion = "28.0.13004108"
+    ndkVersion = "27.2.12479018"
 
     defaultConfig {
         applicationId = "su.xash"
@@ -96,7 +96,6 @@ android {
     packaging {
         jniLibs {
             useLegacyPackaging = true
-            keepDebugSymbols.add("**/*.so")
         }
     }
 }
@@ -113,7 +112,7 @@ dependencies {
     implementation("androidx.preference:preference-ktx:1.2.1")
     implementation("androidx.swiperefreshlayout:swiperefreshlayout:1.1.0")
     implementation("androidx.work:work-runtime-ktx:2.9.0")
-//  implementation "androidx.legacy:legacy-support-v4:1.0.0"
+//    implementation "androidx.legacy:legacy-support-v4:1.0.0"
 
     implementation("com.madgag.spongycastle:prov:1.58.0.0")
     implementation("in.dragonbra:javasteam:1.2.0")

android/app/src/main/java/su/xash/engine/XashActivity.java

@@ -30,18 +30,6 @@ public class XashActivity extends SDLActivity {
         AndroidBug5497Workaround.assistActivity(this);
     }
 
-    @Override
-    public void onDestroy()
-    {
-        super.onDestroy();
-
-        // Now that we don't exit from native code, we need to exit here, resetting
-        // application state (actually global variables that we don't cleanup on exit)
-        //
-        // When the issue with global variables will be resolved, remove that exit() call
-        System.exit(0);
-    }
-
     @Override
     protected String[] getLibraries() {
         return new String[]{"SDL2", "xash"};

android/app/src/main/java/su/xash/engine/ui/library/LibraryFragment.kt

@@ -2,7 +2,6 @@ package su.xash.engine.ui.library
 
 import android.annotation.SuppressLint
 import android.content.Intent
-import android.content.ActivityNotFoundException
 import android.os.Bundle
 import android.util.Log
 import android.view.LayoutInflater
@@ -11,7 +10,6 @@ import android.view.MenuInflater
 import android.view.MenuItem
 import android.view.View
 import android.view.ViewGroup
-import android.widget.Toast
 import androidx.core.view.MenuProvider
 import androidx.fragment.app.Fragment
 import androidx.fragment.app.activityViewModels
@@ -75,16 +73,11 @@ class LibraryFragment : Fragment(), MenuProvider {
     override fun onMenuItemSelected(menuItem: MenuItem): Boolean {
         when (menuItem.itemId) {
             R.id.action_browse -> {
-                try {
-                    startActivity(
-                        Intent(Intent.ACTION_VIEW).setDataAndType(
-                            null, "vnd.android.document/directory"
-                        )
+                startActivity(
+                    Intent(Intent.ACTION_VIEW).setDataAndType(
+                        null, "vnd.android.document/directory"
                     )
-                }
-                catch(e: ActivityNotFoundException) {
-                    Toast.makeText(getActivity(), R.string.library_fragment_no_file_manager, Toast.LENGTH_LONG).show()
-                }
+                )
             }
 
             R.id.action_install -> {
@@ -98,4 +91,4 @@ class LibraryFragment : Fragment(), MenuProvider {
 
         return false
     }
-}
+}

android/app/src/main/res/values/strings.xml

@@ -33,5 +33,4 @@
     <string name="preferences_client_package">Client package</string>
     <string name="preferences_server_package">Server package</string>
     <string name="preferences_use_icons">Use icons instead of backgrounds</string>
-    <string name="library_fragment_no_file_manager">File manager is missing</string>
-</resources>
+</resources>

android/gradle.properties

@@ -20,7 +20,4 @@ kotlin.code.style=official
 # Enables namespacing of each library's R class so that its R class includes only the
 # resources declared in the library itself and none from the library's dependencies,
 # thereby reducing the size of the R class for that library
-android.nonTransitiveRClass=true
-
-# Enable verbose output for CMake
-android.native.buildOutput=verbose
+android.nonTransitiveRClass=true

common/bspfile.h

@@ -16,6 +16,8 @@ GNU General Public License for more details.
 #ifndef BSPFILE_H
 #define BSPFILE_H
 
+//#define SUPPORT_BSP2_FORMAT		// allow to loading Darkplaces BSP2 maps (with broke binary compatibility)
+
 /*
 ==============================================================================
 
@@ -63,6 +65,7 @@ BRUSH MODELS
 #define MAX_MAP_CLIPNODES_BSP2  524288
 
 // these limis not using by modelloader but only for displaying 'mapstats' correctly
+#ifdef SUPPORT_BSP2_FORMAT
 #define MAX_MAP_MODELS		2048		// embedded models
 #define MAX_MAP_ENTSTRING		0x200000		// 2 Mb should be enough
 #define MAX_MAP_PLANES		131072		// can be increased without problems
@@ -72,6 +75,18 @@ BRUSH MODELS
 #define MAX_MAP_VERTS		524288		// can be increased without problems
 #define MAX_MAP_FACES		262144		// can be increased without problems
 #define MAX_MAP_MARKSURFACES		524288		// can be increased without problems
+#else
+// increased to match PrimeXT compilers
+#define MAX_MAP_MODELS		1024		// embedded models
+#define MAX_MAP_ENTSTRING		0x100000		// 1 Mb should be enough
+#define MAX_MAP_PLANES		65536		// can be increased without problems
+#define MAX_MAP_NODES		32767		// because negative shorts are leafs
+#define MAX_MAP_CLIPNODES		MAX_MAP_CLIPNODES_HLBSP		// because negative shorts are contents
+#define MAX_MAP_LEAFS		32767		// signed short limit
+#define MAX_MAP_VERTS		65535		// unsigned short limit
+#define MAX_MAP_FACES		65535		// unsigned short limit
+#define MAX_MAP_MARKSURFACES		65535		// unsigned short limit
+#endif
 
 #define MAX_MAP_ENTITIES		8192		// network limit
 #define MAX_MAP_TEXINFO		MAX_MAP_FACES	// in theory each face may have personal texinfo

common/com_model.h

@@ -60,29 +60,26 @@ typedef struct
 	vec3_t		position;
 } mvertex_t;
 
-typedef struct mclipnode32_s
+typedef struct
 {
-	int planenum;
-	int children[2]; // negative numbers are contents
-} mclipnode32_t;
-
-typedef struct mclipnode16_s
-{
-	int   planenum;
-	short children[2];	// negative numbers are contents
-} mclipnode16_t;
+	int		planenum;
+#ifdef SUPPORT_BSP2_FORMAT
+	int		children[2];	// negative numbers are contents
+#else
+	short		children[2];	// negative numbers are contents
+#endif
+} mclipnode_t;
 
 // size is matched but representation is not
-typedef struct medge32_s
+typedef struct
 {
+#ifdef SUPPORT_BSP2_FORMAT
 	unsigned int	v[2];
-} medge32_t;
-
-typedef struct medge16_s
-{
+#else
 	unsigned short	v[2];
 	unsigned int	cachededgeoffset;
-} medge16_t;
+#endif
+} medge_t;
 
 typedef struct texture_s
 {
@@ -159,31 +156,13 @@ typedef struct mnode_s
 
 // node specific
 	mplane_t		*plane;
-
-#if !XASH_64BIT
-	union
-	{
-		struct mnode_s *children_[2];
-		struct
-		{
-			// the ordering is important
-			int child_0_leaf    : 1;
-			int child_0_off     : 23;
-			int firstsurface_1  : 8;
-			int child_1_leaf    : 1;
-			int child_1_off     : 23;
-			int numsurfaces_1   : 8;
-		};
-	};
-	unsigned short	firstsurface_0;
-	unsigned short	numsurfaces_0;
+	struct mnode_s	*children[2];
+#ifdef SUPPORT_BSP2_FORMAT
+	int		firstsurface;
+	int		numsurfaces;
 #else
-	// in 64-bit ABI this struct has 4 more bytes of padding, let's use it!
-	struct mnode_s	*children_[2];
-	unsigned short	firstsurface_0;
-	unsigned short	numsurfaces_0;
-	unsigned short	firstsurface_1;
-	unsigned short	numsurfaces_1;
+	unsigned short	firstsurface;
+	unsigned short	numsurfaces;
 #endif
 } mnode_t;
 
@@ -224,6 +203,7 @@ typedef struct mleaf_s
 	int		nummarksurfaces;
 	int		cluster;		// helper to acess to uncompressed visdata
 	byte		ambient_sound_level[NUM_AMBIENTS];
+
 } mleaf_t;
 
 // surface extradata
@@ -311,11 +291,7 @@ struct msurface_s
 
 typedef struct hull_s
 {
-	union
-	{
-		mclipnode16_t *clipnodes16;
-		mclipnode32_t *clipnodes32;
-	};
+	mclipnode_t	*clipnodes;
 	mplane_t		*planes;
 	int		firstclipnode;
 	int		lastclipnode;
@@ -365,12 +341,7 @@ typedef struct model_s
 	mvertex_t		*vertexes;
 
 	int		numedges;
-	union
-	{
-		medge16_t *edges16;
-		medge32_t *edges32;
-	};
-
+	medge_t		*edges;
 
 	int		numnodes;
 	mnode_t		*nodes;
@@ -385,11 +356,7 @@ typedef struct model_s
 	int		*surfedges;
 
 	int		numclipnodes;
-	union
-	{
-		mclipnode16_t *clipnodes16;
-		mclipnode32_t *clipnodes32;
-	};
+	mclipnode_t	*clipnodes;
 
 	int		nummarksurfaces;
 	msurface_t	**marksurfaces;
@@ -583,68 +550,16 @@ typedef struct
 #define ANIM_CYCLE			2
 #define MOD_FRAMES			20
 
+
+
 #define MAX_DEMOS		32
 #define MAX_MOVIES		8
 #define MAX_CDTRACKS	32
 #define MAX_CLIENT_SPRITES	512	// SpriteTextures (0-256 hud, 256-512 client)
 #define MAX_REQUESTS	64
 
-STATIC_CHECK_SIZEOF( mnode_t, 52, 72 );
 STATIC_CHECK_SIZEOF( mextrasurf_t, 324, 496 );
 STATIC_CHECK_SIZEOF( decal_t, 60, 88 );
 STATIC_CHECK_SIZEOF( mfaceinfo_t, 176, 304 );
 
-// model flags (stored in model_t->flags)
-#define MODEL_QBSP2 BIT( 28 ) // uses 32-bit types
-
-// access functions
-static inline mnode_t *node_child( const mnode_t *n, int side, const model_t *mod )
-{
-#if !XASH_64BIT
-	if( unlikely( mod->flags & MODEL_QBSP2 )) // MODEL_QBSP2
-	{
-		if( side == 0 )
-		{
-			if( n->child_0_leaf )
-				return (mnode_t *)(mod->leafs + n->child_0_off);
-			else
-				return (mnode_t *)(mod->nodes + n->child_0_off);
-		}
-		else
-		{
-			if( n->child_1_leaf )
-				return (mnode_t *)(mod->leafs + n->child_1_off);
-			else
-				return (mnode_t *)(mod->nodes + n->child_1_off);
-		}
-	}
-
-	return n->children_[side];
-#else
-	return n->children_[side];
-#endif
-}
-
-static inline void node_children( mnode_t *children[2], const mnode_t *n, const model_t *mod )
-{
-	children[0] = node_child( n, 0, mod );
-	children[1] = node_child( n, 1, mod );
-}
-
-static inline int node_firstsurface( const mnode_t *n, const model_t *mod )
-{
-	if( mod->flags & MODEL_QBSP2 )
-		return n->firstsurface_0 + ( n->firstsurface_1 << 16 );
-	else
-		return n->firstsurface_0;
-}
-
-static inline int node_numsurfaces( const mnode_t *n, const model_t *mod )
-{
-	if( mod->flags & MODEL_QBSP2 )
-		return n->numsurfaces_0 + ( n->numsurfaces_1 << 16 );
-	else
-		return n->numsurfaces_0;
-}
-
 #endif//COM_MODEL_H

common/defaults.h

@@ -140,13 +140,13 @@ Default build-depended cvar and constant values
 
 // Platform overrides
 #if XASH_NSWITCH
-	#define DEFAULT_TOUCH_ENABLE "1"
+	#define DEFAULT_TOUCH_ENABLE "0"
 	#define DEFAULT_M_IGNORE     "1"
 	#define DEFAULT_MODE_WIDTH   1280
 	#define DEFAULT_MODE_HEIGHT  720
 	#define DEFAULT_ALLOWCONSOLE 1
 #elif XASH_PSVITA
-	#define DEFAULT_TOUCH_ENABLE "1"
+	#define DEFAULT_TOUCH_ENABLE "0"
 	#define DEFAULT_M_IGNORE     "1"
 	#define DEFAULT_MODE_WIDTH   960
 	#define DEFAULT_MODE_HEIGHT  544
@@ -158,7 +158,7 @@ Default build-depended cvar and constant values
 	#define DEFAULT_M_IGNORE     "1"
 #endif // !XASH_MOBILE_PLATFORM && !XASH_NSWITCH
 
-#if (XASH_ANDROID && !XASH_TERMUX) || XASH_IOS || XASH_EMSCRIPTEN
+#if XASH_ANDROID || XASH_IOS || XASH_EMSCRIPTEN
 	// this means that libraries are provided with engine, but not in game data
 	// You need add library loading code to library.c when adding new platform
 	#define XASH_INTERNAL_GAMELIBS

common/netadr.h

@@ -28,17 +28,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 
 #define	PORT_ANY	-1
 
-typedef enum netadrtype_e
-{
-	NA_UNDEFINED = 0,
-	NA_LOOPBACK,
-	NA_BROADCAST,
-	NA_IP,
-	NA_IPX,
-	NA_BROADCAST_IPX,
-	NA_IP6,
-	NA_MULTICAST_IP6
-} netadrtype_t;
+typedef enum {NA_LOOPBACK = 1, NA_BROADCAST, NA_IP, NA_IPX, NA_BROADCAST_IPX, NA_IP6, NA_MULTICAST_IP6} netadrtype_t;
 
 /*
 Original Quake-2 structure:
@@ -56,60 +46,29 @@ typedef struct
 #pragma pack( push, 1 )
 typedef struct netadr_s
 {
-// the reason we do this evil thing, is that when this struct contains IPv6
-// address the `type` is 2-byte wide, but when it doesn't `type` must 4-byte
-// wide _and_ ip6_0 must be zeroed, to keep it binary compatible.
-#if XASH_LITTLE_ENDIAN
-	uint16_t type;
-	uint8_t  ip6_0[2];
-#elif XASH_BIG_ENDIAN
-	uint8_t  ip6_0[2];
-	uint16_t type;
-#else
-#error
-#endif
-
 	union
 	{
 		// IPv6 struct
-		uint8_t	ip6_1[14];
 		struct
 		{
+			uint16_t	type6;
+			uint8_t	ip6[16];
+		};
+		struct
+		{
+			uint32_t	type; // must be netadrtype_t but will break with short enums
 			union
 			{
-				uint8_t  ip[4];
-				uint32_t ip4; // for easier conversions
+				uint8_t	ip[4];
+				uint32_t	ip4; // for easier conversions
 			};
 			uint8_t	ipx[10];
 		};
 	};
-	uint16_t port;
+	uint16_t	port;
 } netadr_t;
 #pragma pack( pop )
 
-static inline netadrtype_t NET_NetadrType( const netadr_t *a )
-{
-	if( a->type == NA_IP6 || a->type == NA_MULTICAST_IP6 )
-		return (netadrtype_t)a->type;
-
-	if( a->ip6_0[0] || a->ip6_0[1] )
-		return NA_UNDEFINED;
-
-	return (netadrtype_t)a->type;
-}
-
-static inline void NET_NetadrSetType( netadr_t *a, netadrtype_t type )
-{
-	if( type == NA_IP6 || type == NA_MULTICAST_IP6 )
-	{
-		a->type = type;
-		return;
-	}
-
-	a->ip6_0[0] = a->ip6_0[1] = 0;
-	a->type = type;
-}
-
 STATIC_CHECK_SIZEOF( netadr_t, 20, 20 );
 
 #endif // NET_ADR_H

common/port.h

@@ -86,4 +86,8 @@ GNU General Public License for more details.
 #include <string.h>
 #include <limits.h>
 
+#if defined XASH_SDL && !defined REF_DLL
+#include <SDL.h>
+#endif
+
 #endif // PORT_H

common/xash3d_types.h

@@ -13,44 +13,47 @@
 #endif // _WIN32
 
 #include <sys/types.h> // off_t
-#ifdef STDINT_H
 #include STDINT_H
-#else // !STDINT_H
-#include <stdint.h>
-#endif // !STDINT_H
 #include <assert.h>
 
-typedef uint8_t  byte;
-typedef float    vec_t;
-typedef vec_t    vec2_t[2];
-#ifndef vec3_t // SDK renames it to Vector
-typedef vec_t    vec3_t[3];
-#endif
-typedef vec_t    vec4_t[4];
-typedef vec_t    quat_t[4];
-typedef byte     rgba_t[4];	// unsigned byte colorpack
-typedef byte     rgb_t[3];		// unsigned byte colorpack
-typedef vec_t    matrix3x4[3][4];
-typedef vec_t    matrix4x4[4][4];
-typedef uint32_t poolhandle_t;
+typedef unsigned char byte;
+typedef int		sound_t;
+typedef float		vec_t;
+typedef vec_t		vec2_t[2];
+typedef vec_t		vec3_t[3];
+typedef vec_t		vec4_t[4];
+typedef vec_t		quat_t[4];
+typedef byte		rgba_t[4];	// unsigned byte colorpack
+typedef byte		rgb_t[3];		// unsigned byte colorpack
+typedef vec_t		matrix3x4[3][4];
+typedef vec_t		matrix4x4[4][4];
+
+typedef uint32_t        poolhandle_t;
 
 #undef true
 #undef false
 
-// true and false are keywords in C++ and C23
-#if !__cplusplus &&  __STDC_VERSION__ < 202311L
-enum { false, true };
-#endif
+#ifndef __cplusplus
+typedef enum { false, true }	qboolean;
+#else
 typedef int qboolean;
+#endif
 
-#define MAX_STRING    256  // generic string
-#define MAX_VA_STRING 1024 // compatibility macro
-#define MAX_SYSPATH   1024 // system filepath
-#define MAX_MODS      512  // environment games that engine can keep visible
+typedef uint64_t longtime_t;
+
+#define MAX_STRING		256	// generic string
+#define MAX_INFO_STRING	256	// infostrings are transmitted across network
+#define MAX_SERVERINFO_STRING	512	// server handles too many settings. expand to 1024?
+#define MAX_LOCALINFO_STRING	32768	// localinfo used on server and not sended to the clients
+#define MAX_SYSPATH		1024	// system filepath
+#define MAX_VA_STRING	1024	// string length returned by va()
+#define MAX_PRINT_MSG	8192	// how many symbols can handle single call of Con_Printf or Con_DPrintf
+#define MAX_TOKEN		2048	// parse token length
+#define MAX_MODS		512	// environment games that engine can keep visible
+#define MAX_USERMSG_LENGTH	2048	// don't modify it's relies on a client-side definitions
 
 #define BIT( n )		( 1U << ( n ))
 #define BIT64( n )		( 1ULL << ( n ))
-
 #define SetBits( iBitVector, bits )	((iBitVector) = (iBitVector) | (bits))
 #define ClearBits( iBitVector, bits )	((iBitVector) = (iBitVector) & ~(bits))
 #define FBitSet( iBitVector, bit )	((iBitVector) & (bit))
@@ -67,8 +70,6 @@ typedef int qboolean;
 #define IsColorString( p )	( p && *( p ) == '^' && *(( p ) + 1) && *(( p ) + 1) >= '0' && *(( p ) + 1 ) <= '9' )
 #define ColorIndex( c )	((( c ) - '0' ) & 7 )
 
-#undef EXPORT
-
 #if defined( __GNUC__ )
 	#if defined( __i386__ )
 		#define EXPORT         __attribute__(( visibility( "default" ), force_align_arg_pointer ))
@@ -91,10 +92,8 @@ typedef int qboolean;
 	#define NORETURN           __attribute__(( noreturn ))
 	#define NONNULL            __attribute__(( nonnull ))
 	#define RETURNS_NONNULL    __attribute__(( returns_nonnull ))
-	#if __clang__ || __MCST__
-		// clang has bugged returns_nonnull for functions pointers, it's ignored and generates a warning about objective-c? O_o
-		// lcc doesn't support it at all
-		#define PFN_RETURNS_NONNULL
+	#if __clang__
+		#define PFN_RETURNS_NONNULL // clang has bugged returns_nonnull for functions pointers, it's ignored and generates a warning about objective-c? O_o
 	#else
 		#define PFN_RETURNS_NONNULL RETURNS_NONNULL
 	#endif
@@ -210,16 +209,34 @@ _inline float LittleFloat( float f )
 #endif
 
 
-typedef unsigned int dword;
-typedef unsigned int uint;
-typedef char         string[MAX_STRING];
-typedef off_t        fs_offset_t;
+typedef unsigned int  dword;
+typedef unsigned int  uint;
+typedef unsigned long ulong;
+typedef char		string[MAX_STRING];
+typedef struct file_s	file_t;		// normal file
+typedef struct stream_s	stream_t;		// sound stream for background music playing
+typedef off_t fs_offset_t;
 #if XASH_WIN32
-typedef int          fs_size_t; // return type of _read, _write funcs
+typedef int fs_size_t; // return type of _read, _write funcs
 #else /* !XASH_WIN32 */
-typedef ssize_t      fs_size_t;
+typedef ssize_t fs_size_t;
 #endif /* !XASH_WIN32 */
 
+typedef struct dllfunc_s
+{
+	const char	*name;
+	void		**func;
+} dllfunc_t;
+
+typedef struct dll_info_s
+{
+	const char	*name;	// name of library
+	const dllfunc_t	*fcts;	// list of dll exports
+	qboolean		crash;	// crash if dll not found
+	void		*link;	// hinstance of loading library
+} dll_info_t;
+
+typedef void (*setpair_t)( const char *key, const void *value, const void *buffer, void *numpairs );
 typedef void *(*pfnCreateInterface_t)( const char *, int * );
 
 // config strings are a general means of communication from

engine/client/avi/avi_win.c

@@ -30,9 +30,10 @@ static dllfunc_t msvfw_funcs[] =
 { "DrawDibOpen", (void **) &pDrawDibOpen },
 { "DrawDibDraw", (void **) &pDrawDibDraw },
 { "DrawDibClose", (void **) &pDrawDibClose },
+{ NULL, NULL }
 };
 
-dll_info_t msvfw_dll = { "msvfw32.dll", msvfw_funcs, ARRAYSIZE( msvfw_funcs ), false };
+dll_info_t msvfw_dll = { "msvfw32.dll", msvfw_funcs, false };
 
 // msacm32.dll exports
 static MMRESULT (_stdcall *pacmStreamOpen)( LPHACMSTREAM, HACMDRIVER, LPWAVEFORMATEX, LPWAVEFORMATEX, LPWAVEFILTER, DWORD, DWORD, DWORD );
@@ -50,9 +51,10 @@ static dllfunc_t msacm_funcs[] =
 { "acmStreamConvert", (void **) &pacmStreamConvert },
 { "acmStreamSize", (void **) &pacmStreamSize },
 { "acmStreamClose", (void **) &pacmStreamClose },
+{ NULL, NULL }
 };
 
-dll_info_t msacm_dll = { "msacm32.dll", msacm_funcs, ARRAYSIZE( msacm_funcs ), false };
+dll_info_t msacm_dll = { "msacm32.dll", msacm_funcs, false };
 
 // avifil32.dll exports
 static int (_stdcall *pAVIStreamInfo)( PAVISTREAM pavi, AVISTREAMINFO *psi, LONG lSize );
@@ -86,9 +88,10 @@ static dllfunc_t avifile_funcs[] =
 { "AVIStreamRelease", (void **) &pAVIStreamRelease },
 { "AVIStreamStart", (void **) &pAVIStreamStart },
 { "AVIStreamTimeToSample", (void **) &pAVIStreamTimeToSample },
+{ NULL, NULL }
 };
 
-dll_info_t avifile_dll = { "avifil32.dll", avifile_funcs, ARRAYSIZE( avifile_funcs ), false };
+dll_info_t avifile_dll = { "avifil32.dll", avifile_funcs, false };
 
 typedef struct movie_state_s
 {

engine/client/cl_cmds.c

@@ -152,6 +152,19 @@ void CL_PlayCDTrack_f( void )
 	else Con_Printf( "%s: unknown command %s\n", Cmd_Argv( 0 ), command );
 }
 
+/*
+==================
+CL_ScreenshotGetName
+==================
+*/
+static qboolean CL_ScreenshotGetName( const char *fmt, int lastnum, char *filename, size_t size )
+{
+	if( lastnum < 0 || lastnum > 9999 )
+		return false;
+
+	return Q_snprintf( filename, size, fmt, clgame.mapname, lastnum ) > 0;
+}
+
 /*
 ==============================================================================
 
@@ -257,6 +270,7 @@ void CL_GenericShot_f( void )
 	case scrshot_normal:
 	case scrshot_snapshot:
 	{
+		const char *fmt;
 		string checkname;
 		int i;
 
@@ -268,18 +282,15 @@ void CL_GenericShot_f( void )
 		}
 
 		if( type == scrshot_snapshot )
+		{
+			fmt = "../%s_%04d.png";
 			FS_AllowDirectPaths( true );
+		}
+		else fmt = "scrshots/%s_shot%04d.png";
 
 		for( i = 0; i < 9999; i++ )
 		{
-			int ret;
-
-			if( type == scrshot_snapshot )
-				ret = Q_snprintf( checkname, sizeof( checkname ), "../%s_%04d.png", clgame.mapname, i );
-			else
-				ret = Q_snprintf( checkname, sizeof( checkname ), "scrshots/%s_shot%04d.png", clgame.mapname, i );
-
-			if( ret <= 0 )
+			if( !CL_ScreenshotGetName( fmt, i, checkname, sizeof( checkname )))
 			{
 				Con_Printf( S_ERROR "unable to write %s\n", argv0 );
 				FS_AllowDirectPaths( false );

engine/client/cl_debug.c

@@ -153,7 +153,6 @@ static void CL_WriteErrorMessage( int current_count, sizebuf_t *msg )
 
 	FS_Write( fp, &cls.starting_count, sizeof( int ));
 	FS_Write( fp, &current_count, sizeof( int ));
-	FS_Write( fp, &cls.legacymode, sizeof( cls.legacymode ));
 	FS_Write( fp, MSG_GetData( msg ), MSG_GetMaxBytes( msg ));
 	FS_Close( fp );
 
@@ -169,7 +168,7 @@ list last 32 messages for debugging net troubleshooting
 */
 void CL_WriteMessageHistory( void )
 {
-	oldcmd_t	*old;
+	oldcmd_t	*old, *failcommand;
 	sizebuf_t	*msg = &net_message;
 	int	i, thecmd;
 
@@ -193,49 +192,9 @@ void CL_WriteMessageHistory( void )
 		thecmd++;
 	}
 
-	old = &cls_message_debug.oldcmd[thecmd];
-	Con_Printf( S_RED "BAD: " S_DEFAULT "%i %04i %s\n", old->frame_number, old->starting_offset, CL_MsgInfo( old->command ));
-	CL_WriteErrorMessage( old->starting_offset, msg );
+	failcommand = &cls_message_debug.oldcmd[thecmd];
+	Con_Printf( "BAD:  %3i:%s\n", MSG_GetNumBytesRead( msg ) - 1, CL_MsgInfo( failcommand->command ));
+	if( host_developer.value >= DEV_EXTENDED )
+		CL_WriteErrorMessage( MSG_GetNumBytesRead( msg ) - 1, msg );
 	cls_message_debug.parsing = false;
 }
-
-void CL_ReplayBufferDat_f( void )
-{
-	file_t *f = FS_Open( Cmd_Argv( 1 ), "rb", true );
-	sizebuf_t msg;
-	char buffer[NET_MAX_MESSAGE];
-	int starting_count, current_count, protocol;
-	fs_offset_t len;
-
-	if( !f )
-		return;
-
-	FS_Read( f, &starting_count, sizeof( starting_count ));
-	FS_Read( f, &current_count, sizeof( current_count ));
-	FS_Read( f, &protocol, sizeof( protocol ));
-
-	cls.legacymode = protocol;
-
-	len = FS_Read( f, buffer, sizeof( buffer ));
-	FS_Close( f );
-
-	MSG_Init( &msg, __func__, buffer, len );
-
-	Delta_Shutdown();
-	Delta_Init();
-
-	clgame.maxEntities = MAX_EDICTS;
-	clgame.entities = Mem_Calloc( clgame.mempool, sizeof( *clgame.entities ) * clgame.maxEntities );
-
-	// ad-hoc implement
-#if 0
-	{
-		const int message_pos = 12; // put real number here
-		MSG_SeekToBit( &msg, ( message_pos - 12 + 1 ) << 3, SEEK_SET );
-
-		CL_ParseYourMom( &msg, protocol );
-	}
-#endif
-
-	Sys_Quit( __func__ );
-}

engine/client/cl_demo.c

@@ -157,7 +157,7 @@ void CL_StartupDemoHeader( void )
 {
 	CL_CloseDemoHeader();
 
-	cls.demoheader = FS_Open( "demoheader.tmp", "w+bm", true );
+	cls.demoheader = FS_Open( "demoheader.tmp", "w+b", true );
 
 	if( !cls.demoheader )
 	{
@@ -373,7 +373,7 @@ CL_WriteDemoUserMessage
 Dumps the user message (demoaction)
 ====================
 */
-void GAME_EXPORT CL_WriteDemoUserMessage( int size, byte *buffer )
+void CL_WriteDemoUserMessage( const byte *buffer, size_t size )
 {
 	if( !cls.demorecording || cls.demowaiting )
 		return;
@@ -624,10 +624,11 @@ static void CL_ReadDemoUserCmd( qboolean discard )
 
 	if( !discard )
 	{
-		const usercmd_t nullcmd = { 0 };
+		usercmd_t		nullcmd;
 		sizebuf_t		buf;
 		demoangle_t	*a;
 
+		memset( &nullcmd, 0, sizeof( nullcmd ));
 		MSG_Init( &buf, "UserCmd", data, sizeof( data ));
 
 		// a1ba: I have no proper explanation why
@@ -642,7 +643,9 @@ static void CL_ReadDemoUserCmd( qboolean discard )
 		pcmd->sendsize = 1;
 
 		// always delta'ing from null
-		MSG_ReadDeltaUsercmd( &buf, &nullcmd, &pcmd->cmd );
+		cl.cmd = &pcmd->cmd;
+
+		MSG_ReadDeltaUsercmd( &buf, &nullcmd, cl.cmd );
 
 		// make sure what interp info contain angles from different frames
 		// or lerping will stop working
@@ -654,16 +657,13 @@ static void CL_ReadDemoUserCmd( qboolean discard )
 
 			// record update
 			a->starttime = demo.timestamp;
-			VectorCopy( pcmd->cmd.viewangles, a->viewangles );
+			VectorCopy( cl.cmd->viewangles, a->viewangles );
 			demo.lasttime = demo.timestamp;
 		}
 
 		// NOTE: we need to have the current outgoing sequence correct
 		// so we can do prediction correctly during playback
 		cls.netchan.outgoing_sequence = outgoing_sequence;
-
-		// save last usercmd
-		cl.cmd = pcmd->cmd;
 	}
 }
 
@@ -724,7 +724,7 @@ static void CL_DemoStartPlayback( int mode )
 	{
 		// NOTE: at this point demo is still valid
 		CL_Disconnect();
-		SV_Shutdown( "Server was killed due to demo playback start\n" );
+		Host_ShutdownServer();
 
 		Con_FastClose();
 		UI_SetActiveMenu( false );
@@ -1146,7 +1146,8 @@ void CL_DemoInterpolateAngles( void )
 		QuaternionSlerp( q2, q1, frac, q );
 		QuaternionAngle( q, cl.viewangles );
 	}
-	else VectorCopy( cl.cmd.viewangles, cl.viewangles );
+	else if( cl.cmd != NULL )
+		VectorCopy( cl.cmd->viewangles, cl.viewangles );
 }
 
 /*

engine/client/cl_efrag.c

@@ -127,10 +127,8 @@ static void R_SplitEntityOnNode( mnode_t *node )
 	}
 
 	// recurse down the contacted sides
-	if( sides & 1 )
-		R_SplitEntityOnNode( node_child( node, 0, cl.worldmodel ));
-	if( sides & 2 )
-		R_SplitEntityOnNode( node_child( node, 1, cl.worldmodel ));
+	if( sides & 1 ) R_SplitEntityOnNode( node->children[0] );
+	if( sides & 2 ) R_SplitEntityOnNode( node->children[1] );
 }
 
 /*

engine/client/cl_efx.c

@@ -2229,3 +2229,4 @@ void CL_ThinkParticle( double frametime, particle_t *p )
 		break;
 	}
 }
+

engine/client/cl_events.c

@@ -405,11 +405,7 @@ void CL_ParseReliableEvent( sizebuf_t *msg, connprotocol_t proto )
 	}
 
 	if( args.entindex > 0 && args.entindex <= cl.maxclients )
-	{
-		args.angles[PITCH] *= 3.0f;
-		if( !FBitSet( host.features, ENGINE_COMPENSATE_QUAKE_BUG ))
-			args.angles[PITCH] = -args.angles[PITCH];
-	}
+		args.angles[PITCH] *= -3.0f;
 
 	CL_QueueEvent( FEV_RELIABLE|FEV_SERVER, event_index, delay, &args );
 }
@@ -481,9 +477,7 @@ void CL_ParseEvent( sizebuf_t *msg, connprotocol_t proto )
 
 				if( state->number > 0 && state->number <= cl.maxclients )
 				{
-					args.angles[PITCH] *= 3.0f;
-					if( !FBitSet( host.features, ENGINE_COMPENSATE_QUAKE_BUG ))
-						args.angles[PITCH] = -args.angles[PITCH];
+					args.angles[PITCH] *= -3.0f;
 					CL_CalcPlayerVelocity( state->number, args.velocity );
 					args.ducking = ( state->usehull == 1 );
 				}
@@ -493,11 +487,7 @@ void CL_ParseEvent( sizebuf_t *msg, connprotocol_t proto )
 				if( args.entindex != 0 )
 				{
 					if( args.entindex > 0 && args.entindex <= cl.maxclients )
-					{
-						args.angles[PITCH] /= 3.0f;
-						if( !FBitSet( host.features, ENGINE_COMPENSATE_QUAKE_BUG ))
-							args.angles[PITCH] = -args.angles[PITCH];
-					}
+						args.angles[PITCH] /= -3.0f;
 				}
 			}
 

engine/client/cl_font.c

@@ -173,7 +173,7 @@ static int CL_CalcTabStop( const cl_font_t *font, int x )
 	return stop;
 }
 
-int CL_DrawCharacter( float x, float y, int number, const rgba_t color, cl_font_t *font, int flags )
+int CL_DrawCharacter( float x, float y, int number, rgba_t color, cl_font_t *font, int flags )
 {
 	wrect_t *rc;
 	float w, h;
@@ -231,7 +231,7 @@ int CL_DrawCharacter( float x, float y, int number, const rgba_t color, cl_font_
 	return font->charWidths[number];
 }
 
-int CL_DrawString( float x, float y, const char *s, const rgba_t color, cl_font_t *font, int flags )
+int CL_DrawString( float x, float y, const char *s, rgba_t color, cl_font_t *font, int flags )
 {
 	rgba_t current_color;
 	int draw_len = 0;
@@ -287,7 +287,7 @@ int CL_DrawString( float x, float y, const char *s, const rgba_t color, cl_font_
 	return draw_len;
 }
 
-int CL_DrawStringf( cl_font_t *font, float x, float y, const rgba_t color, int flags, const char *fmt, ... )
+int CL_DrawStringf( cl_font_t *font, float x, float y, rgba_t color, int flags, const char *fmt, ... )
 {
 	va_list va;
 	char buf[MAX_VA_STRING];

engine/client/cl_game.c

@@ -13,12 +13,6 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.
 */
 
-#if XASH_SDL == 2
-#include <SDL.h> // SDL_GetWindowPosition
-#elif XASH_SDL == 3
-#include <SDL3/SDL.h> // SDL_GetWindowPosition
-#endif // XASH_SDL
-
 #include "common.h"
 #include "client.h"
 #include "const.h"
@@ -82,6 +76,7 @@ static const dllfunc_t cdll_exports[] =
 { "IN_ClearStates", (void **)&clgame.dllFuncs.IN_ClearStates },
 { "V_CalcRefdef", (void **)&clgame.dllFuncs.pfnCalcRefdef },
 { "KB_Find", (void **)&clgame.dllFuncs.KB_Find },
+{ NULL, NULL }
 };
 
 // optional exports
@@ -96,6 +91,7 @@ static const dllfunc_t cdll_new_exports[] = 	// allowed only in SDK 2.3 and high
 { "IN_ClientTouchEvent", (void **)&clgame.dllFuncs.pfnTouchEvent}, // Xash3D FWGS ext
 { "IN_ClientMoveEvent", (void **)&clgame.dllFuncs.pfnMoveEvent}, // Xash3D FWGS ext
 { "IN_ClientLookEvent", (void **)&clgame.dllFuncs.pfnLookEvent}, // Xash3D FWGS ext
+{ NULL, NULL }
 };
 
 static void pfnSPR_DrawHoles( int frame, int x, int y, const wrect_t *prc );
@@ -312,22 +308,21 @@ void SPR_AdjustSize( float *x, float *y, float *w, float *h )
 
 static void SPR_AdjustTexCoords( int texnum, float width, float height, float *s1, float *t1, float *s2, float *t2 )
 {
-	const qboolean filtering = REF_GET_PARM( PARM_TEX_FILTERING, texnum );
-	const int xremainder = refState.width % clgame.scrInfo.iWidth;
-	const int yremainder = refState.height % clgame.scrInfo.iHeight;
-
-	if(( filtering || xremainder ) && refState.width != clgame.scrInfo.iWidth )
+	if( REF_GET_PARM( PARM_TEX_FILTERING, texnum ))
 	{
-		// align to texel if scaling
-		*s1 += 0.5f;
-		*s2 -= 0.5f;
-	}
+		if( refState.width != clgame.scrInfo.iWidth )
+		{
+			// align to texel if scaling
+			*s1 += 0.5f;
+			*s2 -= 0.5f;
+		}
 
-	if(( filtering || yremainder ) && refState.height != clgame.scrInfo.iHeight )
-	{
-		// align to texel if scaling
-		*t1 += 0.5f;
-		*t2 -= 0.5f;
+		if( refState.height != clgame.scrInfo.iHeight )
+		{
+			// align to texel if scaling
+			*t1 += 0.5f;
+			*t2 -= 0.5f;
+		}
 	}
 
 	*s1 /= width;
@@ -563,7 +558,7 @@ static void CL_InitTitles( const char *filename )
 
 		Q_snprintf( name, sizeof( name ), TEXT_MSGNAME, i );
 
-		cl_textmessage[i].pName = copystringpool( clgame.mempool, name );
+		cl_textmessage[i].pName = _copystring( clgame.mempool, name, __FILE__, __LINE__ );
 		cl_textmessage[i].pMessage = cl_textbuffer[i];
 	}
 
@@ -981,7 +976,7 @@ static void CL_ClearUserMessage( char *pszName, int svc_num )
 	int i;
 
 	for( i = 0; i < MAX_USER_MESSAGES && clgame.msg[i].name[0]; i++ )
-		if( ( clgame.msg[i].number == svc_num ) && Q_stricmp( clgame.msg[i].name, pszName ) )
+		if( ( clgame.msg[i].number == svc_num ) && Q_strcmp( clgame.msg[i].name, pszName ) )
 			clgame.msg[i].number = 0;
 }
 
@@ -1051,7 +1046,7 @@ void CL_InitEdicts( int maxclients )
 	cls.num_client_entities = CL_UPDATE_BACKUP * NUM_PACKET_ENTITIES;
 	cls.packet_entities = Mem_Realloc( clgame.mempool, cls.packet_entities, sizeof( entity_state_t ) * cls.num_client_entities );
 	clgame.entities = Mem_Calloc( clgame.mempool, sizeof( cl_entity_t ) * clgame.maxEntities );
-	clgame.static_entities = NULL; // will be initialized later
+	clgame.static_entities = Mem_Calloc( clgame.mempool, sizeof( cl_entity_t ) * MAX_STATIC_ENTITIES );
 	clgame.numStatics = 0;
 
 	if(( clgame.maxRemapInfos - 1 ) != clgame.maxEntities )
@@ -1690,7 +1685,7 @@ get actual screen info
 */
 int GAME_EXPORT CL_GetScreenInfo( SCREENINFO *pscrinfo )
 {
-	qboolean apply_scale_factor = false; // we don't want floating point inaccuracies
+	qboolean apply_scale_factor = false;
 	float scale_factor = hud_scale.value;
 
 	if( FBitSet( hud_fontscale.flags, FCVAR_CHANGED ))
@@ -1705,12 +1700,7 @@ int GAME_EXPORT CL_GetScreenInfo( SCREENINFO *pscrinfo )
 	clgame.scrInfo.iSize = sizeof( clgame.scrInfo );
 	clgame.scrInfo.iFlags = SCRINFO_SCREENFLASH;
 
-	if( hud_scale.value >= 320.0f && hud_scale.value >= hud_scale_minimal_width.value )
-	{
-		scale_factor = refState.width / hud_scale.value;
-		apply_scale_factor = scale_factor > 1.0f;
-	}
-	else if( scale_factor && scale_factor != 1.0f )
+	if( scale_factor && scale_factor != 1.0f )
 	{
 		float scaled_width = (float)refState.width / scale_factor;
 		if( scaled_width >= hud_scale_minimal_width.value )
@@ -1775,17 +1765,6 @@ static cvar_t *GAME_EXPORT pfnCvar_RegisterClientVariable( const char *szName, c
 	return (cvar_t *)Cvar_Get( szName, szValue, flags|FCVAR_CLIENTDLL, Cvar_BuildAutoDescription( szName, flags|FCVAR_CLIENTDLL ));
 }
 
-static int GAME_EXPORT Cmd_AddClientCommand( const char *cmd_name, xcommand_t function )
-{
-	int flags = CMD_CLIENTDLL;
-
-	// a1ba: try to mitigate outdated client.dll vulnerabilities
-	if( !Q_stricmp( cmd_name, "motd_write" ))
-		flags |= CMD_PRIVILEGED;
-
-	return Cmd_AddCommandEx( cmd_name, function, "client command", flags, __func__ );
-}
-
 /*
 =============
 pfnHookUserMsg
@@ -2085,7 +2064,6 @@ GetWindowCenterX
 static int GAME_EXPORT pfnGetWindowCenterX( void )
 {
 	int x = 0;
-
 #if XASH_WIN32
 	if( m_ignore.value )
 	{
@@ -2095,7 +2073,7 @@ static int GAME_EXPORT pfnGetWindowCenterX( void )
 	}
 #endif
 
-#if XASH_SDL >= 2
+#if XASH_SDL == 2
 	SDL_GetWindowPosition( host.hWnd, &x, NULL );
 #endif
 
@@ -2111,7 +2089,6 @@ GetWindowCenterY
 static int GAME_EXPORT pfnGetWindowCenterY( void )
 {
 	int y = 0;
-
 #if XASH_WIN32
 	if( m_ignore.value )
 	{
@@ -2121,7 +2098,7 @@ static int GAME_EXPORT pfnGetWindowCenterY( void )
 	}
 #endif
 
-#if XASH_SDL >= 2
+#if XASH_SDL == 2
 	SDL_GetWindowPosition( host.hWnd, NULL, &y );
 #endif
 
@@ -2422,8 +2399,9 @@ CL_FindModelIndex
 */
 static int GAME_EXPORT CL_FindModelIndex( const char *m )
 {
-	char filepath[MAX_QPATH];
-	int  i;
+	char		filepath[MAX_QPATH];
+	static float	lasttimewarn;
+	int		i;
 
 	if( !COM_CheckString( m ))
 		return 0;
@@ -2440,6 +2418,13 @@ static int GAME_EXPORT CL_FindModelIndex( const char *m )
 			return i+1;
 	}
 
+	if( lasttimewarn < host.realtime )
+	{
+		// tell user about problem (but don't spam console)
+		Con_DPrintf( S_ERROR "Could not find index for model %s: not precached\n", filepath );
+		lasttimewarn = host.realtime + 1.0f;
+	}
+
 	return 0;
 }
 
@@ -2713,6 +2698,17 @@ static const char *pfnGetGameDirectory( void )
 	return szGetGameDir;
 }
 
+/*
+=============
+Key_LookupBinding
+
+=============
+*/
+static const char *Key_LookupBinding( const char *pBinding )
+{
+	return Key_KeynumToString( Key_GetKey( pBinding ));
+}
+
 /*
 =============
 pfnGetLevelName
@@ -3362,6 +3358,28 @@ DemoApi implementation
 
 =================
 */
+/*
+=================
+Demo_IsRecording
+
+=================
+*/
+static int GAME_EXPORT Demo_IsRecording( void )
+{
+	return cls.demorecording;
+}
+
+/*
+=================
+Demo_IsPlayingback
+
+=================
+*/
+static int GAME_EXPORT Demo_IsPlayingback( void )
+{
+	return cls.demoplayback;
+}
+
 /*
 =================
 Demo_IsTimeDemo
@@ -3373,6 +3391,17 @@ static int GAME_EXPORT Demo_IsTimeDemo( void )
 	return cls.timedemo;
 }
 
+/*
+=================
+Demo_WriteBuffer
+
+=================
+*/
+static void GAME_EXPORT Demo_WriteBuffer( int size, byte *buffer )
+{
+	CL_WriteDemoUserMessage( buffer, size );
+}
+
 /*
 =================
 NetworkApi implementation
@@ -3414,7 +3443,7 @@ static void GAME_EXPORT NetAPI_Status( net_status_t *status )
 	status->latency = (connected) ? cl.frames[cl.parsecountmod].latency : 0.0;
 	status->remote_address = cls.netchan.remote_address;
 	status->packet_loss = packet_loss;
-	NET_GetLocalAddress( &status->local_address, NULL ); // NetAPI doesn't know about IPv6
+	status->local_address = net_local;
 	status->rate = rate.value;
 }
 
@@ -3435,7 +3464,7 @@ static void GAME_EXPORT NetAPI_SendRequest( int context, int request, int flags,
 		return;
 	}
 
-	if( NET_NetadrType( remote_address ) == NA_IPX || NET_NetadrType( remote_address ) == NA_BROADCAST_IPX )
+	if( remote_address->type == NA_IPX || remote_address->type == NA_BROADCAST_IPX )
 		return; // IPX no longer support
 
 	if( request == NETAPI_REQUEST_SERVERLIST )
@@ -3558,6 +3587,28 @@ static int GAME_EXPORT NetAPI_CompareAdr( netadr_t *a, netadr_t *b )
 	return NET_CompareAdr( *a, *b );
 }
 
+/*
+=================
+NetAPI_StringToAdr
+
+=================
+*/
+static int GAME_EXPORT NetAPI_StringToAdr( char *s, netadr_t *a )
+{
+	return NET_StringToAdr( s, a );
+}
+
+/*
+=================
+NetAPI_ValueForKey
+
+=================
+*/
+static const char * GAME_EXPORT NetAPI_ValueForKey( const char *s, const char *key )
+{
+	return Info_ValueForKey( s, key );
+}
+
 /*
 =================
 NetAPI_RemoveKey
@@ -3754,10 +3805,10 @@ static event_api_t gEventApi =
 
 static demo_api_t gDemoApi =
 {
-	(void *)CL_IsRecordDemo,
-	(void *)CL_IsPlaybackDemo,
+	Demo_IsRecording,
+	Demo_IsPlayingback,
 	Demo_IsTimeDemo,
-	CL_WriteDemoUserMessage,
+	Demo_WriteBuffer,
 };
 
 net_api_t gNetApi =
@@ -3769,8 +3820,8 @@ net_api_t gNetApi =
 	NetAPI_CancelAllRequests,
 	NetAPI_AdrToString,
 	NetAPI_CompareAdr,
-	(void *)NET_StringToAdr,
-	Info_ValueForKey,
+	NetAPI_StringToAdr,
+	NetAPI_ValueForKey,
 	NetAPI_RemoveKey,
 	NetAPI_SetValueForKey,
 };
@@ -3956,10 +4007,9 @@ void CL_UnloadProgs( void )
 qboolean CL_LoadProgs( const char *name )
 {
 	static playermove_t		gpMove;
-	CL_EXPORT_FUNCS	GetClientAPI; // single export
-	qboolean valid_single_export = false;
-	qboolean missed_exports = false;
-	int i;
+	const dllfunc_t		*func;
+	CL_EXPORT_FUNCS		GetClientAPI; // single export
+	qboolean			critical_exports = true;
 
 	if( clgame.hInstance ) CL_UnloadProgs();
 
@@ -3970,19 +4020,36 @@ qboolean CL_LoadProgs( const char *name )
 	clgame.mempool = Mem_AllocPool( "Client Edicts Zone" );
 	clgame.entities = NULL;
 
+
 	// a1ba: we need to check if client.dll has direct dependency on SDL2
 	// and if so, disable relative mouse mode
 #if XASH_WIN32 && !XASH_64BIT
-	clgame.client_dll_uses_sdl = COM_CheckLibraryDirectDependency( name, OS_LIB_PREFIX "SDL2." OS_LIB_EXT, false );
-	Con_Printf( S_NOTE "%s uses %s for mouse input\n", name, clgame.client_dll_uses_sdl ? "SDL2" : "Windows API" );
+	if( ( clgame.client_dll_uses_sdl = COM_CheckLibraryDirectDependency( name, OS_LIB_PREFIX "SDL2." OS_LIB_EXT, false ) ) )
+	{
+		Con_Printf( S_NOTE "%s uses SDL2 for mouse input\n", name );
+	}
+	else
+	{
+		Con_Printf( S_NOTE "%s uses Windows API for mouse input\n", name );
+	}
+#else
+	// this doesn't mean other platforms uses SDL2 in any case
+	// it just helps input code to stay platform-independent
+	clgame.client_dll_uses_sdl = true;
 #endif
 
 	// NOTE: important stuff!
-	// vgui must startup BEFORE loading client.dll to avoid get error ERROR_NOACESS during LoadLibrary
+	// vgui must startup BEFORE loading client.dll to avoid get error ERROR_NOACESS
+	// during LoadLibrary
 	if( !GI->internal_vgui_support && VGui_LoadProgs( NULL ))
+	{
 		VGui_Startup( refState.width, refState.height );
+	}
 	else
-		GI->internal_vgui_support = true; // we failed to load vgui_support, but let's probe client.dll for support anyway
+	{
+		// we failed to load vgui_support, but let's probe client.dll for support anyway
+		GI->internal_vgui_support = true;
+	}
 
 	clgame.hInstance = COM_LoadLibrary( name, false, false );
 
@@ -3991,10 +4058,13 @@ qboolean CL_LoadProgs( const char *name )
 
 	// delayed vgui initialization for internal support
 	if( GI->internal_vgui_support && VGui_LoadProgs( clgame.hInstance ))
+	{
 		VGui_Startup( refState.width, refState.height );
+	}
 
 	// clear exports
-	ClearExports( cdll_exports, ARRAYSIZE( cdll_exports ));
+	for( func = cdll_exports; func && func->name; func++ )
+		*func->func = NULL;
 
 	// trying to get single export
 	if(( GetClientAPI = (void *)COM_GetProcAddress( clgame.hInstance, "GetClientAPI" )) != NULL )
@@ -4012,44 +4082,56 @@ qboolean CL_LoadProgs( const char *name )
 		CL_GetSecuredClientAPI( GetClientAPI );
 	}
 
-	if( GetClientAPI != NULL ) // check critical functions again
-		valid_single_export = ValidateExports( cdll_exports, ARRAYSIZE( cdll_exports ));
-
-	for( i = 0; i < ARRAYSIZE( cdll_exports ); i++ )
+	if ( GetClientAPI != NULL )
 	{
-		if( *(cdll_exports[i].func) != NULL )
-			continue; // already gott through 'F' or 'GetClientAPI'
+		// check critical functions again
+		for( func = cdll_exports; func && func->name; func++ )
+		{
+			if( func->func == NULL )
+				break; // BAH critical function was missed
+		}
+
+		// because all the exports are loaded through function 'F"
+		if( !func || !func->name )
+			critical_exports = false;
+	}
+
+	for( func = cdll_exports; func && func->name != NULL; func++ )
+	{
+		if( *func->func != NULL )
+			continue;	// already get through 'F'
 
 		// functions are cleared before all the extensions are evaluated
-		if(( *(cdll_exports[i].func) = (void *)COM_GetProcAddress( clgame.hInstance, cdll_exports[i].name )) == NULL )
+		if(( *func->func = (void *)COM_GetProcAddress( clgame.hInstance, func->name )) == NULL )
 		{
-			Con_Reportf( S_ERROR "%s: failed to get address of %s proc\n", __func__, cdll_exports[i].name );
+			Con_Reportf( "%s: failed to get address of %s proc\n", __func__, func->name );
 
-			// print all not found exports at once, for debug
-			missed_exports = true;
+			if( critical_exports )
+			{
+				COM_FreeLibrary( clgame.hInstance );
+				clgame.hInstance = NULL;
+				return false;
+			}
 		}
 	}
 
-	if( missed_exports )
+	// it may be loaded through 'GetClientAPI' so we don't need to clear them
+	if( critical_exports )
 	{
-		COM_FreeLibrary( clgame.hInstance );
-		clgame.hInstance = NULL;
-		return false;
+		// clear new exports
+		for( func = cdll_new_exports; func && func->name; func++ )
+			*func->func = NULL;
 	}
 
-	// it may be loaded through 'GetClientAPI' so we don't need to clear them
-	if( !valid_single_export )
-		ClearExports( cdll_new_exports, ARRAYSIZE( cdll_new_exports ));
-
-	for( i = 0; i < ARRAYSIZE( cdll_new_exports ); i++ )
+	for( func = cdll_new_exports; func && func->name != NULL; func++ )
 	{
-		if( *(cdll_new_exports[i].func) != NULL )
-			continue; // already gott through 'F' or 'GetClientAPI'
+		if( *func->func != NULL )
+			continue;	// already get through 'F'
 
 		// functions are cleared before all the extensions are evaluated
 		// NOTE: new exports can be missed without stop the engine
-		if(( *(cdll_new_exports[i].func) = (void *)COM_GetProcAddress( clgame.hInstance, cdll_new_exports[i].name )) == NULL )
-			Con_Reportf( S_WARN "%s: failed to get address of %s proc\n", __func__, cdll_new_exports[i].name );
+		if(( *func->func = (void *)COM_GetProcAddress( clgame.hInstance, func->name )) == NULL )
+			Con_Reportf( "%s: failed to get address of %s proc\n", __func__, func->name );
 	}
 
 	if( !clgame.dllFuncs.pfnInitialize( &gEngfuncs, CLDLL_INTERFACE_VERSION ))

engine/client/cl_gameui.c

@@ -694,11 +694,6 @@ static cvar_t *GAME_EXPORT pfnCvar_RegisterGameUIVariable( const char *szName, c
 	return (cvar_t *)Cvar_Get( szName, szValue, flags|FCVAR_GAMEUIDLL, Cvar_BuildAutoDescription( szName, flags|FCVAR_GAMEUIDLL ));
 }
 
-static int GAME_EXPORT Cmd_AddGameUICommand( const char *cmd_name, xcommand_t function )
-{
-	return Cmd_AddCommandEx( cmd_name, function, "gameui command", CMD_GAMEUIDLL, __func__ );
-}
-
 /*
 =============
 pfnClientCmd
@@ -1114,7 +1109,7 @@ static void GAME_EXPORT UI_ShellExecute( const char *path, const char *parms, in
 	Platform_ShellExecute( path, parms );
 
 	if( shouldExit )
-		Sys_Quit( __func__ );
+		Sys_Quit();
 }
 
 /*
@@ -1273,16 +1268,16 @@ static void pfnEnableTextInput( int enable )
 	Key_EnableTextInput( enable, false );
 }
 
-static int pfnGetRenderers( unsigned int num, char *short_name, size_t size1, char *long_name, size_t size2 )
+static int pfnGetRenderers( unsigned int num, char *shortName, size_t size1, char *readableName, size_t size2 )
 {
-	if( num >= ref.num_renderers )
+	if( num >= ref.numRenderers )
 		return 0;
 
-	if( short_name && size1 )
-		Q_strncpy( short_name, ref.short_names[num], size1 );
+	if( shortName && size1 )
+		Q_strncpy( shortName, ref.shortNames[num], size1 );
 
-	if( long_name && size2 )
-		Q_strncpy( long_name, ref.long_names[num], size2 );
+	if( readableName && size2 )
+		Q_strncpy( readableName, ref.readableNames[num], size2 );
 
 	return 1;
 }

engine/client/cl_main.c

@@ -68,15 +68,14 @@ CVAR_DEFINE_AUTO( hud_scale_minimal_width, "640", FCVAR_ARCHIVE|FCVAR_LATCH, "if
 CVAR_DEFINE_AUTO( cl_solid_players, "1", 0, "Make all players not solid (can't traceline them)" );
 CVAR_DEFINE_AUTO( cl_updaterate, "20", FCVAR_USERINFO|FCVAR_ARCHIVE, "refresh rate of server messages" );
 CVAR_DEFINE_AUTO( cl_showevents, "0", FCVAR_ARCHIVE, "show events playback" );
-CVAR_DEFINE_AUTO( cl_cmdrate, "30", FCVAR_ARCHIVE, "Max number of command packets sent to server per second" );
+CVAR_DEFINE_AUTO( cl_cmdrate, "60", FCVAR_ARCHIVE, "Max number of command packets sent to server per second" );
 CVAR_DEFINE( cl_interp, "ex_interp", "0.1", FCVAR_ARCHIVE | FCVAR_FILTERABLE, "Interpolate object positions starting this many seconds in past" );
 CVAR_DEFINE_AUTO( cl_nointerp, "0", 0, "disable interpolation of entities and players" );
 static CVAR_DEFINE_AUTO( cl_dlmax, "0", FCVAR_USERINFO|FCVAR_ARCHIVE, "max allowed outcoming fragment size" );
-static CVAR_DEFINE_AUTO( cl_upmax, "508", FCVAR_ARCHIVE, "max allowed incoming fragment size" );
+static CVAR_DEFINE_AUTO( cl_upmax, "1200", FCVAR_ARCHIVE, "max allowed incoming fragment size" );
 
 CVAR_DEFINE_AUTO( cl_lw, "1", FCVAR_ARCHIVE|FCVAR_USERINFO, "enable client weapon predicting" );
 CVAR_DEFINE_AUTO( cl_charset, "utf-8", FCVAR_ARCHIVE, "1-byte charset to use (iconv style)" );
-CVAR_DEFINE_AUTO( cl_trace_consistency, "0", FCVAR_ARCHIVE, "enable consistency info tracing (good for developers)" );
 CVAR_DEFINE_AUTO( cl_trace_stufftext, "0", FCVAR_ARCHIVE, "enable stufftext (server-to-client console commands) tracing (good for developers)" );
 CVAR_DEFINE_AUTO( cl_trace_messages, "0", FCVAR_ARCHIVE|FCVAR_CHEAT, "enable message names tracing (good for developers)" );
 CVAR_DEFINE_AUTO( cl_trace_events, "0", FCVAR_ARCHIVE|FCVAR_CHEAT, "enable events tracing (good for developers)" );
@@ -94,10 +93,11 @@ static CVAR_DEFINE_AUTO( name, username, FCVAR_USERINFO|FCVAR_ARCHIVE|FCVAR_PRIN
 static CVAR_DEFINE_AUTO( model, "", FCVAR_USERINFO|FCVAR_ARCHIVE|FCVAR_FILTERABLE, "player model ('player' is a singleplayer model)" );
 static CVAR_DEFINE_AUTO( topcolor, "0", FCVAR_USERINFO|FCVAR_ARCHIVE|FCVAR_FILTERABLE, "player top color" );
 static CVAR_DEFINE_AUTO( bottomcolor, "0", FCVAR_USERINFO|FCVAR_ARCHIVE|FCVAR_FILTERABLE, "player bottom color" );
-CVAR_DEFINE_AUTO( rate, "25000", FCVAR_USERINFO|FCVAR_ARCHIVE|FCVAR_FILTERABLE, "player network rate" );
+CVAR_DEFINE_AUTO( rate, "3500", FCVAR_USERINFO|FCVAR_ARCHIVE|FCVAR_FILTERABLE, "player network rate" );
 
 static CVAR_DEFINE_AUTO( cl_ticket_generator, "revemu2013", FCVAR_ARCHIVE, "you wouldn't steal a car" );
 
+
 client_t		cl;
 client_static_t	cls;
 clgame_static_t	clgame;
@@ -147,6 +147,11 @@ qboolean CL_IsRecordDemo( void )
 	return cls.demorecording;
 }
 
+qboolean CL_IsTimeDemo( void )
+{
+	return cls.timedemo;
+}
+
 qboolean CL_DisableVisibility( void )
 {
 	return cls.envshot_disable_vis;
@@ -593,7 +598,7 @@ CL_CreateCmd
 */
 static void CL_CreateCmd( void )
 {
-	usercmd_t nullcmd = { 0 }, *cmd;
+	usercmd_t nullcmd, *cmd;
 	runcmd_t  *pcmd;
 	qboolean  active;
 	double    accurate_ms;
@@ -645,6 +650,7 @@ static void CL_CreateCmd( void )
 	}
 	else
 	{
+		memset( &nullcmd, 0, sizeof( nullcmd ));
 		cmd = &nullcmd;
 	}
 
@@ -673,7 +679,7 @@ static void CL_CreateCmd( void )
 	}
 
 	// demo always have commands so don't overwrite them
-	if( !cls.demoplayback ) cl.cmd = pcmd->cmd;
+	if( !cls.demoplayback ) cl.cmd = &pcmd->cmd;
 
 	// predict all unacknowledged movements
 	CL_PredictMovement( false );
@@ -717,20 +723,11 @@ static void CL_WritePacket( void )
 	int numbackup, maxbackup, maxcmds;
 	const connprotocol_t proto = cls.legacymode;
 
-	// FIXME: on Xash protocol we don't send move commands until ca_active
-	// to prevent outgoing_command outrun incoming_acknowledged
-	// which is fatal for some buggy mods like TFC
-	//
-	// ... but GoldSrc don't have (real) ca_validate state, so we consider
-	// ca_validate the same as ca_active, otherwise we don't pass validation
-	// of server-side mods like ReAuthCheck
-	const connstate_t min_state = proto == PROTO_GOLDSRC ? ca_validate : ca_active;
-
 	// don't send anything if playing back a demo
 	if( cls.demoplayback || cls.state < ca_connected || cls.state == ca_cinematic )
 		return;
 
-	if( cls.state < min_state )
+	if( cls.state <= ca_connected )
 	{
 		Netchan_TransmitBits( &cls.netchan, 0, "" );
 		return;
@@ -828,7 +825,7 @@ static void CL_WritePacket( void )
 			buf.pData[key] = CRC32_BlockSequence( &buf.pData[key + 1], size, cls.netchan.outgoing_sequence );
 			COM_Munge( &buf.pData[key + 1], Q_min( size, 255 ), cls.netchan.outgoing_sequence );
 		}
-		else if( !Host_IsLocalClient( ))
+		else
 		{
 			int size = MSG_GetRealBytesWritten( &buf ) - key - 1;
 			buf.pData[key] = CRC32_BlockSequence( &buf.pData[key + 1], size, cls.netchan.outgoing_sequence );
@@ -968,7 +965,7 @@ CL_Quit_f
 void CL_Quit_f( void )
 {
 	CL_Disconnect();
-	Sys_Quit( "command" );
+	Sys_Quit();
 }
 
 /*
@@ -1008,7 +1005,7 @@ static void CL_WriteSteamTicket( sizebuf_t *send )
 	const char *s;
 	uint32_t crc;
 	char buf[768] = { 0 }; // setti and steamemu return 768
-	int i = sizeof( buf );
+	size_t i = sizeof( buf );
 
 	if( !Q_strcmp( cl_ticket_generator.string, "null" ))
 	{
@@ -1027,7 +1024,24 @@ static void CL_WriteSteamTicket( sizebuf_t *send )
 	CRC32_Init( &crc );
 	CRC32_ProcessBuffer( &crc, s, Q_strlen( s ));
 	crc = CRC32_Final( crc );
-	i = GenerateRevEmu2013( buf, s, crc );
+
+	if( !Q_stricmp( cl_ticket_generator.string, "revemu2013" ))
+		i = GenerateRevEmu2013( buf, crc );
+	else if( !Q_stricmp( cl_ticket_generator.string, "sc2009" ))
+		i = GenerateSC2009( buf, crc );
+	else if( !Q_stricmp( cl_ticket_generator.string, "oldrevemu" ))
+		i = GenerateOldRevEmu( buf, crc );
+	else if( !Q_stricmp( cl_ticket_generator.string, "steamemu" ))
+		i = GenerateSteamEmu( buf, crc );
+	else if( !Q_stricmp( cl_ticket_generator.string, "revemu" ))
+		i = GenerateRevEmu( buf, crc );
+	else if( !Q_stricmp( cl_ticket_generator.string, "setti" ))
+		i = GenerateSetti( buf );
+	else if( !Q_stricmp( cl_ticket_generator.string, "avsmp" ))
+		i = GenerateAVSMP( buf, crc, true );
+	else
+		Con_Printf( "%s: unknown generator %s, supported are: null, revemu2003, sc2009, oldrevemu, steamemu, revemu, setti, avsmp\n", __func__, cl_ticket_generator.string );
+
 	MSG_WriteBytes( send, buf, i );
 }
 
@@ -1045,7 +1059,6 @@ static void CL_SendConnectPacket( connprotocol_t proto, int challenge )
 	const char *key = ID_GetMD5();
 	netadr_t adr = { 0 };
 	int input_devices;
-	netadrtype_t adrtype;
 
 	protinfo[0] = 0;
 
@@ -1056,16 +1069,14 @@ static void CL_SendConnectPacket( connprotocol_t proto, int challenge )
 		return;
 	}
 
-	adrtype = NET_NetadrType( &adr );
-
 	if( adr.port == 0 ) adr.port = MSG_BigShort( PORT_SERVER );
 
 	input_devices = IN_CollectInputDevices();
-	IN_LockInputDevices( adrtype != NA_LOOPBACK ? true : false );
+	IN_LockInputDevices( adr.type != NA_LOOPBACK ? true : false );
 
 	// GoldSrc doesn't need sv_cheats set to 0, it's handled by svc_goldsrc_sendextrainfo
 	// it also doesn't need useragent string
-	if( adrtype != NA_LOOPBACK && proto != PROTO_GOLDSRC )
+	if( adr.type != NA_LOOPBACK && proto != PROTO_GOLDSRC )
 	{
 		Cvar_SetCheatState();
 		Cvar_FullSet( "sv_cheats", "0", FCVAR_READ_ONLY | FCVAR_SERVER );
@@ -1165,11 +1176,7 @@ Returns bandwidth test fragment size
 */
 static int CL_GetTestFragmentSize( void )
 {
-	// const int fragmentSizes[CL_TEST_RETRIES] = { 64000, 32000, 10666, 5200, 1400 };
-
-	// it turns out, even if we pass the bandwidth test, it doesn't mean we can use such large fragments
-	// as a temporary solution, use smaller fragment sizes
-	const int fragmentSizes[CL_TEST_RETRIES] = { 1400, 1200, 1000, 800, 508 };
+	const int fragmentSizes[CL_TEST_RETRIES] = { 64000, 32000, 10666, 5200, 1400 };
 	if( cls.connect_retry >= 0 && cls.connect_retry < CL_TEST_RETRIES )
 		return bound( FRAGMENT_MIN_SIZE, fragmentSizes[cls.connect_retry], FRAGMENT_MAX_SIZE );
 	else
@@ -1207,7 +1214,7 @@ static void CL_CheckForResend( void )
 		cls.signon = 0;
 		cls.state = ca_connecting;
 		Q_strncpy( cls.servername, "localhost", sizeof( cls.servername ));
-		NET_NetadrSetType( &cls.serveradr, NA_LOOPBACK );
+		cls.serveradr.type = NA_LOOPBACK;
 		cls.legacymode = PROTO_CURRENT;
 
 		// we don't need a challenge on the localhost
@@ -1394,8 +1401,7 @@ static void CL_Connect_f( void )
 	Q_strncpy( server, Cmd_Argv( 1 ), sizeof( server ));
 
 	// if running a local server, kill it and reissue
-	if( SV_Active( ))
-		SV_Shutdown( "Server was killed due to connection to remote server\n" );
+	if( SV_Active( )) Host_ShutdownServer();
 	NET_Config( true, !cl_nat.value ); // allow remote
 
 	Con_Printf( "server %s\n", server );
@@ -1543,8 +1549,8 @@ static void CL_SendDisconnectMessage( connprotocol_t proto )
 		MSG_WriteString( &buf, "dropclient\n" );
 	else MSG_WriteString( &buf, "disconnect" );
 
-	if( NET_NetadrType( &cls.netchan.remote_address ) == NA_UNDEFINED )
-		NET_NetadrSetType( &cls.netchan.remote_address, NA_LOOPBACK );
+	if( !cls.netchan.remote_address.type )
+		cls.netchan.remote_address.type = NA_LOOPBACK;
 
 	// make sure message will be delivered
 	Netchan_TransmitBits( &cls.netchan, MSG_GetNumBitsWritten( &buf ), MSG_GetData( &buf ));
@@ -1587,9 +1593,6 @@ void CL_SetupNetchanForProtocol( connprotocol_t proto )
 		}
 		break;
 	default:
-		if( !Host_IsLocalClient( ))
-			SetBits( flags, NETCHAN_USE_LZSS );
-
 		cls.extensions = Q_atoi( Info_ValueForKey( Cmd_Argv( 1 ), "ext" ));
 
 		if( FBitSet( cls.extensions, NET_EXT_SPLITSIZE ))
@@ -1713,17 +1716,19 @@ CL_LocalServers_f
 */
 static void CL_LocalServers_f( void )
 {
-	netadr_t adr = { 0 };
+	netadr_t	adr;
+
+	memset( &adr, 0, sizeof( adr ));
 
 	Con_Printf( "Scanning for servers on the local network area...\n" );
 	NET_Config( true, true ); // allow remote
 
 	// send a broadcast packet
-	NET_NetadrSetType( &adr, NA_BROADCAST );
+	adr.type = NA_BROADCAST;
 	adr.port = MSG_BigShort( PORT_SERVER );
 	Netchan_OutOfBandPrint( NS_CLIENT, adr, A2A_INFO" %i", PROTOCOL_VERSION );
 
-	NET_NetadrSetType( &adr, NA_MULTICAST_IP6 );
+	adr.type = NA_MULTICAST_IP6;
 	Netchan_OutOfBandPrint( NS_CLIENT, adr, A2A_INFO" %i", PROTOCOL_VERSION );
 }
 
@@ -1755,8 +1760,8 @@ static size_t NONNULL CL_BuildMasterServerScanRequest( char *buf, size_t size, u
 	// let master know about client version
 	Info_SetValueForKey( info, "clver", XASH_VERSION, remaining );
 	Info_SetValueForKey( info, "nat", nat ? "1" : "0", remaining );
-	Info_SetValueForKey( info, "commit", g_buildcommit, remaining );
-	Info_SetValueForKey( info, "branch", g_buildbranch, remaining );
+	Info_SetValueForKey( info, "commit", Q_buildcommit(), remaining );
+	Info_SetValueForKey( info, "branch", Q_buildbranch(), remaining );
 	Info_SetValueForKey( info, "os", Q_buildos(), remaining );
 	Info_SetValueForKey( info, "arch", Q_buildarch(), remaining );
 
@@ -2467,18 +2472,18 @@ static void CL_ServerList( netadr_t from, sizebuf_t *msg )
 	while( MSG_GetNumBitsLeft( msg ) > 8 )
 	{
 		uint8_t addr[16];
-		netadr_t servadr = { 0 };
+		netadr_t	servadr;
 
-		if( NET_NetadrType( &from ) == NA_IP6 ) // IPv6 master server only sends IPv6 addresses
+		if( from.type6 == NA_IP6 ) // IPv6 master server only sends IPv6 addresses
 		{
 			MSG_ReadBytes( msg, addr, sizeof( addr ));
 			NET_IP6BytesToNetadr( &servadr, addr );
-			NET_NetadrSetType( &servadr, NA_IP6 );
+			servadr.type6 = NA_IP6;
 		}
 		else
 		{
 			MSG_ReadBytes( msg, servadr.ip, sizeof( servadr.ip ));	// 4 bytes for IP
-			NET_NetadrSetType( &servadr, NA_IP );
+			servadr.type = NA_IP;
 		}
 		servadr.port = MSG_ReadShort( msg );			// 2 bytes for Port
 
@@ -3126,9 +3131,6 @@ static qboolean CL_ShouldRescanFilesystem( void )
 		}
 	}
 
-	if( FBitSet( fs_mount_lv.flags|fs_mount_hd.flags|fs_mount_addon.flags|fs_mount_l10n.flags|ui_language.flags, FCVAR_CHANGED ))
-		retval = true;
-
 	return retval;
 }
 
@@ -3138,7 +3140,7 @@ qboolean CL_PrecacheResources( void )
 
 	// if we downloaded new WAD files or any other archives they must be added to searchpath
 	if( CL_ShouldRescanFilesystem( ))
-		FS_Rescan_f();
+		g_fsapi.Rescan();
 
 	// NOTE: world need to be loaded as first model
 	for( pRes = cl.resourcesonhand.pNext; pRes && pRes != &cl.resourcesonhand; pRes = pRes->pNext )
@@ -3324,22 +3326,6 @@ static void CL_Escape_f( void )
 	else UI_SetActiveMenu( true );
 }
 
-static void CL_ListMessages_f( void )
-{
-	int i;
-
-	Con_Printf( "num size name\n" );
-	for( i = 0; i < MAX_USER_MESSAGES; i++ )
-	{
-		if( !COM_CheckStringEmpty( clgame.msg[i].name ))
-			break;
-
-		Con_Printf( "%3d\t%3d\t%s\n", clgame.msg[i].number, clgame.msg[i].size, clgame.msg[i].name );
-	}
-
-	Con_Printf( "Total %i messages\n", i );
-}
-
 /*
 =================
 CL_InitLocal
@@ -3384,7 +3370,6 @@ static void CL_InitLocal( void )
 
 	Cvar_RegisterVariable( &rcon_address );
 
-	Cvar_RegisterVariable( &cl_trace_consistency );
 	Cvar_RegisterVariable( &cl_trace_stufftext );
 	Cvar_RegisterVariable( &cl_trace_messages );
 	Cvar_RegisterVariable( &cl_trace_events );
@@ -3479,8 +3464,6 @@ static void CL_InitLocal( void )
 	Cmd_AddCommand ("fullserverinfo", CL_FullServerinfo_f, "sent by server when serverinfo changes" );
 	Cmd_AddCommand ("upload", CL_BeginUpload_f, "uploading file to the server" );
 
-	Cmd_AddRestrictedCommand( "replaybufferdat", CL_ReplayBufferDat_f, "development and debugging tool" );
-
 	Cmd_AddRestrictedCommand ("quit", CL_Quit_f, "quit from game" );
 	Cmd_AddRestrictedCommand ("exit", CL_Quit_f, "quit from game" );
 
@@ -3500,7 +3483,6 @@ static void CL_InitLocal( void )
 	Cmd_AddCommand( "richpresence_gamemode", Cmd_Null_f, "compatibility command, does nothing" );
 	Cmd_AddCommand( "richpresence_update", Cmd_Null_f, "compatibility command, does nothing" );
 
-	Cmd_AddCommand( "cl_list_messages", CL_ListMessages_f, "list registered user messages" );
 }
 
 //============================================================================
@@ -3658,8 +3640,6 @@ void CL_Init( void )
 	if( !CL_LoadProgs( libpath ))
 		Host_Error( "can't initialize %s: %s\n", libpath, COM_GetLibraryError( ));
 
-	ID_Init();
-
 	cls.build_num = 0;
 	cls.initialized = true;
 	cl.maxclients = 1; // allow to drawing player in menu
@@ -3677,7 +3657,7 @@ void CL_Shutdown( void )
 {
 	Con_Printf( "%s()\n", __func__ );
 
-	if( host.status != HOST_CRASHED && cls.initialized )
+	if( !host.crashed && cls.initialized )
 	{
 		Host_WriteOpenGLConfig ();
 		Host_WriteVideoConfig ();

engine/client/cl_mobile.c

@@ -92,11 +92,6 @@ static char *pfnParseFileSafe( char *data, char *buf, const int size, unsigned i
 	return COM_ParseFileSafe( data, buf, size, flags, len, NULL );
 }
 
-static void GAME_EXPORT pfnSetCustomClientID( const char *id )
-{
-	// deprecated
-}
-
 static const mobile_engfuncs_t gMobileEngfuncs =
 {
 	MOBILITY_API_VERSION,
@@ -111,7 +106,7 @@ static const mobile_engfuncs_t gMobileEngfuncs =
 	pfnDrawScaledCharacter,
 	Sys_Warn,
 	Sys_GetNativeObject,
-	pfnSetCustomClientID,
+	ID_SetCustomClientID,
 	pfnParseFileSafe
 };
 

engine/client/cl_parse.c

@@ -311,13 +311,10 @@ static client entity
 static void CL_ParseStaticEntity( sizebuf_t *msg )
 {
 	int		i, newnum;
-	const entity_state_t from = { 0 };
-	entity_state_t to;
+	entity_state_t	from, to;
 	cl_entity_t	*ent;
 
-	if( !clgame.static_entities )
-		clgame.static_entities = Mem_Calloc( clgame.mempool, sizeof( cl_entity_t ) * MAX_STATIC_ENTITIES );
-
+	memset( &from, 0, sizeof( from ));
 	newnum = MSG_ReadUBitLong( msg, MAX_ENTITY_BITS );
 	MSG_ReadDeltaEntity( msg, &from, &to, 0, DELTA_STATIC, cl.mtime[0] );
 
@@ -1325,11 +1322,11 @@ void CL_ParseLightStyle( sizebuf_t *msg, connprotocol_t proto )
 {
 	int		style;
 	const char	*s;
-	float		f = cl.mtime[0];
+	float		f = 0.0f;
 
 	style = MSG_ReadByte( msg );
 	s = MSG_ReadString( msg );
-	if( proto != PROTO_GOLDSRC && proto != PROTO_QUAKE )
+	if( proto != PROTO_GOLDSRC )
 		f = MSG_ReadFloat( msg );
 
 	CL_SetLightstyle( style, s, f );
@@ -1427,31 +1424,37 @@ register new user message or update existing
 void CL_RegisterUserMessage( sizebuf_t *msg, connprotocol_t proto )
 {
 	char *pszName;
-	char szName[17];
-	int size;
-	int svc_num = MSG_ReadByte( msg );
+	int	svc_num, size, bits;
+
+	svc_num = MSG_ReadByte( msg );
 
 	if( proto == PROTO_LEGACY || proto == PROTO_GOLDSRC )
 	{
 		size = MSG_ReadByte( msg );
-		if( size == UINT8_MAX )
-			size = -1;
+		bits = 8;
 	}
 	else
 	{
 		size = MSG_ReadWord( msg );
-		if( size == UINT16_MAX )
-			size = -1;
+		bits = 16;
 	}
 
 	if( proto == PROTO_GOLDSRC )
 	{
+		static char szName[17];
+
 		MSG_ReadBytes( msg, szName, sizeof( szName ) - 1 );
 		szName[16] = 0;
+
 		pszName = szName;
 	}
 	else pszName = MSG_ReadString( msg );
 
+	// important stuff
+	if( size == ( BIT( bits ) - 1 ) )
+		size = -1;
+	svc_num = bound( 0, svc_num, 255 );
+
 	CL_LinkUserMessage( pszName, svc_num, size );
 }
 
@@ -1590,23 +1593,17 @@ collect pings and packet lossage from clients
 */
 void CL_UpdateUserPings( sizebuf_t *msg )
 {
-	// a1ba: there was a MAX_PLAYERS check but it doesn't make sense
-	// because pings message always ends by null bit
-	while( 1 )
-	{
-		int slot;
-		player_info_t *player;
+	int		i, slot;
+	player_info_t	*player;
 
-		if( !MSG_ReadOneBit( msg ))
-			break; // end of message
+	for( i = 0; i < MAX_CLIENTS; i++ )
+	{
+		if( !MSG_ReadOneBit( msg )) break; // end of message
 
 		slot = MSG_ReadUBitLong( msg, MAX_CLIENT_BITS );
 
-		if( unlikely( slot >= MAX_CLIENTS ))
-		{
+		if( slot >= MAX_CLIENTS )
 			Host_Error( "%s: svc_pings > MAX_CLIENTS\n", __func__ );
-			return;
-		}
 
 		player = &cl.players[slot];
 		player->ping = MSG_ReadUBitLong( msg, 12 );
@@ -1614,23 +1611,6 @@ void CL_UpdateUserPings( sizebuf_t *msg )
 	}
 }
 
-static const char *CL_CheckTypeToString( int check_type )
-{
-	// renamed so they have same width and look better in console output
-	switch( check_type )
-	{
-	case force_exactfile:
-		return "exactfile";
-	case force_model_samebounds:
-		return "samebounds";
-	case force_model_specifybounds:
-		return "specbounds";
-	case force_model_specifybounds_if_avail:
-		return "specbounds2";
-	}
-	return "unknown";
-}
-
 static void CL_SendConsistencyInfo( sizebuf_t *msg, connprotocol_t proto )
 {
 	qboolean		user_changed_diskfile;
@@ -1896,9 +1876,6 @@ static void CL_ParseConsistencyInfo( sizebuf_t *msg, connprotocol_t proto )
 		return;
 	}
 
-	if( cl_trace_consistency.value )
-		Con_Printf( "Server wants consistency of the following resources:\n" );
-
 	skip_crc_change = NULL;
 	lastcheck = 0;
 
@@ -1930,7 +1907,7 @@ static void CL_ParseConsistencyInfo( sizebuf_t *msg, connprotocol_t proto )
 		pc = &cl.consistency_list[cl.num_consistency];
 		cl.num_consistency++;
 
-		memset( pc, 0, sizeof( *pc ));
+		memset( pc, 0, sizeof( consistency_t ));
 		pc->filename = pResource->szFileName;
 		pc->issound = (pResource->type == t_sound);
 		pc->orig_index = delta;
@@ -1943,9 +1920,6 @@ static void CL_ParseConsistencyInfo( sizebuf_t *msg, connprotocol_t proto )
 			pc->check_type = pResource->rguc_reserved[0];
 		}
 
-		if( cl_trace_consistency.value )
-			Con_Printf( "%s\t%s\t%s\n", COM_ResourceTypeFromIndex( pResource->type ), CL_CheckTypeToString( pc->check_type ), pc->filename );
-
 		skip_crc_change = pResource;
 		lastcheck = delta;
 	}

engine/client/cl_parse_48.c

@@ -33,12 +33,10 @@ static client entity
 static void CL_LegacyParseStaticEntity( sizebuf_t *msg )
 {
 	int		i;
-	entity_state_t state = { 0 };
+	entity_state_t	state;
 	cl_entity_t	*ent;
 
-	if( !clgame.static_entities )
-		clgame.static_entities = Mem_Calloc( clgame.mempool, sizeof( cl_entity_t ) * MAX_STATIC_ENTITIES );
-
+	memset( &state, 0, sizeof( state ));
 	state.modelindex = MSG_ReadShort( msg );
 	state.sequence = MSG_ReadByte( msg );
 	state.frame = MSG_ReadByte( msg );

engine/client/cl_parse_gs.c

@@ -83,10 +83,7 @@ static void CL_ParseNewMovevars( sizebuf_t *msg )
 		R_SetupSky( clgame.movevars.skyName );
 
 	clgame.oldmovevars = clgame.movevars;
-
-	// FIXME: set world wave height when entities will be allocated
-	if( clgame.entities )
-		clgame.entities->curstate.scale = clgame.movevars.waveHeight;
+	clgame.entities->curstate.scale = clgame.movevars.waveHeight;
 
 	// keep features an actual!
 	clgame.oldmovevars.features = clgame.movevars.features = host.features;
@@ -94,11 +91,11 @@ static void CL_ParseNewMovevars( sizebuf_t *msg )
 
 typedef struct delta_header_t
 {
-	qboolean remove;
-	qboolean custom;
-	qboolean instanced;
-	uint16_t instanced_baseline_index;
-	uint16_t offset;
+	qboolean remove : 1;
+	qboolean custom : 1;
+	qboolean instanced : 1;
+	uint instanced_baseline_index : 6;
+	uint offset : 6;
 } delta_header_t;
 
 static int CL_ParseDeltaHeader( sizebuf_t *msg, qboolean delta, int oldnum, struct delta_header_t *hdr )
@@ -163,47 +160,33 @@ static int CL_GetEntityDelta( const struct delta_header_t *hdr, int entnum )
 	return DT_ENTITY_STATE_T;
 }
 
-static int CL_FlushEntityPacketGS( frame_t *frame, sizebuf_t *msg )
+static void CL_FlushEntityPacketGS( frame_t *frame, sizebuf_t *msg )
 {
-	int playerbytes = 0, numbase = 0;
-
 	frame->valid = false;
 	cl.validsequence = 0; // can't render a frame
 
 	// read it all but ignore it
 	while( 1 )
 	{
-		int newnum, bufstart;
+		int num = 0;
 		entity_state_t from = { 0 }, to;
 		delta_header_t hdr;
-		qboolean player;
 
 		if( MSG_ReadWord( msg ) != 0 )
 		{
 			MSG_SeekToBit( msg, -16, SEEK_CUR );
-			numbase = newnum = CL_ParseDeltaHeader( msg, true, numbase, &hdr );
+			num = CL_ParseDeltaHeader( msg, false, num, &hdr );
 		}
 		else break;
 
 		if( MSG_CheckOverflow( msg ))
 			Host_Error( "%s: overflow\n", __func__ );
 
-		player = CL_IsPlayerIndex( newnum );
-		bufstart = MSG_GetNumBytesRead( msg );
-
 		if( hdr.remove )
 			continue;
 
-		Delta_ReadGSFields( msg, CL_GetEntityDelta( &hdr, newnum ), &from, &to, cl.mtime[0] );
-
-		if( player )
-			playerbytes += MSG_GetNumBytesRead( msg ) - bufstart;
+		Delta_ReadGSFields( msg, CL_GetEntityDelta( &hdr, num ), &from, &to, cl.mtime[0] );
 	}
-
-	if( MSG_CheckOverflow( msg ))
-		Host_Error( "%s: overflow\n", __func__ );
-
-	return playerbytes;
 }
 
 static void CL_DeltaEntityGS( const delta_header_t *hdr, sizebuf_t *msg, frame_t *frame, int newnum, const entity_state_t *from )
@@ -220,7 +203,7 @@ static void CL_DeltaEntityGS( const delta_header_t *hdr, sizebuf_t *msg, frame_t
 	if(( newnum < 0 ) || ( newnum >= clgame.maxEntities ))
 	{
 		Con_DPrintf( S_ERROR "CL_DeltaEntity: invalid newnum: %d\n", newnum );
-		Host_Error( "%s: bad delta entity number: %i\n", __func__, newnum );
+		Host_Error( "%s: bad delta entity number: %i", __func__, newnum );
 		return;
 	}
 
@@ -284,7 +267,7 @@ static void CL_CopyPacketEntity( frame_t *frame, int num, const entity_state_t *
 static int CL_ParsePacketEntitiesGS( sizebuf_t *msg, qboolean delta )
 {
 	frame_t *frame, *oldframe;
-	int oldindex, oldnum, numbase = 0;
+	int oldindex, newnum, oldnum, numbase = 0;
 	entity_state_t *oldent;
 	int count;
 	int playerbytes = 0;
@@ -331,7 +314,7 @@ static int CL_ParsePacketEntitiesGS( sizebuf_t *msg, qboolean delta )
 	// read it all but ignore it
 	while( 1 )
 	{
-		int bufstart, newnum;
+		int bufstart;
 		qboolean player;
 		delta_header_t hdr;
 		int val = MSG_ReadWord( msg );
@@ -551,7 +534,7 @@ void CL_ParseGoldSrcServerMessage( sizebuf_t *msg )
 	{
 		if( MSG_CheckOverflow( msg ))
 		{
-			Host_Error( "%s: overflow!\n", __func__ );
+			Host_Error( "CL_ParseServerMessage: overflow!\n" );
 			return;
 		}
 
@@ -632,7 +615,7 @@ void CL_ParseGoldSrcServerMessage( sizebuf_t *msg )
 		case svc_setangle:
 			CL_ParseSetAngle( msg );
 			break;
-		case svc_serverdata:
+		case svc_goldsrc_serverinfo:
 			Cbuf_Execute(); // make sure any stuffed commands are done
 			CL_ParseServerData( msg, PROTO_GOLDSRC );
 			break;
@@ -642,7 +625,7 @@ void CL_ParseGoldSrcServerMessage( sizebuf_t *msg )
 		case svc_updateuserinfo:
 			CL_UpdateUserinfo( msg, PROTO_GOLDSRC );
 			break;
-		case svc_deltatable:
+		case svc_goldsrc_deltadescription:
 			Delta_ParseTableField_GS( msg );
 			break;
 		case svc_clientdata:
@@ -704,7 +687,7 @@ void CL_ParseGoldSrcServerMessage( sizebuf_t *msg )
 		case svc_addangle:
 			CL_ParseAddAngle( msg );
 			break;
-		case svc_usermessage:
+		case svc_goldsrc_newusermsg:
 			CL_RegisterUserMessage( msg, PROTO_GOLDSRC );
 			break;
 		case svc_packetentities:
@@ -726,7 +709,7 @@ void CL_ParseGoldSrcServerMessage( sizebuf_t *msg )
 			CL_ParseResourceList( msg, PROTO_GOLDSRC );
 			MSG_EndBitWriting( msg );
 			break;
-		case svc_deltamovevars:
+		case svc_goldsrc_newmovevars:
 			CL_ParseNewMovevars( msg );
 			break;
 		case svc_resourcerequest:
@@ -766,10 +749,10 @@ void CL_ParseGoldSrcServerMessage( sizebuf_t *msg )
 			Con_Reportf( S_ERROR "%s: svc_goldsrc_timescale: implement me!\n", __func__ );
 			MSG_ReadFloat( msg );
 			break;
-		case svc_querycvarvalue:
+		case svc_goldsrc_sendcvarvalue:
 			CL_ParseCvarValue( msg, false, PROTO_GOLDSRC );
 			break;
-		case svc_querycvarvalue2:
+		case svc_goldsrc_sendcvarvalue2:
 			CL_ParseCvarValue( msg, true, PROTO_GOLDSRC );
 			break;
 		case svc_exec:

engine/client/cl_pmove.c

@@ -973,7 +973,7 @@ void CL_MoveSpectatorCamera( void )
 
 	CL_SetUpPlayerPrediction( false, true );
 	CL_SetSolidPlayers( cl.playernum );
-	CL_RunUsercmd( &cls.spectator_state, &cls.spectator_state, &cl.cmd, true, &time, (uint)( time * 100.0 ));
+	CL_RunUsercmd( &cls.spectator_state, &cls.spectator_state, cl.cmd, true, &time, (uint)( time * 100.0 ));
 
 	VectorCopy( cls.spectator_state.client.velocity, cl.simvel );
 	VectorCopy( cls.spectator_state.client.origin, cl.simorg );

engine/client/cl_qparse.c

@@ -628,12 +628,11 @@ CL_ParseStaticEntity
 */
 static void CL_ParseQuakeStaticEntity( sizebuf_t *msg )
 {
-	entity_state_t state = { 0 };
+	entity_state_t	state;
 	cl_entity_t	*ent;
 	int		i;
 
-	if( !clgame.static_entities )
-		clgame.static_entities = Mem_Calloc( clgame.mempool, sizeof( cl_entity_t ) * MAX_STATIC_ENTITIES );
+	memset( &state, 0, sizeof( state ));
 
 	state.modelindex = MSG_ReadByte( msg );
 	state.frame = MSG_ReadByte( msg );
@@ -970,7 +969,9 @@ void CL_ParseQuakeMessage( sizebuf_t *msg )
 			CL_ParseQuakeServerInfo( msg );
 			break;
 		case svc_lightstyle:
-			CL_ParseLightStyle( msg, PROTO_QUAKE );
+			param1 = MSG_ReadByte( msg );
+			str = MSG_ReadString( msg );
+			CL_SetLightstyle( param1, str, cl.mtime[0] );
 			break;
 		case svc_updatename:
 			param1 = MSG_ReadByte( msg );

engine/client/cl_render.c

@@ -138,7 +138,10 @@ intptr_t CL_RenderGetParm( const int parm, const int arg, const qboolean checkRe
 	switch( parm )
 	{
 	case PARM_BSP2_SUPPORTED:
+#ifdef SUPPORT_BSP2_FORMAT
 		return 1;
+#endif
+		return 0;
 	case PARAM_GAMEPAUSED:
 		return cl.paused;
 	case PARM_CLIENT_INGAME:
@@ -233,11 +236,6 @@ static intptr_t pfnRenderGetParm( int parm, int arg )
 	return CL_RenderGetParm( parm, arg, true );
 }
 
-static void pfnAVI_StreamSound( void *avi, int entnum, float fvol, float attn, float synctime )
-{
-	return; // stub, use AVI_SetParm and AVI_Think to stream AVI sound
-}
-
 static render_api_t gRenderAPI =
 {
 	pfnRenderGetParm, // GL_RenderGetParm,
@@ -270,7 +268,7 @@ static render_api_t gRenderAPI =
 	NULL, // R_UploadStretchRaw,
 	(void*)AVI_FreeVideo,
 	(void*)AVI_IsActive,
-	(void*)pfnAVI_StreamSound,
+	S_StreamAviSamples,
 	NULL,
 	NULL,
 	NULL, // GL_Bind,

engine/client/cl_scrn.c

@@ -124,7 +124,7 @@ void SCR_DrawPos( void )
 	if( cls.state != ca_active || !cl_showpos.value || cl.background )
 		return;
 
-	ent = CL_GetLocalPlayer();
+	ent = CL_EDICT_NUM( cl.playernum + 1 );
 	speed = VectorLength( cl.simvel );
 
 	Q_snprintf( msg, MAX_SYSPATH,

engine/client/cl_tent.c

@@ -567,54 +567,57 @@ R_FizzEffect
 Create a fizz effect
 ==============
 */
-void GAME_EXPORT R_FizzEffect( cl_entity_t *ent, int modelIndex, int density )
+void GAME_EXPORT R_FizzEffect( cl_entity_t *pent, int modelIndex, int density )
 {
-	const float base_time = cl.time - 0.1f;
-	model_t	*mod = CL_ModelHandle( modelIndex );
-	vec3_t  volume, mins, maxs;
-	vec2_t  speed;
-	int     i;
+	TEMPENTITY	*pTemp;
+	int		i, width, depth;
+	float		angle, maxHeight, speed;
+	float		xspeed, yspeed, zspeed;
+	vec3_t		origin;
+	model_t		*mod;
 
-	if( !ent || !ent->model || !modelIndex || !mod )
+	if( !pent || !pent->model || !modelIndex )
 		return;
 
-	VectorCopy( ent->model->mins, mins );
-	VectorCopy( ent->model->maxs, maxs );
+	if(( mod = CL_ModelHandle( modelIndex )) == NULL )
+		return;
 
-	if( ent->angles[1] != 0.0f )
-	{
-		const float base_speed = ( ent->curstate.rendercolor.b ? -1.0f : 1.0f ) * ( ent->curstate.rendercolor.r * 256.0f + ent->curstate.rendercolor.g );
-		SinCos( DEG2RAD( ent->angles[1] ), &speed[1], &speed[0] );
-		speed[0] *= base_speed;
-		speed[1] *= base_speed;
-	}
-	else speed[0] = speed[1] = 0.0f;
+	maxHeight = pent->model->maxs[2] - pent->model->mins[2];
+	width = pent->model->maxs[0] - pent->model->mins[0];
+	depth = pent->model->maxs[1] - pent->model->mins[1];
 
-	VectorSubtract( maxs, mins, volume );
+	speed = ( pent->curstate.rendercolor.r<<8 | pent->curstate.rendercolor.g );
+	if( pent->curstate.rendercolor.b )
+		speed = -speed;
+
+	angle = DEG2RAD( pent->angles[YAW] );
+	SinCos( angle, &yspeed, &xspeed );
+
+	xspeed *= speed;
+	yspeed *= speed;
 
 	for( i = 0; i <= density; i++ )
 	{
-		TEMPENTITY *tent;
-		vec3_t origin;
+		origin[0] = mod->mins[0] + COM_RandomLong( 0, width - 1 );
+		origin[1] = mod->mins[1] + COM_RandomLong( 0, depth - 1 );
+		origin[2] = mod->mins[2];
+		pTemp = CL_TempEntAlloc( origin, mod );
 
-		VectorCopy( mins, origin );
-		origin[0] += COM_RandomLong( 0, (int)volume[0] - 1 );
-		origin[1] += COM_RandomLong( 0, (int)volume[1] - 1 );
+		if ( !pTemp ) return;
 
-		if( !( tent = CL_TempEntAlloc( origin, mod )))
-			return;
+		pTemp->flags |= FTENT_SINEWAVE;
 
-		tent->x = origin[0];
-		tent->y = origin[1];
-		tent->die = base_time;
-		tent->flags |= FTENT_SINEWAVE;
-		tent->entity.curstate.rendermode = kRenderTransAlpha;
-		Vector2Copy( speed, tent->entity.baseline.origin );
+		pTemp->x = origin[0];
+		pTemp->y = origin[1];
 
-		tent->entity.baseline.origin[2] = COM_RandomLong( 80, 140 );
-		tent->die += volume[2] / tent->entity.baseline.origin[2];
-		tent->entity.curstate.frame = COM_RandomLong( 0, tent->frameMax );
-		tent->entity.curstate.scale = 1.0f / COM_RandomFloat( 2.0f, 5.0f );
+		zspeed = COM_RandomLong( 80, 140 );
+		VectorSet( pTemp->entity.baseline.origin, xspeed, yspeed, zspeed );
+		pTemp->die = cl.time + ( maxHeight / zspeed ) - 0.1f;
+		pTemp->entity.curstate.frame = COM_RandomLong( 0, pTemp->frameMax );
+		// Set sprite scale
+		pTemp->entity.curstate.scale = 1.0f / COM_RandomFloat( 2.0f, 5.0f );
+		pTemp->entity.curstate.rendermode = kRenderTransAlpha;
+		pTemp->entity.curstate.renderamt = 255;
 	}
 }
 
@@ -955,6 +958,7 @@ void GAME_EXPORT R_BloodSprite( const vec3_t org, int colorIndex, int modelIndex
 				if( pTemp->entity.curstate.frame > 8.0f )
 					pTemp->entity.curstate.frame = pTemp->frameMax;
 
+				pTemp->entity.baseline.origin[2] += COM_RandomFloat( 4.0f, 16.0f ) * size;
 				pTemp->entity.angles[2] = COM_RandomFloat( 0.0f, 360.0f );
 				pTemp->bounceFactor	= 0.0f;
 			}
@@ -2423,18 +2427,18 @@ static void CL_ClearLightStyles( void )
 
 void CL_SetLightstyle( int style, const char *s, float f )
 {
-	int i;
-	lightstyle_t *ls;
+	int		i, k;
+	lightstyle_t	*ls;
+	float		val1, val2;
 
-	if( unlikely( style < 0 || style >= MAX_LIGHTSTYLES ))
-	{
-		Con_Printf( S_WARN "%s: ignored invalid lightstyle id %d\n", __func__, style );
-		return;
-	}
+	Assert( s != NULL );
+	Assert( style >= 0 && style < MAX_LIGHTSTYLES );
 
 	ls = &cl.lightstyles[style];
 
-	ls->length = Q_strncpy( ls->pattern, s, sizeof( ls->pattern ));
+	Q_strncpy( ls->pattern, s, sizeof( ls->pattern ));
+
+	ls->length = Q_strlen( s );
 	ls->time = f; // set local time
 
 	for( i = 0; i < ls->length; i++ )
@@ -2444,10 +2448,10 @@ void CL_SetLightstyle( int style, const char *s, float f )
 
 	// check for allow interpolate
 	// NOTE: fast flickering styles looks ugly when interpolation is running
-	for( i = 0; i < ( ls->length - 1 ); i++ )
+	for( k = 0; k < (ls->length - 1); k++ )
 	{
-		float val1 = ls->map[( i + 0 ) % ls->length];
-		float val2 = ls->map[( i + 1 ) % ls->length];
+		val1 = ls->map[(k+0) % ls->length];
+		val2 = ls->map[(k+1) % ls->length];
 
 		if( fabs( val1 - val2 ) > STYLE_LERPING_THRESHOLD )
 		{
@@ -2467,8 +2471,8 @@ DLIGHT MANAGEMENT
 
 ==============================================================
 */
-static dlight_t cl_dlights[MAX_DLIGHTS];
-static dlight_t cl_elights[MAX_ELIGHTS];
+dlight_t	cl_dlights[MAX_DLIGHTS];
+dlight_t	cl_elights[MAX_ELIGHTS];
 
 /*
 ================

engine/client/cl_view.c

@@ -165,7 +165,7 @@ static void V_SetRefParams( ref_params_t *fd )
 
 	// get pointers to movement vars and user cmd
 	fd->movevars = &clgame.movevars;
-	fd->cmd = &cl.cmd;
+	fd->cmd = cl.cmd;
 
 	// setup viewport
 	fd->viewport[0] = clgame.viewport[0];
@@ -466,8 +466,8 @@ static void R_ShowTree_r( mnode_t *node, float x, float y, float scale, int show
 		R_DrawNodeConnection( x, y, x + scale, y + scale );
 	}
 
-	R_ShowTree_r( node_child( node, 1, cl.worldmodel ), x - scale, y + scale, downScale, shownodes, viewleaf );
-	R_ShowTree_r( node_child( node, 0, cl.worldmodel ), x + scale, y + scale, downScale, shownodes, viewleaf );
+	R_ShowTree_r( node->children[1], x - scale, y + scale, downScale, shownodes, viewleaf );
+	R_ShowTree_r( node->children[0], x + scale, y + scale, downScale, shownodes, viewleaf );
 
 	world.recursion_level--;
 }
@@ -482,7 +482,7 @@ static void R_ShowTree( void )
 		return;
 
 	world.recursion_level = 0;
-	viewleaf = Mod_PointInLeaf( refState.vieworg, cl.worldmodel->nodes, cl.worldmodel );
+	viewleaf = Mod_PointInLeaf( refState.vieworg, cl.worldmodel->nodes );
 
 	ref.dllFuncs.TriRenderMode( kRenderTransTexture );
 

engine/client/client.h

@@ -234,7 +234,7 @@ typedef struct
 	cl_local_data_t	local;
 
 	// player final info
-	usercmd_t	cmd;			// cl.commands[outgoing_sequence].cmd
+	usercmd_t		*cmd;			// cl.commands[outgoing_sequence].cmd
 	vec3_t		viewangles;
 	vec3_t		viewheight;
 	vec3_t		punchangle;
@@ -495,9 +495,7 @@ typedef struct
 
 	cl_entity_t	viewent;			// viewmodel
 
-#if XASH_WIN32
 	qboolean client_dll_uses_sdl;
-#endif
 } clgame_static_t;
 
 typedef struct
@@ -688,7 +686,6 @@ extern convar_t	r_showtextures;
 extern convar_t	cl_bmodelinterp;
 extern convar_t	cl_lw;		// local weapons
 extern convar_t	cl_charset;
-extern convar_t	cl_trace_consistency;
 extern convar_t	cl_trace_stufftext;
 extern convar_t	cl_trace_messages;
 extern convar_t	cl_trace_events;
@@ -737,7 +734,6 @@ void CL_ClearResourceLists( void );
 //
 // cl_debug.c
 //
-void CL_ReplayBufferDat_f( void );
 void CL_Parse_Debug( qboolean enable );
 void CL_Parse_RecordCommand( int cmd, int startoffset );
 void CL_ResetFrame( frame_t *frame );
@@ -769,7 +765,7 @@ void CL_StartupDemoHeader( void );
 void CL_DrawDemoRecording( void );
 void CL_WriteDemoUserCmd( int cmdnumber );
 void CL_WriteDemoMessage( qboolean startup, int start, sizebuf_t *msg );
-void CL_WriteDemoUserMessage( int size, byte *buffer );
+void CL_WriteDemoUserMessage( const byte *buffer, size_t size );
 qboolean CL_DemoReadMessage( byte *buffer, size_t *length );
 void CL_DemoInterpolateAngles( void );
 void CL_CheckStartupDemos( void );
@@ -807,11 +803,11 @@ qboolean Con_LoadFixedWidthFont( const char *fontname, cl_font_t *font, float sc
 qboolean Con_LoadVariableWidthFont( const char *fontname, cl_font_t *font, float scale, convar_t *rendermode, uint texFlags );
 void CL_FreeFont( cl_font_t *font );
 void CL_SetFontRendermode( cl_font_t *font );
-int CL_DrawCharacter( float x, float y, int number, const rgba_t color, cl_font_t *font, int flags );
-int CL_DrawString( float x, float y, const char *s, const rgba_t color, cl_font_t *font, int flags );
+int CL_DrawCharacter( float x, float y, int number, rgba_t color, cl_font_t *font, int flags );
+int CL_DrawString( float x, float y, const char *s, rgba_t color, cl_font_t *font, int flags );
 void CL_DrawCharacterLen( cl_font_t *font, int number, int *width, int *height );
 void CL_DrawStringLen( cl_font_t *font, const char *s, int *width, int *height, int flags );
-int CL_DrawStringf( cl_font_t *font, float x, float y, const rgba_t color, int flags, const char *fmt, ... ) FORMAT_CHECK( 6 );
+int CL_DrawStringf( cl_font_t *font, float x, float y, rgba_t color, int flags, const char *fmt, ... ) FORMAT_CHECK( 6 );
 
 
 //
@@ -844,21 +840,19 @@ void CL_EnableScissor( scissor_state_t *scissor, int x, int y, int width, int he
 void CL_DisableScissor( scissor_state_t *scissor );
 qboolean CL_Scissor( const scissor_state_t *scissor, float *x, float *y, float *width, float *height, float *u0, float *v0, float *u1, float *v1 );
 
-static inline cl_entity_t *CL_EDICT_NUM( int index )
+static inline cl_entity_t *CL_EDICT_NUM( int n )
 {
-	if( !clgame.entities ) // not in game yet
+	if( !clgame.entities )
 	{
 		Host_Error( "%s: clgame.entities is NULL\n", __func__ );
 		return NULL;
 	}
 
-	if( index < 0 || index >= clgame.maxEntities )
-	{
-		Host_Error( "%s: bad number %i\n", __func__, index );
-		return NULL;
-	}
+	if(( n >= 0 ) && ( n < clgame.maxEntities ))
+		return clgame.entities + n;
 
-	return clgame.entities + index;
+	Host_Error( "%s: bad number %i\n", __func__, n );
+	return NULL;
 }
 
 static inline cl_entity_t *CL_GetEntityByIndex( int index )
@@ -869,7 +863,10 @@ static inline cl_entity_t *CL_GetEntityByIndex( int index )
 	if( index < 0 || index >= clgame.maxEntities )
 		return NULL;
 
-	return clgame.entities + index;
+	if( index == 0 )
+		return clgame.entities;
+
+	return CL_EDICT_NUM( index );
 }
 
 static inline model_t *CL_ModelHandle( int modelindex )
@@ -879,17 +876,15 @@ static inline model_t *CL_ModelHandle( int modelindex )
 
 static inline qboolean CL_IsThirdPerson( void )
 {
-	return clgame.dllFuncs.CL_IsThirdPerson();
+	return clgame.dllFuncs.CL_IsThirdPerson() ? true : false;
 }
 
 static inline cl_entity_t *CL_GetLocalPlayer( void )
 {
-	cl_entity_t	*player = CL_GetEntityByIndex( cl.playernum + 1 );
+	cl_entity_t	*player;
 
-	// HACKHACK: GoldSrc doesn't do this, but some mods actually check it for null pointer
-	// this is a lesser evil than changing semantics of HUD_VidInit and call it after entities are allocated
-	if( !player )
-		Con_Printf( S_WARN "%s: client entities are not initialized yet! Returning NULL...\n", __func__ );
+	player = CL_EDICT_NUM( cl.playernum + 1 );
+	Assert( player != NULL );
 
 	return player;
 }
@@ -1107,7 +1102,7 @@ int Con_UtfMoveRight( char *str, int pos, int length );
 void Con_DefaultColor( int r, int g, int b, qboolean gameui );
 cl_font_t *Con_GetCurFont( void );
 cl_font_t *Con_GetFont( int num );
-int Con_DrawString( int x, int y, const char *string, const rgba_t setColor ); // legacy, use cl_font.c
+int Con_DrawString( int x, int y, const char *string, rgba_t setColor ); // legacy, use cl_font.c
 void GAME_EXPORT Con_DrawStringLen( const char *pText, int *length, int *height ); // legacy, use cl_font.c
 void Con_CharEvent( int key );
 void Key_Console( int key );
@@ -1120,7 +1115,7 @@ void Con_PageUp( int lines );
 //
 // s_main.c
 //
-typedef int sound_t;
+void S_StreamAviSamples( void *Avi, int entnum, float fvol, float attn, float synctime );
 void S_StartBackgroundTrack( const char *intro, const char *loop, int position, qboolean fullpath );
 void S_StopBackgroundTrack( void );
 void S_StreamSetPause( int pause );
@@ -1200,21 +1195,16 @@ void Key_Init( void );
 void Key_WriteBindings( file_t *f );
 const char *Key_GetBinding( int keynum );
 void Key_SetBinding( int keynum, const char *binding );
-const char *Key_LookupBinding( const char *pBinding );
 void Key_ClearStates( void );
 const char *Key_KeynumToString( int keynum );
+int Key_StringToKeynum( const char *str );
+int Key_GetKey( const char *binding );
 void Key_EnumCmds_f( void );
 void Key_SetKeyDest( int key_dest );
 void Key_EnableTextInput( qboolean enable, qboolean force );
 int Key_ToUpper( int key );
 void OSK_Draw( void );
 
-//
-// identification.c
-//
-void ID_Init( void );
-const char *ID_GetMD5( void );
-
 extern rgba_t g_color_table[8];
 extern triangleapi_t gTriApi;
 extern net_api_t gNetApi;

engine/client/console.c

@@ -622,7 +622,7 @@ int Con_UtfProcessCharForce( int in )
 	// TODO: get rid of global state where possible
 	static utfstate_t state = { 0 };
 
-	uint32_t ch = Q_DecodeUTF8( &state, in );
+	int ch = Q_DecodeUTF8( &state, in );
 
 	if( g_codepage == 1251 )
 		return Q_UnicodeToCP1251( ch );
@@ -759,7 +759,7 @@ Con_DrawString
 client version of routine
 ====================
 */
-int Con_DrawString( int x, int y, const char *string, const rgba_t setColor )
+int Con_DrawString( int x, int y, const char *string, rgba_t setColor )
 {
 	return CL_DrawString( x, y, string, setColor, con.curFont, FONT_DRAW_UTF8 );
 }
@@ -843,14 +843,11 @@ If no console is visible, the notify window will pop up.
 */
 void Con_Print( const char *txt )
 {
-	static qboolean cr_pending = false;
-	static qboolean colorstring = false;
-	static char buf[MAX_PRINT_MSG];
-	static int  lastlength = 0;
-	static int  bufpos = 0;
-	static int  charpos = 0;
-
-	qboolean norefresh = false;
+	static int	cr_pending = 0;
+	static char	buf[MAX_PRINT_MSG];
+	qboolean		norefresh = false;
+	static int	lastlength = 0;
+	static int	bufpos = 0;
 	int		c, mask = 0;
 
 	// client not running
@@ -876,7 +873,7 @@ void Con_Print( const char *txt )
 		if( cr_pending )
 		{
 			Con_DeleteLastLine();
-			cr_pending = false;
+			cr_pending = 0;
 		}
 		c = *txt;
 
@@ -889,42 +886,23 @@ void Con_Print( const char *txt )
 			{
 				Con_AddLine( buf, bufpos, true );
 				lastlength = CON_LINES_LAST().length;
-				cr_pending = true;
+				cr_pending = 1;
 				bufpos = 0;
-				charpos = 0;
 			}
 			break;
 		case '\n':
 			Con_AddLine( buf, bufpos, true );
 			lastlength = CON_LINES_LAST().length;
 			bufpos = 0;
-			charpos = 0;
 			break;
 		default:
+
 			buf[bufpos++] = c | mask;
-
-			if( IsColorString( txt ))
-			{
-				// first color string character
-				colorstring = true;
-			}
-			else if( colorstring )
-			{
-				// second color string character
-				colorstring = false;
-			}
-			else
-			{
-				// not a color string, move char counter
-				charpos++;
-			}
-
-			if(( bufpos >= sizeof( buf ) - 1 ) || charpos >= ( con.linewidth - 1 ))
+			if(( bufpos >= sizeof( buf ) - 1 ) || bufpos >= ( con.linewidth - 1 ))
 			{
 				Con_AddLine( buf, bufpos, true );
 				lastlength = CON_LINES_LAST().length;
 				bufpos = 0;
-				charpos = 0;
 			}
 			break;
 		}
@@ -940,7 +918,6 @@ void Con_Print( const char *txt )
 			Con_AddLine( buf, bufpos, lastlength != 0 );
 			lastlength = 0;
 			bufpos = 0;
-			charpos = 0;
 		}
 
 		// pump messages to avoid window hanging
@@ -1267,16 +1244,45 @@ static void Field_CharEvent( field_t *edit, int ch )
 Field_DrawInputLine
 ==================
 */
-static void Field_DrawInputLine( int x, int y, const field_t *edit )
+static void Field_DrawInputLine( int x, int y, field_t *edit )
 {
-	int curPos;
-	char str[MAX_SYSPATH];
-	const byte *colorDefault = g_color_table[ColorIndex( COLOR_DEFAULT )];
-	const int prestep = bound( 0, edit->scroll, sizeof( edit->buffer ) - 1 );
-	const int drawLen = bound( 0, edit->widthInChars, sizeof( str ));
-	const int cursorCharPos = bound( 0, edit->cursor - prestep, sizeof( str ));
+	int	len, cursorChar;
+	int	drawLen;
+	int	prestep, curPos;
+	char	str[MAX_SYSPATH];
+	byte	*colorDefault;
 
-	Q_strncpy( str, edit->buffer + prestep, drawLen );
+	drawLen = edit->widthInChars;
+	len = Q_strlen( edit->buffer ) + 1;
+	colorDefault = g_color_table[ColorIndex( COLOR_DEFAULT )];
+
+	// guarantee that cursor will be visible
+	if( len <= drawLen )
+	{
+		prestep = 0;
+	}
+	else
+	{
+		if( edit->scroll + drawLen > len )
+		{
+			edit->scroll = len - drawLen;
+			if( edit->scroll < 0 ) edit->scroll = 0;
+		}
+
+		prestep = edit->scroll;
+	}
+
+	if( prestep + drawLen > len )
+		drawLen = len - prestep;
+
+	// extract <drawLen> characters from the field at <prestep>
+	drawLen = Q_min( drawLen, MAX_SYSPATH - 1 );
+
+	memcpy( str, edit->buffer + prestep, drawLen );
+	str[drawLen] = 0;
+
+	// save char for overstrike
+	cursorChar = str[edit->cursor - prestep];
 
 	// draw it
 	CL_DrawString( x, y, str, colorDefault, con.curFont, FONT_DRAW_UTF8 );
@@ -1285,7 +1291,7 @@ static void Field_DrawInputLine( int x, int y, const field_t *edit )
 	if((int)( host.realtime * 4 ) & 1 ) return; // off blink
 
 	// calc cursor position
-	str[cursorCharPos] = 0;
+	str[edit->cursor - prestep] = 0;
 	CL_DrawStringLen( con.curFont, str, &curPos, NULL, FONT_DRAW_UTF8 );
 
 	if( host.key_overstrike )
@@ -1461,16 +1467,6 @@ Handles history and console scrollback
 */
 void Key_Console( int key )
 {
-	// exit the console by pressing MINUS on NSwitch
-	// or both Back(Select)/Start buttons for everyone else
-	if( key == K_BACK_BUTTON || key == K_START_BUTTON || key == K_ESCAPE )
-	{
-		if( cls.state == ca_active && !cl.background )
-			Key_SetKeyDest( key_game );
-		else UI_SetActiveMenu( true );
-		return;
-	}
-
 	// ctrl-L clears screen
 	if( key == 'l' && Key_IsDown( K_CTRL ))
 	{
@@ -1579,6 +1575,16 @@ void Key_Console( int key )
 		return;
 	}
 
+	// exit the console by pressing MINUS on NSwitch
+	// or both Back(Select)/Start buttons for everyone else
+	if( key == K_BACK_BUTTON || key == K_START_BUTTON )
+	{
+		if( cls.state == ca_active && !cl.background )
+			Key_SetKeyDest( key_game );
+		else UI_SetActiveMenu( true );
+		return;
+	}
+
 	// pass to the normal editline routine
 	Field_KeyDownEvent( &con.input, key );
 }
@@ -2002,7 +2008,7 @@ void Con_DrawVersion( void )
 	int	start, height = refState.height;
 	string	curbuild;
 
-	if( !scr_drawversion.value )
+	if( !scr_drawversion.value || CL_IsDevOverviewMode() == 2 || net_graph.value )
 		return;
 
 	if( cls.key_dest == key_menu )
@@ -2014,9 +2020,6 @@ void Con_DrawVersion( void )
 	{
 		qboolean draw_version;
 
-		if( CL_IsDevOverviewMode() == 2 || net_graph.value )
-			return;
-
 		draw_version = cls.scrshot_action == scrshot_normal
 			|| cls.scrshot_action == scrshot_snapshot
 			|| host.force_draw_version_time > host.realtime;
@@ -2089,7 +2092,10 @@ void Con_RunConsole( void )
 		}
 		else
 		{
-			g_codepage = 0;
+			Con_Printf( S_WARN "Unknown charset %s, defaulting to cp1252", con_charset.string );
+
+			Cvar_DirectSet( &con_charset, "cp1252" );
+			g_codepage = 1252;
 		}
 
 		cls.accept_utf8 = !Q_stricmp( cl_charset.string, "utf-8" );
@@ -2132,31 +2138,20 @@ void Con_CharEvent( int key )
 
 static int Con_LoadSimpleConback( const char *name, int flags )
 {
-	int i;
+	const char *paths[] = {
+		"gfx/shell/%s.dds",
+		"gfx/shell/%s.bmp",
+		"gfx/shell/%s.tga",
+		"cached/%s640",
+		"cached/%s",
+	};
+	size_t i;
 
-	for( i = 0; i < 5; i++ )
+	for( i = 0; i < ARRAYSIZE( paths ); i++ )
 	{
 		string path;
 
-		switch( i )
-		{
-		case 0:
-			Q_snprintf( path, sizeof( path ), "gfx/shell/%s.dds", name );
-			break;
-		case 1:
-			Q_snprintf( path, sizeof( path ), "gfx/shell/%s.bmp", name );
-			break;
-		case 2:
-			Q_snprintf( path, sizeof( path ), "gfx/shell/%s.tga", name );
-			break;
-		case 3:
-			Q_snprintf( path, sizeof( path ), "cached/%s640", name );
-			break;
-		case 4:
-			Q_snprintf( path, sizeof( path ), "cached/%s", name );
-			break;
-		}
-
+		Q_snprintf( path, sizeof( path ), paths[i], name );
 		if( g_fsapi.FileExists( path, false ))
 		{
 			int gl_texturenum = ref.dllFuncs.GL_LoadTexture( path, NULL, 0, flags );

engine/client/in_joy.c

@@ -43,6 +43,7 @@ static struct joy_axis_s
 	short val;
 	short prevval;
 } joyaxis[MAX_AXES] = { 0 };
+static byte currentbinding; // add posibility to remap keys, to place it in joykeys[]
 static qboolean joy_initialized;
 
 static CVAR_DEFINE_AUTO( joy_pitch,   "100.0", FCVAR_ARCHIVE | FCVAR_FILTERABLE, "joystick pitch sensitivity" );
@@ -59,9 +60,9 @@ static CVAR_DEFINE_AUTO( joy_pitch_deadzone, DEFAULT_JOY_DEADZONE, FCVAR_ARCHIVE
 static CVAR_DEFINE_AUTO( joy_yaw_deadzone, DEFAULT_JOY_DEADZONE, FCVAR_ARCHIVE | FCVAR_FILTERABLE, "yaw axis deadzone. Value from 0 to 32767" );
 static CVAR_DEFINE_AUTO( joy_axis_binding, "sfpyrl", FCVAR_ARCHIVE | FCVAR_FILTERABLE, "axis hardware id to engine inner axis binding, "
 	"s - side, f - forward, y - yaw, p - pitch, r - left trigger, l - right trigger" );
+static CVAR_DEFINE_AUTO( joy_found, "0", FCVAR_READ_ONLY, "is joystick is connected" );
+static CVAR_DEFINE_AUTO( joy_index, "0", FCVAR_READ_ONLY, "current active joystick" );
 CVAR_DEFINE_AUTO( joy_enable, "1", FCVAR_ARCHIVE | FCVAR_FILTERABLE, "enable joystick" );
-static CVAR_DEFINE_AUTO( joy_have_gyro, "0", FCVAR_READ_ONLY, "tells whether current active gamepad has gyroscope or not" );
-static CVAR_DEFINE_AUTO( joy_calibrated, "0", FCVAR_READ_ONLY, "tells whether current active gamepad gyroscope has been calibrated or not" );
 
 /*
 ============
@@ -70,30 +71,7 @@ Joy_IsActive
 */
 qboolean Joy_IsActive( void )
 {
-	return joy_enable.value;
-}
-
-/*
-===========
-Joy_SetCapabilities
-===========
-*/
-void Joy_SetCapabilities( qboolean have_gyro )
-{
-	Cvar_FullSet( joy_have_gyro.name, have_gyro ? "1" : "0", joy_have_gyro.flags );
-}
-
-/*
-===========
-Joy_SetCalibrationState
-===========
-*/
-void Joy_SetCalibrationState( joy_calibration_state_t state )
-{
-	if( (int)joy_calibrated.value == state )
-		return;
-
-	Cvar_FullSet( joy_calibrated.name, va( "%d", state ), joy_calibrated.flags );
+	return joy_found.value && joy_enable.value;
 }
 
 /*
@@ -103,7 +81,7 @@ Joy_HatMotionEvent
 DPad events
 ============
 */
-static void Joy_HatMotionEvent( int value )
+void Joy_HatMotionEvent( byte hat, byte value )
 {
 	struct
 	{
@@ -118,6 +96,9 @@ static void Joy_HatMotionEvent( int value )
 	};
 	int i;
 
+	if( !joy_found.value )
+		return;
+
 	for( i = 0; i < ARRAYSIZE( keys ); i++ )
 	{
 		if( value & keys[i].mask )
@@ -244,7 +225,7 @@ static void Joy_ProcessStick( const engineAxis_t engineAxis, short value )
 		val |= Joy_GetHatValueForAxis( JOY_AXIS_SIDE );
 		val |= Joy_GetHatValueForAxis( JOY_AXIS_FWD );
 
-		Joy_HatMotionEvent( val );
+		Joy_HatMotionEvent( 0, val );
 	}
 }
 
@@ -255,9 +236,23 @@ Joy_AxisMotionEvent
 Axis events
 =============
 */
-void Joy_AxisMotionEvent( engineAxis_t engineAxis, short value )
+void Joy_AxisMotionEvent( byte axis, short value )
 {
-	if( engineAxis >= JOY_AXIS_NULL )
+	if( !joy_found.value )
+		return;
+
+	if( axis >= MAX_AXES )
+	{
+		Con_Reportf( "Only 6 axes is supported\n" );
+		return;
+	}
+
+	Joy_KnownAxisMotionEvent( joyaxesmap[axis], value );
+}
+
+void Joy_KnownAxisMotionEvent( engineAxis_t engineAxis, short value )
+{
+	if( engineAxis == JOY_AXIS_NULL )
 		return;
 
 	if( value == joyaxis[engineAxis].val )
@@ -271,14 +266,66 @@ void Joy_AxisMotionEvent( engineAxis_t engineAxis, short value )
 
 /*
 =============
-Joy_GyroEvent
+Joy_BallMotionEvent
 
-Gyroscope events
+Trackball events. UNDONE
 =============
 */
-void Joy_GyroEvent( vec3_t data )
+void Joy_BallMotionEvent( byte ball, short xrel, short yrel )
 {
+	//if( !joy_found.value )
+	//	return;
+}
 
+/*
+=============
+Joy_ButtonEvent
+
+Button events
+=============
+*/
+void Joy_ButtonEvent( byte button, byte down )
+{
+	if( !joy_found.value )
+		return;
+
+	// generic game button code.
+	if( button > 32 )
+	{
+		int origbutton = button;
+		button = ( button & 31 ) + K_AUX1;
+
+		Con_Reportf( "Only 32 joybuttons is supported, converting %i button ID to %s\n", origbutton, Key_KeynumToString( button ) );
+	}
+	else button += K_AUX1;
+
+	Key_Event( button, down );
+}
+
+/*
+=============
+Joy_RemoveEvent
+
+Called when joystick is removed. For future expansion
+=============
+*/
+void Joy_RemoveEvent( void )
+{
+	if( joy_found.value )
+		Cvar_FullSet( "joy_found", "0", FCVAR_READ_ONLY );
+}
+
+/*
+=============
+Joy_RemoveEvent
+
+Called when joystick is removed. For future expansion
+=============
+*/
+void Joy_AddEvent( void )
+{
+	if( joy_enable.value && !joy_found.value )
+		Cvar_FullSet( "joy_found", "1", FCVAR_READ_ONLY );
 }
 
 /*
@@ -317,19 +364,14 @@ void Joy_FinalizeMove( float *fw, float *side, float *dpitch, float *dyaw )
 
 	*fw     -= joy_forward.value * (float)joyaxis[JOY_AXIS_FWD ].val/(float)SHRT_MAX;  // must be form -1.0 to 1.0
 	*side   += joy_side.value    * (float)joyaxis[JOY_AXIS_SIDE].val/(float)SHRT_MAX;
+#if !defined(XASH_SDL)
+	*dpitch += joy_pitch.value * (float)joyaxis[JOY_AXIS_PITCH].val/(float)SHRT_MAX * host.realframetime;  // abs axis rotate is frametime related
+	*dyaw   -= joy_yaw.value   * (float)joyaxis[JOY_AXIS_YAW  ].val/(float)SHRT_MAX * host.realframetime;
+#else
+	// HACKHACK: SDL have inverted look axis.
 	*dpitch -= joy_pitch.value * (float)joyaxis[JOY_AXIS_PITCH].val/(float)SHRT_MAX * host.realframetime;
 	*dyaw   += joy_yaw.value   * (float)joyaxis[JOY_AXIS_YAW  ].val/(float)SHRT_MAX * host.realframetime;
-}
-
-static void Joy_CalibrateGyro_f( void )
-{
-	if( !joy_have_gyro.value )
-	{
-		Con_Printf( "Current active gamepad doesn't have gyroscope\n" );
-		return;
-	}
-
-	Platform_CalibrateGamepadGyro();
+#endif
 }
 
 /*
@@ -341,8 +383,6 @@ Main init procedure
 */
 void Joy_Init( void )
 {
-	Cmd_AddRestrictedCommand( "joy_calibrate_gyro", Joy_CalibrateGyro_f, "calibrate gamepad gyroscope. You must to put gamepad on stationary surface" );
-
 	Cvar_RegisterVariable( &joy_pitch );
 	Cvar_RegisterVariable( &joy_yaw );
 	Cvar_RegisterVariable( &joy_side );
@@ -362,9 +402,11 @@ void Joy_Init( void )
 	Cvar_RegisterVariable( &joy_yaw_deadzone );
 
 	Cvar_RegisterVariable( &joy_axis_binding );
+	Cvar_RegisterVariable( &joy_found );
+	// we doesn't loaded config.cfg yet, so this cvar is not archive.
+	// change by +set joy_index in cmdline
+	Cvar_RegisterVariable( &joy_index );
 
-	Cvar_RegisterVariable( &joy_have_gyro );
-	Cvar_RegisterVariable( &joy_calibrated );
 	Cvar_RegisterVariable( &joy_enable );
 
 	// renamed from -nojoy to -noenginejoy to not conflict with
@@ -375,7 +417,7 @@ void Joy_Init( void )
 		return;
 	}
 
-	Platform_JoyInit();
+	Cvar_FullSet( "joy_found", va( "%d", Platform_JoyInit( joy_index.value )), FCVAR_READ_ONLY );
 
 	joy_initialized = true;
 }
@@ -389,5 +431,8 @@ Shutdown joystick code
 */
 void Joy_Shutdown( void )
 {
-	Platform_JoyShutdown();
+	if( joy_initialized )
+	{
+		Cvar_FullSet( "joy_found", 0, FCVAR_READ_ONLY );
+	}
 }

engine/client/input.c

@@ -13,17 +13,16 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.
 */
 
-#if XASH_SDL == 2
-#include <SDL.h>
-#elif XASH_SDL == 3
-#include <SDL3/SDL.h>
-#endif
-
 #include "common.h"
 #include "input.h"
 #include "client.h"
 #include "vgui_draw.h"
 #include "cursor_type.h"
+
+#if XASH_SDL
+#include <SDL.h>
+#endif
+
 #include "platform/platform.h"
 
 void*		in_mousecursor;
@@ -206,58 +205,50 @@ void IN_ToggleClientMouse( int newstate, int oldstate )
 	}
 }
 
-void IN_SetRelativeMouseMode( qboolean set )
+static void IN_SetRelativeMouseMode( qboolean set, qboolean verbose )
 {
 	static qboolean s_bRawInput;
-	qboolean verbose = m_grab_debug.value ? true : false;
 
 	if( set && !s_bRawInput )
 	{
-#if XASH_SDL >= 2
-		SDL_GetRelativeMouseState( NULL, NULL );
 #if XASH_SDL == 2
+		SDL_GetRelativeMouseState( NULL, NULL );
 		SDL_SetRelativeMouseMode( SDL_TRUE );
-#else // XASH_SDL != 2
-		SDL_SetWindowRelativeMouseMode( host.hWnd, true );
-#endif // XASH_SDL != 2
-#endif // XASH_SDL >= 2
+#endif
 		s_bRawInput = true;
 		if( verbose )
 			Con_Printf( "%s: true\n", __func__ );
 	}
 	else if( !set && s_bRawInput )
 	{
-#if XASH_SDL >= 2
-		SDL_GetRelativeMouseState( NULL, NULL );
 #if XASH_SDL == 2
+		SDL_GetRelativeMouseState( NULL, NULL );
 		SDL_SetRelativeMouseMode( SDL_FALSE );
-#else // XASH_SDL != 2
-		SDL_SetWindowRelativeMouseMode( host.hWnd, false );
-#endif // XASH_SDL != 2
-#endif // XASH_SDL >= 2
-
+#endif
 		s_bRawInput = false;
 		if( verbose )
 			Con_Printf( "%s: false\n", __func__ );
 	}
 }
 
-void IN_SetMouseGrab( qboolean set )
+static void IN_SetMouseGrab( qboolean set, qboolean verbose )
 {
 	static qboolean s_bMouseGrab;
-	qboolean verbose = m_grab_debug.value ? true : false;
 
 	if( set && !s_bMouseGrab )
 	{
-		Platform_SetMouseGrab( true );
-
+#if XASH_SDL
+		SDL_SetWindowGrab( host.hWnd, SDL_TRUE );
+#endif
 		s_bMouseGrab = true;
 		if( verbose )
 			Con_Printf( "%s: true\n", __func__ );
 	}
 	else if( !set && s_bMouseGrab )
 	{
-		Platform_SetMouseGrab( false );
+#if XASH_SDL
+		SDL_SetWindowGrab( host.hWnd, SDL_FALSE );
+#endif
 
 		s_bMouseGrab = false;
 		if( verbose )
@@ -267,7 +258,7 @@ void IN_SetMouseGrab( qboolean set )
 
 static void IN_CheckMouseState( qboolean active )
 {
-	qboolean use_raw_input;
+	qboolean use_raw_input, verbose;
 
 #if XASH_WIN32
 	use_raw_input = ( m_rawinput.value && clgame.client_dll_uses_sdl ) || clgame.dllFuncs.pfnLookEvent != NULL;
@@ -275,18 +266,20 @@ static void IN_CheckMouseState( qboolean active )
 	use_raw_input = true; // always use SDL code
 #endif
 
+	verbose = m_grab_debug.value ? true : false;
+
 	if( m_ignore.value )
 		active = false;
 
 	if( active && use_raw_input && !host.mouse_visible && cls.state == ca_active )
-		IN_SetRelativeMouseMode( true );
+		IN_SetRelativeMouseMode( true, verbose );
 	else
-		IN_SetRelativeMouseMode( false );
+		IN_SetRelativeMouseMode( false, verbose );
 
 	if( active && !host.mouse_visible && cls.state == ca_active )
-		IN_SetMouseGrab( true );
+		IN_SetMouseGrab( true, verbose );
 	else
-		IN_SetMouseGrab( false );
+		IN_SetMouseGrab( false, verbose );
 }
 
 /*
@@ -339,7 +332,7 @@ static void IN_MouseMove( void )
 	if( !in_mouseinitialized )
 		return;
 
-	if( Touch_WantVisibleCursor( ))
+	if( Touch_Emulated( ))
 	{
 		// touch emulation overrides all input
 		Touch_KeyEvent( 0, 0 );
@@ -370,7 +363,7 @@ void IN_MouseEvent( int key, int down )
 	else ClearBits( in_mstate, BIT( key ));
 
 	// touch emulation overrides all input
-	if( Touch_WantVisibleCursor( ))
+	if( Touch_Emulated( ))
 	{
 		Touch_KeyEvent( K_MOUSE1 + key, down );
 	}
@@ -640,6 +633,8 @@ Called every frame, even if not generating commands
 */
 void Host_InputFrame( void )
 {
+	Sys_SendKeyEvents ();
+
 	IN_Commands();
 
 	IN_MouseMove();

engine/client/input.h

@@ -46,9 +46,6 @@ uint IN_CollectInputDevices( void );
 void IN_LockInputDevices( qboolean lock );
 void IN_EngineAppendMove( float frametime, usercmd_t *cmd, qboolean active );
 
-void IN_SetRelativeMouseMode( qboolean set );
-void IN_SetMouseGrab( qboolean set );
-
 extern convar_t m_yaw;
 extern convar_t m_pitch;
 //
@@ -77,6 +74,7 @@ void Touch_ResetDefaultButtons( void );
 int IN_TouchEvent( touchEventType type, int fingerID, float x, float y, float dx, float dy );
 void Touch_KeyEvent( int key, int down );
 qboolean Touch_WantVisibleCursor( void );
+qboolean Touch_Emulated( void );
 void Touch_NotifyResize( void );
 
 //
@@ -106,21 +104,18 @@ typedef enum engineAxis_e
 	JOY_AXIS_NULL
 } engineAxis_t;
 
-typedef enum joy_calibration_state_s
-{
-	JOY_NOT_CALIBRATED = 0,
-	JOY_CALIBRATING,
-	JOY_FAILED_TO_CALIBRATE,
-	JOY_CALIBRATED
-} joy_calibration_state_t;
-
 qboolean Joy_IsActive( void );
-void Joy_SetCapabilities( qboolean have_gyro );
-void Joy_SetCalibrationState( joy_calibration_state_t state );
-void Joy_AxisMotionEvent( engineAxis_t engineAxis, short value );
-void Joy_GyroEvent( vec3_t data );
+void Joy_HatMotionEvent( byte hat, byte value );
+void Joy_AxisMotionEvent( byte axis, short value );
+void Joy_KnownAxisMotionEvent( engineAxis_t engineAxis, short value );
+void Joy_BallMotionEvent( byte ball, short xrel, short yrel );
+void Joy_ButtonEvent( byte button, byte down );
+void Joy_AddEvent( void );
+void Joy_RemoveEvent( void );
 void Joy_FinalizeMove( float *fw, float *side, float *dpitch, float *dyaw );
 void Joy_Init( void );
 void Joy_Shutdown( void );
+void Joy_EnableTextInput(qboolean enable, qboolean force);
+
 
 #endif//INPUT_H

engine/client/keys.c

@@ -34,13 +34,13 @@ typedef struct keyname_s
 	const char	*binding;	// default bind
 } keyname_t;
 
-static enginekey_t	keys[256];
+enginekey_t	keys[256];
 
-static const keyname_t keynames[] =
+keyname_t keynames[] =
 {
 {"TAB",		K_TAB,		""		},
 {"ENTER",		K_ENTER,		""		},
-{"ESCAPE",	K_ESCAPE, 	"cancelselect"		}, // hardcoded
+{"ESCAPE",	K_ESCAPE, 	"escape"		}, // hardcoded
 {"SPACE",		K_SPACE,		"+jump"		},
 {"BACKSPACE",	K_BACKSPACE,	""		},
 {"UPARROW",	K_UPARROW,	"+forward"	},
@@ -51,7 +51,7 @@ static const keyname_t keynames[] =
 {"CTRL",		K_CTRL,		"+attack"		},
 {"SHIFT",		K_SHIFT,		"+speed"		},
 {"CAPSLOCK",	K_CAPSLOCK,	""		},
-{"SCROLLOCK",	K_SCROLLLOCK,	""		},
+{"SCROLLOCK",	K_SCROLLOCK,	""		},
 {"F1",		K_F1,		"cmd help"	},
 {"F2",		K_F2,		"menu_savegame"	},
 {"F3",		K_F3,		"menu_loadgame"	},
@@ -106,7 +106,7 @@ static const keyname_t keynames[] =
 {"Y_BUTTON", K_Y_BUTTON, "impulse 100"}, // Flashlight
 {"BACK",   K_BACK_BUTTON, "pause"}, // Menu
 {"MODE",   K_MODE_BUTTON, ""},
-{"START",  K_START_BUTTON, "cancelselect"},
+{"START",  K_START_BUTTON, "escape"},
 {"STICK1", K_LSTICK, "+speed"},
 {"STICK2", K_RSTICK, "+duck"},
 {"L1_BUTTON",  K_L1_BUTTON, "+duck"},
@@ -139,6 +139,7 @@ static const keyname_t keynames[] =
 
 // raw semicolon seperates commands
 {"SEMICOLON",	';',		""		},
+{NULL,		0,		NULL		},
 };
 
 static void OSK_EnableTextInput( qboolean enable, qboolean force );
@@ -171,25 +172,48 @@ the K_* names are matched up.
 to be configured even if they don't have defined names.
 ===================
 */
-static int Key_StringToKeynum( const char *str )
+int Key_StringToKeynum( const char *str )
 {
-	int i;
+	keyname_t		*kn;
 
-	if( !str || !str[0] )
-		return -1;
-
-	if( !str[1] )
-		return str[0];
+	if( !str || !str[0] ) return -1;
+	if( !str[1] ) return str[0];
 
 	// check for hex code
 	if( str[0] == '0' && str[1] == 'x' && Q_strlen( str ) == 4 )
-		return COM_Nibble( str[2] ) << 4 | COM_Nibble( str[3] );
+	{
+		int	n1, n2;
+
+		n1 = str[2];
+		if( n1 >= '0' && n1 <= '9' )
+		{
+			n1 -= '0';
+		}
+		else if( n1 >= 'a' && n1 <= 'f' )
+		{
+			n1 = n1 - 'a' + 10;
+		}
+		else n1 = 0;
+
+		n2 = str[3];
+		if( n2 >= '0' && n2 <= '9' )
+		{
+			n2 -= '0';
+		}
+		else if( n2 >= 'a' && n2 <= 'f' )
+		{
+			n2 = n2 - 'a' + 10;
+		}
+		else n2 = 0;
+
+		return n1 * 16 + n2;
+	}
 
 	// scan for a text match
-	for( i = 0; i < ARRAYSIZE( keynames ); i++ )
+	for( kn = keynames; kn->name; kn++ )
 	{
-		if( !Q_stricmp( str, keynames[i].name ))
-			return keynames[i].keynum;
+		if( !Q_stricmp( str, kn->name ))
+			return kn->keynum;
 	}
 
 	return -1;
@@ -205,17 +229,15 @@ given keynum.
 */
 const char *Key_KeynumToString( int keynum )
 {
+	keyname_t		*kn;
 	static char	tinystr[5];
 	int		i, j;
 
-	if( keynum == -1 )
-		return "<KEY NOT FOUND>";
-
-	if( keynum < 0 || keynum > 255 )
-		return "<OUT OF RANGE>";
+	if ( keynum == -1 ) return "<KEY NOT FOUND>";
+	if ( keynum < 0 || keynum > 255 ) return "<OUT OF RANGE>";
 
 	// check for printable ascii (don't use quote)
-	if( keynum > 32 && keynum < 127 && keynum != '"' && keynum != ';' && keynum != K_SCROLLLOCK )
+	if( keynum > 32 && keynum < 127 && keynum != '"' && keynum != ';' && keynum != K_SCROLLOCK )
 	{
 		tinystr[0] = keynum;
 		tinystr[1] = 0;
@@ -223,10 +245,10 @@ const char *Key_KeynumToString( int keynum )
 	}
 
 	// check for a key string
-	for( i = 0; i < ARRAYSIZE( keynames ); i++ )
+	for( kn = keynames; kn->name; kn++ )
 	{
-		if( keynum == keynames[i].keynum )
-			return keynames[i].name;
+		if( keynum == kn->keynum )
+			return kn->name;
 	}
 
 	// make a hex string
@@ -279,7 +301,7 @@ const char *Key_GetBinding( int keynum )
 Key_GetKey
 ===================
 */
-static int Key_GetKey( const char *pBinding )
+int Key_GetKey( const char *pBinding )
 {
 	int		 i, len;
 	const char	*p;
@@ -305,17 +327,6 @@ static int Key_GetKey( const char *pBinding )
 	return -1;
 }
 
-/*
-=============
-Key_LookupBinding
-
-=============
-*/
-const char *Key_LookupBinding( const char *pBinding )
-{
-	return Key_KeynumToString( Key_GetKey( pBinding ));
-}
-
 /*
 ===================
 Key_Unbind_f
@@ -339,12 +350,6 @@ static void Key_Unbind_f( void )
 		return;
 	}
 
-	if( b == K_ESCAPE )
-	{
-		Con_Printf( "Can't unbind ESCAPE key\n" );
-		return;
-	}
-
 	Key_SetBinding( b, "" );
 }
 
@@ -364,8 +369,8 @@ static void Key_Unbindall_f( void )
 	}
 
 	// set some defaults
-	Key_SetBinding( K_ESCAPE, "cancelselect" );
-	Key_SetBinding( K_START_BUTTON, "cancelselect" );
+	Key_SetBinding( K_ESCAPE, "escape" );
+	Key_SetBinding( K_START_BUTTON, "escape" );
 }
 
 /*
@@ -375,6 +380,7 @@ Key_Reset_f
 */
 static void Key_Reset_f( void )
 {
+	keyname_t	*kn;
 	int	i;
 
 	// clear all keys first
@@ -385,8 +391,8 @@ static void Key_Reset_f( void )
 	}
 
 	// apply default values
-	for( i = 0; i < ARRAYSIZE( keynames ); i++ )
-		Key_SetBinding( keynames[i].keynum, keynames[i].binding );
+	for( kn = keynames; kn->name; kn++ )
+		Key_SetBinding( kn->keynum, kn->binding );
 }
 
 /*
@@ -494,7 +500,7 @@ Key_Init
 */
 void Key_Init( void )
 {
-	int i;
+	keyname_t	*kn;
 
 	// register our functions
 	Cmd_AddRestrictedCommand( "bind", Key_Bind_f, "binds a command to the specified key in bindmap" );
@@ -505,8 +511,7 @@ void Key_Init( void )
 	Cmd_AddCommand( "makehelp", Key_EnumCmds_f, "write help.txt that contains all console cvars and cmds" );
 
 	// setup default binding. "unbindall" from config.cfg will be reset it
-	for( i = 0; i < ARRAYSIZE( keynames ); i++ )
-		Key_SetBinding( keynames[i].keynum, keynames[i].binding );
+	for( kn = keynames; kn->name; kn++ ) Key_SetBinding( kn->keynum, kn->binding );
 
 	Cvar_RegisterVariable( &osk_enable );
 	Cvar_RegisterVariable( &key_rotate );
@@ -726,31 +731,35 @@ void GAME_EXPORT Key_Event( int key, int down )
 				return; // handled in client.dll
 			}
 			break;
-		default:
-			break;
+		case key_message:
+			Key_Message( key );
+			return;
+		case key_console:
+			if( cls.state == ca_active && !cl.background )
+				Key_SetKeyDest( key_game );
+			else UI_SetActiveMenu( true );
+			return;
+		case key_menu:
+			UI_KeyEvent( key, true );
+			return;
+		default:	return;
 		}
 	}
 
 	if( cls.key_dest == key_menu )
 	{
-		// classic Xash3D menus don't have an extension that tells engine
-		// to enable text input
+		// only non printable keys passed
 		if( !gameui.use_extended_api )
-		{
-			// we don't know if menu wants text input or not
-			// enable it unconditionally
 			Key_EnableTextInput( true, false );
-
-			// pass this key to the menu, if printable
-			if( !host.textmode && down && ( key >= 32 ) && ( key <= 'z' ))
+		//pass printable chars for old menus
+		if( !gameui.use_extended_api && !host.textmode && down && ( key >= 32 ) && ( key <= 'z' ) )
+		{
+			if( Key_IsDown( K_SHIFT ) )
 			{
-				if( Key_IsDown( K_SHIFT ))
-					key += 'A' - 'a';
-
-				UI_CharEvent( key );
+				key += 'A' - 'a';
 			}
+			UI_CharEvent( key );
 		}
-
 		UI_KeyEvent( key, down );
 		return;
 	}
@@ -846,14 +855,11 @@ void GAME_EXPORT Key_ClearStates( void )
 	int	i;
 
 	// don't clear keys during changelevel
-	if( cls.changelevel )
-		return;
+	if( cls.changelevel ) return;
 
 	for( i = 0; i < 256; i++ )
 	{
-		if( i >= K_MOUSE1 && i <= K_MOUSE5 )
-			IN_MouseEvent( i - K_MOUSE1, false );
-		else
+		if( keys[i].down )
 			Key_Event( i, false );
 
 		keys[i].down = 0;
@@ -903,16 +909,17 @@ A helper function if platform input doesn't support text mode properly
 */
 int Key_ToUpper( int keynum )
 {
+	keynum = Q_toupper( keynum );
 	if( keynum == '-' )
-		return '_';
+		keynum = '_';
 	if( keynum == '=' )
-		return '+';
+		keynum = '+';
 	if( keynum == ';' )
-		return ':';
+		keynum = ':';
 	if( keynum == '\'' )
-		return '"';
+		keynum = '"';
 
-	return Q_toupper( keynum );
+	return keynum;
 }
 
 /* On-screen keyboard:
@@ -1097,7 +1104,7 @@ static qboolean OSK_KeyEvent( int key, int down )
 
 /*
 =============
-OSK_EnableTextInput
+Joy_EnableTextInput
 
 Enables built-in IME
 =============

engine/client/mod_dbghulls.c

@@ -470,16 +470,16 @@ out_free:
  * This is a stack of the clipnodes we have traversed
  * "sides" indicates which side we went down each time
  */
-static int	node_stack[MAX_CLIPNODE_DEPTH];
+static mclipnode_t	*node_stack[MAX_CLIPNODE_DEPTH];
 static int	side_stack[MAX_CLIPNODE_DEPTH];
 static uint	node_stack_depth;
 
-static void push_node( int nodenum, int side )
+static void push_node( mclipnode_t *node, int side )
 {
 	if( node_stack_depth == MAX_CLIPNODE_DEPTH )
 		Host_Error( "node stack overflow\n" );
 
-	node_stack[node_stack_depth] = nodenum;
+	node_stack[node_stack_depth] = node;
 	side_stack[node_stack_depth] = side;
 	node_stack_depth++;
 }
@@ -502,27 +502,22 @@ static void free_hull_polys( hullnode_t *hull_polys )
 	}
 }
 
-static void hull_windings_r( hull_t *hull, int nodenum, hullnode_t *polys, hull_model_t *model );
+static void hull_windings_r( hull_t *hull, mclipnode_t *node, hullnode_t *polys, hull_model_t *model );
 
-static void do_hull_recursion( hull_t *hull, int nodenum, int side, hullnode_t *polys, hull_model_t *model )
+static void do_hull_recursion( hull_t *hull, mclipnode_t *node, int side, hullnode_t *polys, hull_model_t *model )
 {
 	winding_t	*w, *next;
-	int childnum;
 
-	if( world.version == QBSP2_VERSION )
-		childnum = hull->clipnodes32[nodenum].children[side];
-	else
-		childnum = hull->clipnodes16[nodenum].children[side];
-
-	if( childnum >= 0 )
+	if( node->children[side] >= 0 )
 	{
-		push_node( nodenum, side );
-		hull_windings_r( hull, childnum, polys, model );
+		mclipnode_t *child = hull->clipnodes + node->children[side];
+		push_node( node, side );
+		hull_windings_r( hull, child, polys, model );
 		pop_node();
 	}
 	else
 	{
-		switch( childnum )
+		switch( node->children[side] )
 		{
 		case CONTENTS_EMPTY:
 		case CONTENTS_WATER:
@@ -547,25 +542,20 @@ static void do_hull_recursion( hull_t *hull, int nodenum, int side, hullnode_t *
 			}
 			break;
 		default:
-			Host_Error( "bad contents: %i\n", childnum );
+			Host_Error( "bad contents: %i\n", node->children[side] );
 			break;
 		}
 	}
 }
 
-static void hull_windings_r( hull_t *hull, int nodenum, hullnode_t *polys, hull_model_t *model )
+static void hull_windings_r( hull_t *hull, mclipnode_t *node, hullnode_t *polys, hull_model_t *model )
 {
-	mplane_t *plane;
+	mplane_t		*plane = hull->planes + node->planenum;
 	hullnode_t	frontlist = LIST_HEAD_INIT( frontlist );
 	hullnode_t	backlist = LIST_HEAD_INIT( backlist );
 	winding_t		*w, *next, *front, *back;
 	int	i;
 
-	if( world.version == QBSP2_VERSION )
-		plane = hull->planes + hull->clipnodes32[nodenum].planenum;
-	else
-		plane = hull->planes + hull->clipnodes16[nodenum].planenum;
-
 	list_for_each_entry_safe( w, next, polys, chain )
 	{
 		// PARANIOA - PAIR CHECK
@@ -611,13 +601,7 @@ static void hull_windings_r( hull_t *hull, int nodenum, hullnode_t *polys, hull_
 
 	for( i = 0; w && i < node_stack_depth; i++ )
 	{
-		mplane_t *p;
-
-		if( world.version == QBSP2_VERSION )
-			p = hull->planes + hull->clipnodes32[node_stack[i]].planenum;
-		else
-			p = hull->planes + hull->clipnodes16[node_stack[i]].planenum;
-
+		mplane_t *p = hull->planes + node_stack[i]->planenum;
 		w = winding_clip( w, p, false, side_stack[i], 0.00001 );
 	}
 
@@ -641,8 +625,8 @@ static void hull_windings_r( hull_t *hull, int nodenum, hullnode_t *polys, hull_
 		Con_Printf( S_WARN "new winding was clipped away!\n" );
 	}
 
-	do_hull_recursion( hull, nodenum, 0, &frontlist, model );
-	do_hull_recursion( hull, nodenum, 1, &backlist, model );
+	do_hull_recursion( hull, node, 0, &frontlist, model );
+	do_hull_recursion( hull, node, 1, &backlist, model );
 }
 
 static void remove_paired_polys( hull_model_t *model )
@@ -671,7 +655,7 @@ static void make_hull_windings( hull_t *hull, hull_model_t *model )
 
 	if( hull->planes != NULL )
 	{
-		hull_windings_r( hull, hull->firstclipnode, &head, model );
+		hull_windings_r( hull, hull->clipnodes + hull->firstclipnode, &head, model );
 		remove_paired_polys( model );
 	}
 	Con_Reportf( "%i hull polys\n", model->num_polys );

engine/client/ref_common.c

@@ -181,11 +181,6 @@ static void pfnCvar_FullSet( const char *var_name, const char *value, int flags
 	Cvar_FullSet( var_name, value, flags | FCVAR_REFDLL );
 }
 
-static int Cmd_AddRefCommand( const char *cmd_name, xcommand_t function, const char *description )
-{
-	return Cmd_AddCommandEx( cmd_name, function, description, CMD_REFDLL, __func__ );
-}
-
 static void pfnStudioEvent( const mstudioevent_t *event, const cl_entity_t *e )
 {
 	clgame.dllFuncs.pfnStudioEvent( event, e );
@@ -300,12 +295,6 @@ static qboolean R_Init_Video_( const int type )
 	return R_Init_Video( type );
 }
 
-static mleaf_t *pfnMod_PointInLeaf( const vec3_t p, mnode_t *node )
-{
-	// FIXME: get rid of this on next RefAPI update
-	return Mod_PointInLeaf( p, node, cl.models[1] );
-}
-
 static const ref_api_t gEngfuncs =
 {
 	pfnEngineGetParm,
@@ -346,7 +335,7 @@ static const ref_api_t gEngfuncs =
 
 	Mod_SampleSizeForFace,
 	Mod_BoxVisible,
-	pfnMod_PointInLeaf,
+	Mod_PointInLeaf,
 	R_DrawWorldHull,
 	R_DrawModelHull,
 
@@ -433,8 +422,6 @@ static const ref_api_t gEngfuncs =
 	&clgame.drawFuncs,
 
 	&g_fsapi,
-
-	R_GetWindowHandle,
 };
 
 static void R_UnloadProgs( void )
@@ -574,7 +561,7 @@ static void R_GetRendererName( char *dest, size_t size, const char *opt )
 	}
 }
 
-static qboolean R_LoadRenderer( const char *refopt, qboolean quiet )
+static qboolean R_LoadRenderer( const char *refopt )
 {
 	string refdll;
 
@@ -585,8 +572,7 @@ static qboolean R_LoadRenderer( const char *refopt, qboolean quiet )
 	if( !R_LoadProgs( refdll ))
 	{
 		R_Shutdown();
-		if( !quiet )
-			Sys_Warn( S_ERROR "Can't initialize %s renderer!\n", refdll );
+		Sys_Warn( S_ERROR "Can't initialize %s renderer!\n", refdll );
 		return false;
 	}
 
@@ -625,7 +611,7 @@ static void SetFullscreenModeFromCommandLine( void )
 static void R_CollectRendererNames( void )
 {
 	// ordering is important!
-	static const char *short_names[] =
+	static const char *shortNames[] =
 	{
 #if XASH_REF_GL_ENABLED
 		"gl",
@@ -648,7 +634,7 @@ static void R_CollectRendererNames( void )
 	};
 
 	// ordering is important here too!
-	static const char *long_names[ARRAYSIZE( short_names )] =
+	static const char *readableNames[ARRAYSIZE( shortNames )] =
 	{
 #if XASH_REF_GL_ENABLED
 		"OpenGL",
@@ -670,9 +656,9 @@ static void R_CollectRendererNames( void )
 #endif
 	};
 
-	ref.num_renderers = ARRAYSIZE( short_names );
-	ref.short_names = short_names;
-	ref.long_names = long_names;
+	ref.numRenderers = ARRAYSIZE( shortNames );
+	ref.shortNames = shortNames;
+	ref.readableNames = readableNames;
 }
 
 qboolean R_Init( void )
@@ -733,44 +719,28 @@ qboolean R_Init( void )
 	requested_cvar[0] = 0;
 
 	if( Sys_GetParmFromCmdLine( "-ref", requested_cmdline ))
-		success = R_LoadRenderer( requested_cmdline, false );
+		success = R_LoadRenderer( requested_cmdline );
 
 	if( !success && COM_CheckString( r_refdll.string ) && Q_stricmp( requested_cmdline, r_refdll.string ))
 	{
 		Q_strncpy( requested_cvar, r_refdll.string, sizeof( requested_cvar ));
-
-		// do not show scary messages to user if renderer set in config cannot be loaded
-		// as game data could be copied from one platform to another, where this renderer
-		// might not be supported (ref_gl on Android for example)
-		success = R_LoadRenderer( requested_cvar, !host_developer.value );
+		success = R_LoadRenderer( requested_cvar );
 	}
 
 	if( !success )
 	{
 		int i;
 
-		for( i = 0; i < ref.num_renderers; i++ )
+		for( i = 0; i < ref.numRenderers && !success; i++ )
 		{
 			// skip renderer that was requested but failed to load
-			if( !Q_strcmp( requested_cmdline, ref.short_names[i] ))
+			if( !Q_strcmp( requested_cmdline, ref.shortNames[i] ))
 				continue;
 
-			if( !Q_strcmp( requested_cvar, ref.short_names[i] ))
+			if( !Q_strcmp( requested_cvar, ref.shortNames[i] ))
 				continue;
 
-			// do not show bruteforcing attempts, however, warn user about falling back
-			// to software mode
-			if( !Q_strcmp( "soft", ref.short_names[i] ) && !host_developer.value )
-				Sys_Warn( "Can't initialize any hardware accelerated renderer. Falling back to software rendering...\n" );
-
-			success = R_LoadRenderer( ref.short_names[i], !host_developer.value );
-
-			if( success )
-			{
-				// remember last valid renderer
-				Cvar_DirectSet( &r_refdll, ref.short_names[i] );
-				break;
-			}
+			success = R_LoadRenderer( ref.shortNames[i] );
 		}
 	}
 

engine/client/ref_common.h

@@ -24,12 +24,12 @@ struct ref_state_s
 {
 	HINSTANCE       hInstance;
 	qboolean        initialized;
-	int             num_renderers;
+	int             numRenderers;
 	ref_interface_t dllFuncs;
 
 	// depends on build configuration
-	const char    **short_names;
-	const char    **long_names;
+	const char    **shortNames;
+	const char    **readableNames;
 };
 
 extern struct ref_state_s ref;

engine/client/s_dsp.c

@@ -312,7 +312,7 @@ static int DLY_Init( int idelay, float delay )
 
 	cur = &rgsxdly[idelay];
 	cur->cdelaysamplesmax = ((int)(delay * idsp_dma_speed) << sxhires) + 1;
-	cur->lpdelayline = (int *)Mem_Calloc( sndpool, cur->cdelaysamplesmax * sizeof( int ));
+	cur->lpdelayline = (int *)Z_Calloc( cur->cdelaysamplesmax * sizeof( int ));
 	cur->xfade = 0;
 
 	// init modulation

engine/client/s_load.c

@@ -107,18 +107,17 @@ S_CreateDefaultSound
 */
 static wavdata_t *S_CreateDefaultSound( void )
 {
-	wavdata_t *sc;
-	uint samples = SOUND_DMA_SPEED;
-	uint channels = 1;
-	uint width = 2;
-	size_t size = samples * width * channels;
+	wavdata_t	*sc;
 
-	sc = Mem_Calloc( sndpool, sizeof( wavdata_t ) + size );
-	sc->width = width;
-	sc->channels = channels;
+	sc = Mem_Calloc( sndpool, sizeof( wavdata_t ));
+
+	sc->width = 2;
+	sc->channels = 1;
+	sc->loopStart = 0;
 	sc->rate = SOUND_DMA_SPEED;
-	sc->samples = samples;
-	sc->size = size;
+	sc->samples = SOUND_DMA_SPEED;
+	sc->size = sc->samples * sc->width * sc->channels;
+	sc->buffer = Mem_Calloc( sndpool, sc->size );
 
 	return sc;
 }

engine/client/s_main.c

@@ -996,7 +996,7 @@ static void S_UpdateAmbientSounds( void )
 	// calc ambient sound levels
 	if( !cl.worldmodel ) return;
 
-	leaf = Mod_PointInLeaf( s_listener.origin, cl.worldmodel->nodes, cl.worldmodel );
+	leaf = Mod_PointInLeaf( s_listener.origin, cl.worldmodel->nodes );
 
 	if( !leaf || !s_ambient_level.value )
 	{
@@ -1207,6 +1207,86 @@ void S_RawSamples( uint samples, uint rate, word width, word channels, const byt
 	S_RawEntSamples( entnum, samples, rate, width, channels, data, snd_vol );
 }
 
+/*
+===================
+S_PositionedRawSamples
+===================
+*/
+void S_StreamAviSamples( void *Avi, int entnum, float fvol, float attn, float synctime )
+{
+	int	bufferSamples;
+	int	fileSamples;
+	byte	raw[MAX_RAW_SAMPLES];
+	float	duration = 0.0f;
+	int	r, fileBytes;
+	rawchan_t	*ch = NULL;
+
+	if( !dma.initialized || s_listener.paused || !CL_IsInGame( ))
+		return;
+
+	if( entnum < 0 || entnum >= GI->max_edicts )
+		return;
+
+	if( !( ch = S_FindRawChannel( entnum, true )))
+		return;
+
+	if( ch->sound_info.rate == 0 )
+	{
+		if( !AVI_GetAudioInfo( Avi, &ch->sound_info ))
+			return; // no audiotrack
+	}
+
+	ch->master_vol = bound( 0, fvol * 255, 255 );
+	ch->dist_mult = (attn / SND_CLIP_DISTANCE);
+
+	// see how many samples should be copied into the raw buffer
+	if( ch->s_rawend < soundtime )
+		ch->s_rawend = soundtime;
+
+	// position is changed, synchronization is lost etc
+	if( fabs( ch->oldtime - synctime ) > s_mixahead.value )
+		ch->sound_info.loopStart = AVI_TimeToSoundPosition( Avi, synctime * 1000 );
+	ch->oldtime = synctime; // keep actual time
+
+	while( ch->s_rawend < soundtime + ch->max_samples )
+	{
+		wavdata_t	*info = &ch->sound_info;
+
+		bufferSamples = ch->max_samples - (ch->s_rawend - soundtime);
+
+		// decide how much data needs to be read from the file
+		fileSamples = bufferSamples * ((float)info->rate / SOUND_DMA_SPEED );
+		if( fileSamples <= 1 ) return; // no more samples need
+
+		// our max buffer size
+		fileBytes = fileSamples * ( info->width * info->channels );
+
+		if( fileBytes > sizeof( raw ))
+		{
+			fileBytes = sizeof( raw );
+			fileSamples = fileBytes / ( info->width * info->channels );
+		}
+
+		// read audio stream
+		r = AVI_GetAudioChunk( Avi, raw, info->loopStart, fileBytes );
+		info->loopStart += r; // advance play position
+
+		if( r < fileBytes )
+		{
+			fileBytes = r;
+			fileSamples = r / ( info->width * info->channels );
+		}
+
+		if( r > 0 )
+		{
+			// add to raw buffer
+			ch->s_rawend = S_RawSamplesStereo( ch->rawsamples, ch->s_rawend, ch->max_samples,
+			fileSamples, info->rate, info->width, info->channels, raw );
+		}
+		else break; // no more samples for this frame
+	}
+}
+
 /*
 ===================
 S_FreeIdleRawChannels
@@ -1864,8 +1944,7 @@ qboolean S_Init( void )
 	Cmd_AddCommand( "play2", S_Play2_f, "playing a group of specified sound files" ); // nehahra stuff
 	Cmd_AddCommand( "playvol", S_PlayVol_f, "playing a specified sound file with specified volume" );
 	Cmd_AddCommand( "stopsound", S_StopSound_f, "stop all sounds" );
-	// HLU SDK have command with the same name
-	Cmd_AddCommandWithFlags( "music", S_Music_f, "starting a background track", CMD_OVERRIDABLE );
+	Cmd_AddCommand( "music", S_Music_f, "starting a background track" );
 	Cmd_AddCommand( "soundlist", S_SoundList_f, "display loaded sounds" );
 	Cmd_AddCommand( "s_info", S_SoundInfo_f, "print sound system information" );
 	Cmd_AddCommand( "s_fade", S_SoundFade_f, "fade all sounds then stop all" );
@@ -1874,15 +1953,14 @@ qboolean S_Init( void )
 	Cmd_AddCommand( "spk", S_SayReliable_f, "reliable play a specified sententce" );
 	Cmd_AddCommand( "speak", S_Say_f, "playing a specified sententce" );
 
-	sndpool = Mem_AllocPool( "Sound Zone" );
 	dma.backendName = "None";
-	if( !SNDDMA_Init( ))
+	if( !SNDDMA_Init( ) )
 	{
 		Con_Printf( "Audio: sound system can't be initialized\n" );
-		Mem_FreePool( &sndpool );
 		return false;
 	}
 
+	sndpool = Mem_AllocPool( "Sound Zone" );
 	soundtime = 0;
 	paintedtime = 0;
 
@@ -1909,8 +1987,7 @@ void S_Shutdown( void )
 	Cmd_RemoveCommand( "play" );
 	Cmd_RemoveCommand( "playvol" );
 	Cmd_RemoveCommand( "stopsound" );
-	if( Cmd_Exists( "music" ))
-		Cmd_RemoveCommand( "music" );
+	Cmd_RemoveCommand( "music" );
 	Cmd_RemoveCommand( "soundlist" );
 	Cmd_RemoveCommand( "s_info" );
 	Cmd_RemoveCommand( "s_fade" );

engine/client/s_stream.c

@@ -16,7 +16,6 @@ GNU General Public License for more details.
 #include "common.h"
 #include "sound.h"
 #include "client.h"
-#include "soundlib.h"
 
 static bg_track_t		s_bgTrack;
 static musicfade_t		musicfade;	// controlled by game dlls
@@ -213,7 +212,7 @@ void S_StreamBackgroundTrack( void )
 
 	while( ch->s_rawend < soundtime + ch->max_samples )
 	{
-		const stream_t *info = s_bgTrack.stream;
+		wavdata_t	*info = FS_StreamInfo( s_bgTrack.stream );
 
 		bufferSamples = ch->max_samples - (ch->s_rawend - soundtime);
 

engine/client/s_vox.c

@@ -557,7 +557,7 @@ static void VOX_ReadSentenceFile_( byte *buf, fs_offset_t size )
 			int index = cszrawsentences;
 			int size = strlen( name ) + strlen( value ) + 2;
 
-			rgpszrawsentence[index] = Mem_Malloc( sndpool, size );
+			rgpszrawsentence[index] = Mem_Malloc( host.mempool, size );
 			memcpy( rgpszrawsentence[index], name, size );
 			rgpszrawsentence[index][size - 1] = 0;
 			cszrawsentences++;

engine/client/sound.h

@@ -114,6 +114,7 @@ typedef struct rawchan_s
 	vec3_t                origin;        // only use if fixed_origin is set
 	volatile uint         s_rawend;
 	float                 oldtime;       // catch time jumps
+	wavdata_t             sound_info;    // advance play position
 	size_t                max_samples;   // buffer length
 	portable_samplepair_t rawsamples[]; // variable sized
 } rawchan_t;
@@ -170,8 +171,6 @@ typedef struct
 	int       source;   // may be game, menu, etc
 } bg_track_t;
 
-typedef int sound_t;
-
 //====================================================================
 
 #define MAX_DYNAMIC_CHANNELS (60 + NUM_AMBIENTS)

engine/client/soundlib/snd_main.c

@@ -29,20 +29,17 @@ static void Sound_Reset( void )
 
 static MALLOC_LIKE( FS_FreeSound, 1 ) wavdata_t *SoundPack( void )
 {
-	wavdata_t *pack = Mem_Malloc( host.soundpool, sizeof( *pack ) + sound.size );
+	wavdata_t	*pack = Mem_Calloc( host.soundpool, sizeof( wavdata_t ));
 
+	pack->buffer = sound.wav;
+	pack->width = sound.width;
+	pack->rate = sound.rate;
+	pack->type = sound.type;
 	pack->size = sound.size;
 	pack->loopStart = sound.loopstart;
 	pack->samples = sound.samples;
-	pack->type = sound.type;
-	pack->flags = sound.flags;
-	pack->rate = sound.rate;
-	pack->width = sound.width;
 	pack->channels = sound.channels;
-	memcpy( pack->buffer, sound.wav, sound.size );
-
-	Mem_Free( sound.wav );
-	sound.wav = NULL;
+	pack->flags = sound.flags;
 
 	return pack;
 }
@@ -56,10 +53,12 @@ loading and unpack to wav any known sound
 */
 wavdata_t *FS_LoadSound( const char *filename, const byte *buffer, size_t size )
 {
-	const char *ext = COM_FileExtension( filename );
-	string loadname;
-	qboolean anyformat = true;
-	const loadwavfmt_t *format;
+	const char	*ext = COM_FileExtension( filename );
+	string		path, loadname;
+	qboolean		anyformat = true;
+	fs_offset_t		filesize = 0;
+	const loadwavfmt_t	*format;
+	byte		*f;
 
 	Sound_Reset(); // clear old sounddata
 	Q_strncpy( loadname, filename, sizeof( loadname ));
@@ -68,7 +67,7 @@ wavdata_t *FS_LoadSound( const char *filename, const byte *buffer, size_t size )
 	{
 		// we needs to compare file extension with list of supported formats
 		// and be sure what is real extension, not a filename with dot
-		for( format = sound.loadformats; format && format->ext; format++ )
+		for( format = sound.loadformats; format && format->formatstring; format++ )
 		{
 			if( !Q_stricmp( format->ext, ext ))
 			{
@@ -84,42 +83,28 @@ wavdata_t *FS_LoadSound( const char *filename, const byte *buffer, size_t size )
 		goto load_internal;
 
 	// now try all the formats in the selected list
-	for( format = sound.loadformats; format && format->ext; format++)
+	for( format = sound.loadformats; format && format->formatstring; format++)
 	{
 		if( anyformat || !Q_stricmp( ext, format->ext ))
 		{
-			qboolean success = false;
-			fs_offset_t filesize = 0;
-			byte *f;
-			string path;
-
-			Q_snprintf( path, sizeof( path ), DEFAULT_SOUNDPATH "%s.%s", loadname, format->ext );
+			Q_snprintf( path, sizeof( path ),
+				format->formatstring, loadname, "", format->ext );
 
 			f = FS_LoadFile( path, &filesize, false );
 			if( f && filesize > 0 )
 			{
-				success = format->loadfunc( path, f, filesize );
-				Mem_Free( f ); // release buffer
+				if( format->loadfunc( path, f, filesize ))
+				{
+					Mem_Free(f); // release buffer
+					return SoundPack(); // loaded
+				}
+				else Mem_Free(f); // release buffer
 			}
-
-			if( success )
-				return SoundPack(); // loaded
-
-			Q_snprintf( path, sizeof( path ), "%s.%s", loadname, format->ext );
-			f = FS_LoadFile( path, &filesize, false );
-			if( f && filesize > 0 )
-			{
-				success = format->loadfunc( path, f, filesize );
-				Mem_Free( f ); // release buffer
-			}
-
-			if( success )
-				return SoundPack();
 		}
 	}
 
 load_internal:
-	for( format = sound.loadformats; format && format->ext; format++ )
+	for( format = sound.loadformats; format && format->formatstring; format++ )
 	{
 		if( anyformat || !Q_stricmp( ext, format->ext ))
 		{
@@ -147,6 +132,7 @@ free WAV buffer
 void FS_FreeSound( wavdata_t *pack )
 {
 	if( !pack ) return;
+	if( pack->buffer ) Mem_Free( pack->buffer );
 	Mem_Free( pack );
 }
 
@@ -160,7 +146,7 @@ open and reading basic info from sound stream
 stream_t *FS_OpenStream( const char *filename )
 {
 	const char	*ext = COM_FileExtension( filename );
-	string		loadname;
+	string		path, loadname;
 	qboolean		anyformat = true;
 	const streamfmt_t	*format;
 	stream_t		*stream = NULL;
@@ -172,7 +158,7 @@ stream_t *FS_OpenStream( const char *filename )
 	{
 		// we needs to compare file extension with list of supported formats
 		// and be sure what is real extension, not a filename with dot
-		for( format = sound.streamformat; format && format->ext; format++ )
+		for( format = sound.streamformat; format && format->formatstring; format++ )
 		{
 			if( !Q_stricmp( format->ext, ext ))
 			{
@@ -184,13 +170,12 @@ stream_t *FS_OpenStream( const char *filename )
 	}
 
 	// now try all the formats in the selected list
-	for( format = sound.streamformat; format && format->ext; format++)
+	for( format = sound.streamformat; format && format->formatstring; format++)
 	{
 		if( anyformat || !Q_stricmp( ext, format->ext ))
 		{
-			string path;
-
-			Q_snprintf( path, sizeof( path ), "%s.%s", loadname, format->ext );
+			Q_snprintf( path, sizeof( path ),
+				format->formatstring, loadname, "", format->ext );
 
 			if(( stream = format->openfunc( path )) != NULL )
 			{
@@ -214,6 +199,33 @@ stream_t *FS_OpenStream( const char *filename )
 	return stream;
 }
 
+/*
+================
+FS_StreamInfo
+
+get basic stream info
+================
+*/
+wavdata_t *FS_StreamInfo( stream_t *stream )
+{
+	static wavdata_t	info;
+
+	if( !stream ) return NULL;
+
+	// fill structure
+	info.loopStart = 0;
+	info.rate = stream->rate;
+	info.width = stream->width;
+	info.channels = stream->channels;
+	info.flags = SOUND_STREAM;
+	info.size = stream->size;
+	info.buffer = NULL;
+	info.samples = 0;	// not actual for streams
+	info.type = stream->type;
+
+	return &info;
+}
+
 /*
 ================
 FS_ReadStream

engine/client/vgui/vgui_draw.c

@@ -25,29 +25,20 @@ GNU General Public License for more details.
 
 #define VGUI_MAX_TEXTURES 1024
 
-typedef struct vgui_reusable_texture_s
-{
-	int gl_texturenum;
-	byte hash[16];
-} vgui_reusable_texture_t;
-
 typedef struct vgui_static_s
 {
 	qboolean initialized;
 	VGUI_DefaultCursor cursor;
 	vguiapi_t dllFuncs;
 
-	vgui_reusable_texture_t *textures;
+	int textures[VGUI_MAX_TEXTURES];
 	int texture_id;
-	int max_textures;
 	int bound_texture;
 	byte color[4];
 	qboolean enable_texture;
 
 	HINSTANCE hInstance;
 
-	poolhandle_t mempool;
-
 	enum VGUI_KeyCode virtualKeyTrans[256];
 } vgui_static_t;
 
@@ -58,16 +49,9 @@ static CVAR_DEFINE_AUTO( vgui_utf8, "0", FCVAR_ARCHIVE, "enable utf-8 support fo
 
 static void GAME_EXPORT VGUI_DrawInit( void )
 {
-	if( vgui.mempool )
-		Mem_EmptyPool( vgui.mempool );
-	else vgui.mempool = Mem_AllocPool( "VGui Support Pool" );
-
-	vgui.textures = NULL;
-
+	memset( vgui.textures, 0, sizeof( vgui.textures ));
 	memset( vgui.color, 0, sizeof( vgui.color ));
-	vgui.texture_id = 0;
-	vgui.bound_texture = 0;
-	vgui.max_textures = 0;
+	vgui.texture_id = vgui.bound_texture = 0;
 	vgui.enable_texture = true;
 }
 
@@ -76,79 +60,28 @@ static void GAME_EXPORT VGUI_DrawShutdown( void )
 	int i;
 
 	for( i = 1; i < vgui.texture_id; i++ )
-		ref.dllFuncs.GL_FreeTexture( vgui.textures[i].gl_texturenum );
-
-	Mem_FreePool( &vgui.mempool );
-	vgui.textures = NULL;
-
-	memset( vgui.color, 0, sizeof( vgui.color ));
-	vgui.texture_id = 0;
-	vgui.bound_texture = 0;
-	vgui.max_textures = 0;
+		ref.dllFuncs.GL_FreeTexture( vgui.textures[i] );
 }
 
 static int GAME_EXPORT VGUI_GenerateTexture( void )
 {
-	// allocate new
-	if( vgui.texture_id + 1 >= vgui.max_textures )
-	{
-		if( vgui.max_textures + VGUI_MAX_TEXTURES >= VGUI_MAX_TEXTURES * VGUI_MAX_TEXTURES )
-		{
-			// in theory it might look up texture that hasn't been bound for a while and
-			// reuse that but it will eventually overwrite some important textures anyway
-			Con_Printf( S_ERROR "%s: Refusing resizing VGUI textures array due to memory leak\n", __func__ );
-			return vgui.texture_id;
-		}
+	if( ++vgui.texture_id >= VGUI_MAX_TEXTURES )
+		Host_Error( "%s: VGUI_MAX_TEXTURES limit exceeded\n", __func__ );
 
-		vgui.max_textures += VGUI_MAX_TEXTURES;
-
-		// this potentially might leak memory if VGUI is used incorrectly!
-		// (like in Cry of Fear)
-		vgui.textures = Mem_Realloc( vgui.mempool, vgui.textures, sizeof( *vgui.textures ) * vgui.max_textures );
-
-		// warn mod developer
-		if( vgui.max_textures >= VGUI_MAX_TEXTURES * 4 )
-			Con_Printf( S_ERROR "%s: Potential memory leak in VGUI code is detected!\n", __func__ );
-	}
-
-	return ++vgui.texture_id;
+	return vgui.texture_id;
 }
 
 static void GAME_EXPORT VGUI_UploadTexture( int id, const char *buffer, int width, int height )
 {
 	rgbdata_t r_image = { 0 };
 	char texName[32];
-	MD5Context_t ctx;
-	byte hash[16];
 
-	if( id <= 0 || id >= vgui.max_textures || width <= 0 || height <= 0 )
+	if( id <= 0 || id >= VGUI_MAX_TEXTURES )
 	{
 		Con_DPrintf( S_ERROR "%s: bad texture %i. Ignored\n", __func__, id );
 		return;
 	}
 
-	// need to do this as some mods tend to upload same texture over and over
-	// exhausing engine-wide limit on textures and leaking vram
-	MD5Init( &ctx );
-	MD5Update( &ctx, buffer, width * height * 4 );
-	MD5Final( hash, &ctx );
-
-	// it's a new texture, try to find a copy
-	if( vgui.textures[id].gl_texturenum == 0 )
-	{
-		int i;
-
-		for( i = 1; i < vgui.texture_id; i++ )
-		{
-			if( vgui.textures[i].gl_texturenum != 0 && !memcmp( vgui.textures[i].hash, hash, sizeof( hash )))
-			{
-				// copy data to new texture id
-				vgui.textures[id] = vgui.textures[i];
-				return;
-			}
-		}
-	}
-
 	Q_snprintf( texName, sizeof( texName ), "*vgui%i", id );
 
 	r_image.width = width;
@@ -158,29 +91,51 @@ static void GAME_EXPORT VGUI_UploadTexture( int id, const char *buffer, int widt
 	r_image.flags = IMAGE_HAS_COLOR|IMAGE_HAS_ALPHA;
 	r_image.buffer = (byte*)buffer;
 
-	vgui.textures[id].gl_texturenum = GL_LoadTextureInternal( texName, &r_image, TF_IMAGE );
-	memcpy( vgui.textures[id].hash, hash, sizeof( hash ));
+	vgui.textures[id] = GL_LoadTextureInternal( texName, &r_image, TF_IMAGE );
 }
 
 static void GAME_EXPORT VGUI_CreateTexture( int id, int width, int height )
 {
-	// nothing uses it, it can be removed
-	Host_Error( "%s: deprecated\n", __func__ );
+	rgbdata_t r_image = { 0 };
+	char texName[32];
 
+	if( id <= 0 || id >= VGUI_MAX_TEXTURES )
+	{
+		Con_DPrintf( S_ERROR "%s: bad texture %i. Ignored\n", __func__, id );
+		return;
+	}
+
+	Q_snprintf( texName, sizeof( texName ), "*vgui%i", id );
+
+	r_image.width = width;
+	r_image.height = height;
+	r_image.type = PF_RGBA_32;
+	r_image.size = width * height * 4;
+	r_image.flags = IMAGE_HAS_COLOR|IMAGE_HAS_ALPHA;
+	r_image.buffer = NULL;
+
+	vgui.textures[id] = GL_LoadTextureInternal( texName, &r_image, TF_IMAGE );
+	vgui.bound_texture = id;
 }
 
 static void GAME_EXPORT VGUI_UploadTextureBlock( int id, int drawX, int drawY, const byte *rgba, int blockWidth, int blockHeight )
 {
-	// nothing uses it, it can be removed
-	Host_Error( "%s: deprecated\n", __func__ );
+	if( id <= 0 || id >= VGUI_MAX_TEXTURES || vgui.textures[id] == 0 )
+	{
+		Con_DPrintf( S_ERROR "%s: bad texture %i. Ignored\n", __func__, id );
+		return;
+	}
+
+	ref.dllFuncs.VGUI_UploadTextureBlock( drawX, drawY, rgba, blockWidth, blockHeight );
+	vgui.bound_texture = id;
 }
 
 static void GAME_EXPORT VGUI_BindTexture( int id )
 {
-	if( id <= 0 || id >= vgui.max_textures || !vgui.textures[id].gl_texturenum )
+	if( id <= 0 || id >= VGUI_MAX_TEXTURES || !vgui.textures[id] )
 		id = 1; // NOTE: same as bogus index 2700 in GoldSrc
 
-	ref.dllFuncs.GL_Bind( XASH_TEXTURE0, vgui.textures[id].gl_texturenum );
+	ref.dllFuncs.GL_Bind( XASH_TEXTURE0, vgui.textures[id] );
 	vgui.bound_texture = id;
 }
 
@@ -189,7 +144,7 @@ static void GAME_EXPORT VGUI_GetTextureSizes( int *w, int *h )
 	int texnum;
 
 	if( vgui.bound_texture )
-		texnum = vgui.textures[vgui.bound_texture].gl_texturenum;
+		texnum = vgui.textures[vgui.bound_texture];
 	else
 		texnum = R_GetBuiltinTexture( REF_DEFAULT_TEXTURE );
 
@@ -232,7 +187,7 @@ static void GAME_EXPORT VGUI_DrawQuad( const vpoint_t *ul, const vpoint_t *lr )
 		t2 = lr->coord[1];
 
 		ref.dllFuncs.Color4ub( vgui.color[0], vgui.color[1], vgui.color[2], vgui.color[3] );
-		ref.dllFuncs.R_DrawStretchPic( x, y, w, h, s1, t1, s2, t2, vgui.textures[vgui.bound_texture].gl_texturenum );
+		ref.dllFuncs.R_DrawStretchPic( x, y, w, h, s1, t1, s2, t2, vgui.textures[vgui.bound_texture] );
 	}
 	else
 	{

engine/common/base_cmd.c

@@ -17,7 +17,7 @@ GNU General Public License for more details.
 #include "base_cmd.h"
 #include "cdll_int.h"
 
-#define HASH_SIZE 64 // 64 * 4 * 4 == 1024 bytes
+#define HASH_SIZE 128 // 128 * 4 * 4 == 2048 bytes
 
 typedef struct base_command_hashmap_s base_command_hashmap_t;
 
@@ -26,11 +26,10 @@ struct base_command_hashmap_s
 	base_command_t         *basecmd; // base command: cvar, alias or command
 	base_command_hashmap_t *next;
 	base_command_type_e     type;    // type for faster searching
-	char                    name[]; // key for searching
+	char                    name[1]; // key for searching
 };
 
 static base_command_hashmap_t *hashed_cmds[HASH_SIZE];
-static poolhandle_t basecmd_pool;
 
 #define BaseCmd_HashKey( x ) COM_HashKey( name, HASH_SIZE )
 
@@ -43,27 +42,11 @@ Find base command in bucket
 */
 static base_command_hashmap_t *BaseCmd_FindInBucket( base_command_hashmap_t *bucket, base_command_type_e type, const char *name )
 {
-	base_command_hashmap_t *i;
+	base_command_hashmap_t *i = bucket;
+	for( ; i && ( i->type != type || Q_stricmp( name, i->name ) ); // filter out
+		 i = i->next );
 
-	for( i = bucket; i != NULL; i = i->next )
-	{
-		int cmp;
-
-		if( i->type != type )
-			continue;
-
-		cmp = Q_stricmp( i->name, name );
-
-		if( cmp < 0 )
-			continue;
-
-		if( cmp > 0 )
-			break;
-
-		return i;
-	}
-
-	return NULL;
+	return i;
 }
 
 /*
@@ -107,31 +90,27 @@ void BaseCmd_FindAll( const char *name, base_command_t **cmd, base_command_t **a
 	base_command_hashmap_t *base = BaseCmd_GetBucket( name );
 	base_command_hashmap_t *i = base;
 
+	ASSERT( cmd && alias && cvar );
+
 	*cmd = *alias = *cvar = NULL;
 
 	for( ; i; i = i->next )
 	{
-		int cmp = Q_stricmp( i->name, name );
-
-		if( cmp < 0 )
-			continue;
-
-		if( cmp > 0 )
-			break;
-
-		switch( i->type )
+		if( !Q_stricmp( i->name, name ) )
 		{
-		case HM_CMD:
-			*cmd = i->basecmd;
-			break;
-		case HM_CMDALIAS:
-			*alias = i->basecmd;
-			break;
-		case HM_CVAR:
-			*cvar = i->basecmd;
-			break;
-		default:
-			break;
+			switch( i->type )
+			{
+			case HM_CMD:
+				*cmd = i->basecmd;
+				break;
+			case HM_CMDALIAS:
+				*alias = i->basecmd;
+				break;
+			case HM_CVAR:
+				*cvar = i->basecmd;
+				break;
+			default: break;
+			}
 		}
 	}
 }
@@ -149,14 +128,14 @@ void BaseCmd_Insert( base_command_type_e type, base_command_t *basecmd, const ch
 	uint hash = BaseCmd_HashKey( name );
 	size_t len = Q_strlen( name );
 
-	elem = Mem_Malloc( basecmd_pool, sizeof( base_command_hashmap_t ) + len + 1 );
+	elem = Z_Malloc( sizeof( base_command_hashmap_t ) + len );
 	elem->basecmd = basecmd;
 	elem->type = type;
 	Q_strncpy( elem->name, name, len + 1 );
 
 	// link the variable in alphanumerical order
 	for( cur = NULL, find = hashed_cmds[hash];
-		  find && Q_stricmp( find->name, elem->name ) < 0;
+		  find && Q_strcmp( find->name, elem->name ) < 0;
 		  cur = find, find = find->next );
 
 	if( cur ) cur->next = elem;
@@ -177,23 +156,9 @@ void BaseCmd_Remove( base_command_type_e type, const char *name )
 	uint hash = BaseCmd_HashKey( name );
 	base_command_hashmap_t *i, *prev;
 
-	for( prev = NULL, i = hashed_cmds[hash]; i != NULL; prev = i, i = i->next )
-	{
-		int cmp;
-
-		if( i->type != type )
-			continue;
-
-		cmp = Q_stricmp( i->name, name );
-
-		if( cmp < 0 )
-			continue;
-
-		if( cmp > 0 )
-			i = NULL;
-
-		break;
-	}
+	for( prev = NULL, i = hashed_cmds[hash]; i &&
+		 ( Q_strcmp( i->name, name ) || i->type != type); // filter out
+		 prev = i, i = i->next );
 
 	if( !i )
 	{
@@ -218,15 +183,9 @@ initialize base command hashmap system
 */
 void BaseCmd_Init( void )
 {
-	basecmd_pool = Mem_AllocPool( "BaseCmd" );
 	memset( hashed_cmds, 0, sizeof( hashed_cmds ) );
 }
 
-void BaseCmd_Shutdown( void )
-{
-	Mem_FreePool( &basecmd_pool );
-}
-
 /*
 ============
 BaseCmd_Stats_f

engine/common/base_cmd.h

@@ -32,7 +32,6 @@ typedef enum base_command_type
 typedef void base_command_t;
 
 void BaseCmd_Init( void );
-void BaseCmd_Shutdown( void );
 base_command_t *BaseCmd_Find( base_command_type_e type, const char *name );
 void BaseCmd_FindAll( const char *name,
 	base_command_t **cmd, base_command_t **alias, base_command_t **cvar );

engine/common/cmd.c

@@ -46,7 +46,6 @@ static cmdalias_t *cmd_alias;
 static uint cmd_condition;
 static int  cmd_condlevel;
 static qboolean cmd_currentCommandIsPrivileged;
-static poolhandle_t cmd_pool;
 
 static void Cmd_ExecuteStringWithPrivilegeCheck( const char *text, qboolean isPrivileged );
 
@@ -143,33 +142,28 @@ void Cbuf_AddFilteredText( const char *text )
 Cbuf_InsertText
 
 Adds command text immediately after the current command
+Adds a \n to the text
 ============
 */
-static void Cbuf_InsertTextToBuffer( cmdbuf_t *buf, const char *text, size_t len, size_t requested_len )
+static void Cbuf_InsertTextToBuffer( cmdbuf_t *buf, const char *text )
 {
-	if(( buf->cursize + requested_len ) >= buf->maxsize )
+	int	l = Q_strlen( text );
+
+	if(( buf->cursize + l ) >= buf->maxsize )
 	{
 		Con_Reportf( S_WARN "%s: overflow\n", __func__ );
 	}
 	else
 	{
-		memmove( buf->data + len, buf->data, buf->cursize );
-		memcpy( buf->data, text, len );
-		buf->cursize += len;
+		memmove( buf->data + l, buf->data, buf->cursize );
+		memcpy( buf->data, text, l );
+		buf->cursize += l;
 	}
 }
 
-void Cbuf_InsertTextLen( const char *text, size_t len, size_t requested_len )
-{
-	// sometimes we need to insert more data than we have
-	// but also prevent overflow
-	Cbuf_InsertTextToBuffer( &cmd_text, text, len, requested_len );
-}
-
 void Cbuf_InsertText( const char *text )
 {
-	size_t l = Q_strlen( text );
-	Cbuf_InsertTextToBuffer( &cmd_text, text, l, l );
+	Cbuf_InsertTextToBuffer( &cmd_text, text );
 }
 
 /*
@@ -269,16 +263,10 @@ Cbuf_Execute
 void Cbuf_Execute( void )
 {
 	Cbuf_ExecuteCommandsFromBuffer( &cmd_text, true, -1 );
-
-	// a1ba: goldsrc limits unprivileged commands per frame to 1 here
+	// a1ba: unlimited commands for filtered buffer per frame
 	// I don't see any sense in restricting that at this moment
 	// but in future we may limit this
-
-	// a1ba: there is little to no sense limit privileged commands in
-	// local game, as client runs server code anyway
-	// do this for singleplayer only though, to make it easier to catch
-	// possible bugs during local multiplayer testing
-	Cbuf_ExecuteCommandsFromBuffer( &filteredcmd_text, SV_Active() && SV_GetMaxClients() == 1, -1 );
+	Cbuf_ExecuteCommandsFromBuffer( &filteredcmd_text, false, -1 );
 }
 
 /*
@@ -433,7 +421,7 @@ static void Cmd_Alias_f( void )
 	{
 		if( !Q_strcmp( s, a->name ))
 		{
-			Mem_Free( a->value );
+			Z_Free( a->value );
 			break;
 		}
 	}
@@ -442,7 +430,7 @@ static void Cmd_Alias_f( void )
 	{
 		cmdalias_t	*cur, *prev;
 
-		a = Mem_Malloc( cmd_pool, sizeof( cmdalias_t ));
+		a = Z_Malloc( sizeof( cmdalias_t ));
 
 		Q_strncpy( a->name, s, sizeof( a->name ));
 
@@ -470,7 +458,7 @@ static void Cmd_Alias_f( void )
 	}
 
 	Q_strncat( cmd, "\n", sizeof( cmd ));
-	a->value = copystringpool( cmd_pool, cmd );
+	a->value = copystring( cmd );
 }
 
 /*
@@ -524,14 +512,14 @@ static void Cmd_UnAlias_f ( void )
 
 =============================================================================
 */
-struct cmd_s
+typedef struct cmd_s
 {
 	struct cmd_s	*next;
 	char		*name;
 	xcommand_t	function;
 	int		flags;
-	char		desc[];
-};
+	char		*desc;
+} cmd_t;
 
 static int		cmd_argc;
 static const char	*cmd_args = NULL;
@@ -637,7 +625,7 @@ void Cmd_TokenizeString( const char *text )
 
 	// clear the args from the last string
 	for( i = 0; i < cmd_argc; i++ )
-		Mem_Free( cmd_argv[i] );
+		Z_Free( cmd_argv[i] );
 
 	cmd_argc = 0; // clear previous args
 	cmd_args = NULL;
@@ -671,7 +659,7 @@ void Cmd_TokenizeString( const char *text )
 
 		if( cmd_argc < MAX_CMD_TOKENS )
 		{
-			cmd_argv[cmd_argc] = copystringpool( cmd_pool, cmd_token );
+			cmd_argv[cmd_argc] = copystring( cmd_token );
 			cmd_argc++;
 		}
 	}
@@ -682,10 +670,10 @@ void Cmd_TokenizeString( const char *text )
 Cmd_AddCommandEx
 ============
 */
-int Cmd_AddCommandEx( const char *cmd_name, xcommand_t function, const char *cmd_desc, int iFlags, const char *funcname )
+static int Cmd_AddCommandEx( const char *funcname, const char *cmd_name, xcommand_t function,
+	const char *cmd_desc, int iFlags )
 {
-	cmd_t  *cmd, *cur, *prev;
-	size_t desc_len;
+	cmd_t	*cmd, *cur, *prev;
 
 	if( !COM_CheckString( cmd_name ))
 	{
@@ -700,35 +688,17 @@ int Cmd_AddCommandEx( const char *cmd_name, xcommand_t function, const char *cmd
 		return 0;
 	}
 
-	// fail if the command already exists and cannot be overriden
-	cmd = Cmd_Exists( cmd_name );
-	if( cmd )
+	// fail if the command already exists
+	if( Cmd_Exists( cmd_name ))
 	{
-		// some mods register commands that share the name with some engine's commands
-		// when they aren't critical to keep engine running, we can let mods to override them
-		// unfortunately, we lose original command this way
-		if( FBitSet( cmd->flags, CMD_OVERRIDABLE ))
-		{
-			desc_len = Q_strlen( cmd->desc ) + 1;
-			Q_strncpy( cmd->desc, cmd_desc, desc_len );
-			cmd->function = function;
-			cmd->flags = iFlags;
-
-			Con_DPrintf( S_WARN "%s: %s already defined but is allowed to be overriden\n", funcname, cmd_name );
-			return 1;
-		}
-		else
-		{
-			Con_DPrintf( "%s%s: %s already defined\n", cmd->function == function ? S_WARN : S_ERROR, funcname, cmd_name );
-			return 0;
-		}
+		Con_DPrintf( S_ERROR "%s: %s already defined\n", funcname, cmd_name );
+		return 0;
 	}
 
 	// use a small malloc to avoid zone fragmentation
-	desc_len = Q_strlen( cmd_desc ) + 1;
-	cmd = Mem_Malloc( cmd_pool, sizeof( cmd_t ) + desc_len );
-	cmd->name = copystringpool( cmd_pool, cmd_name );
-	Q_strncpy( cmd->desc, cmd_desc, desc_len );
+	cmd = Z_Malloc( sizeof( cmd_t ) );
+	cmd->name = copystring( cmd_name );
+	cmd->desc = copystring( cmd_desc );
 	cmd->function = function;
 	cmd->flags = iFlags;
 
@@ -746,6 +716,75 @@ int Cmd_AddCommandEx( const char *cmd_name, xcommand_t function, const char *cmd
 	return 1;
 }
 
+/*
+============
+Cmd_AddCommand
+============
+*/
+void Cmd_AddCommand( const char *cmd_name, xcommand_t function, const char *cmd_desc )
+{
+	Cmd_AddCommandEx( __func__, cmd_name, function, cmd_desc, 0 );
+}
+
+
+/*
+============
+Cmd_AddRestrictedCommand
+============
+*/
+void Cmd_AddRestrictedCommand( const char *cmd_name, xcommand_t function, const char *cmd_desc )
+{
+	Cmd_AddCommandEx( __func__, cmd_name, function, cmd_desc, CMD_PRIVILEGED );
+}
+
+/*
+============
+Cmd_AddServerCommand
+============
+*/
+void GAME_EXPORT Cmd_AddServerCommand( const char *cmd_name, xcommand_t function )
+{
+	Cmd_AddCommandEx( __func__, cmd_name, function, "server command", CMD_SERVERDLL );
+}
+
+/*
+============
+Cmd_AddClientCommand
+============
+*/
+int GAME_EXPORT Cmd_AddClientCommand( const char *cmd_name, xcommand_t function )
+{
+	int flags = CMD_CLIENTDLL;
+
+	// a1ba: try to mitigate outdated client.dll vulnerabilities
+	if( !Q_stricmp( cmd_name, "motd_write" ))
+	{
+		flags |= CMD_PRIVILEGED;
+	}
+
+	return Cmd_AddCommandEx( __func__, cmd_name, function, "client command", flags );
+}
+
+/*
+============
+Cmd_AddGameUICommand
+============
+*/
+int GAME_EXPORT Cmd_AddGameUICommand( const char *cmd_name, xcommand_t function )
+{
+	return Cmd_AddCommandEx( __func__, cmd_name, function, "gameui command", CMD_GAMEUIDLL );
+}
+
+/*
+============
+Cmd_AddRefCommand
+============
+*/
+int Cmd_AddRefCommand( const char *cmd_name, xcommand_t function, const char *description )
+{
+	return Cmd_AddCommandEx( __func__, cmd_name, function, description, CMD_REFDLL );
+}
+
 /*
 ============
 Cmd_RemoveCommand
@@ -775,6 +814,9 @@ void GAME_EXPORT Cmd_RemoveCommand( const char *cmd_name )
 			if( cmd->name )
 				Mem_Free( cmd->name );
 
+			if( cmd->desc )
+				Mem_Free( cmd->desc );
+
 			Mem_Free( cmd );
 			return;
 		}
@@ -811,18 +853,19 @@ void Cmd_LookupCmds( void *buffer, void *ptr, setpair_t callback )
 Cmd_Exists
 ============
 */
-cmd_t *Cmd_Exists( const char *cmd_name )
+qboolean Cmd_Exists( const char *cmd_name )
 {
 #if defined(XASH_HASHED_VARS)
-	return BaseCmd_Find( HM_CMD, cmd_name );
+	return BaseCmd_Find( HM_CMD, cmd_name ) != NULL;
 #else
 	cmd_t	*cmd;
+
 	for( cmd = cmd_functions; cmd; cmd = cmd->next )
 	{
 		if( !Q_strcmp( cmd_name, cmd->name ))
-			return cmd;
+			return true;
 	}
-	return NULL;
+	return false;
 #endif
 }
 
@@ -1015,10 +1058,9 @@ static void Cmd_ExecuteStringWithPrivilegeCheck( const char *text, qboolean isPr
 
 		if( a )
 		{
-			size_t len = Q_strlen( a->value );
 			Cbuf_InsertTextToBuffer(
 				isPrivileged ? &cmd_text : &filteredcmd_text,
-				a->value, len, len );
+				a->value );
 			return;
 		}
 	}
@@ -1202,6 +1244,7 @@ void Cmd_Unlink( int group )
 		*prev = cmd->next;
 
 		if( cmd->name ) Mem_Free( cmd->name );
+		if( cmd->desc ) Mem_Free( cmd->desc );
 
 		Mem_Free( cmd );
 		count++;
@@ -1339,7 +1382,6 @@ Cmd_Init
 */
 void Cmd_Init( void )
 {
-	cmd_pool = Mem_AllocPool( "Console Commands" );
 	cmd_functions = NULL;
 	cmd_condition = 0;
 	cmd_alias = NULL;
@@ -1366,11 +1408,6 @@ void Cmd_Init( void )
 #endif
 }
 
-void Cmd_Shutdown( void )
-{
-	Mem_FreePool( &cmd_pool );
-}
-
 #if XASH_ENGINE_TESTS
 #include "tests.h"
 

engine/common/com_strings.h

@@ -72,6 +72,8 @@ GNU General Public License for more details.
 
 #define CVAR_GLCONFIG_DESCRIPTION	"enable or disable %s"
 
+#define DEFAULT_BSP_BUILD_ERROR	"%s can't be loaded in this build. Please rebuild engine with enabled SUPPORT_BSP2_FORMAT\n"
+
 #define DEFAULT_UPDATE_PAGE "https://github.com/FWGS/xash3d-fwgs/releases/latest"
 
 #define XASH_ENGINE_NAME "Xash3D FWGS"

engine/common/common.c

@@ -251,7 +251,7 @@ static void LZSS_BuildHash( lzss_state_t *state, const byte *source )
 {
 	lzss_list_t	*list;
 	lzss_node_t	*node;
-	unsigned int	targetindex = (uintptr_t)source & ( state->window_size - 1 );
+	unsigned int	targetindex = (uint)source & ( state->window_size - 1 );
 
 	node = &state->hash_node[targetindex];
 
@@ -612,7 +612,7 @@ COM_Nibble
 Returns the 4 bit nibble for a hex character
 ==================
 */
-byte COM_Nibble( char c )
+static byte COM_Nibble( char c )
 {
 	if(( c >= '0' ) && ( c <= '9' ))
 	{
@@ -900,7 +900,7 @@ float GAME_EXPORT pfnTime( void )
 qboolean COM_IsSafeFileToDownload( const char *filename )
 {
 	char		lwrfilename[4096];
-	const char	*last;
+	const char	*first, *last;
 	const char	*ext;
 	size_t	len;
 	int		i;
@@ -934,27 +934,25 @@ qboolean COM_IsSafeFileToDownload( const char *filename )
 		return true;
 	}
 
-	for( i = 0; i < len; i++ )
-	{
-		if( !isprint( filename[i] ))
-			return false;
-	}
-
 	Q_strnlwr( filename, lwrfilename, sizeof( lwrfilename ));
 	ext = COM_FileExtension( lwrfilename );
 
-	if( Q_strpbrk( lwrfilename, "\\:~" ) || Q_strstr( lwrfilename, ".." ))
+	if( Q_strpbrk( lwrfilename, "\\:~" ) || Q_strstr( lwrfilename, ".." ) )
 		return false;
 
 	if( lwrfilename[0] == '/' )
 		return false;
 
+	first = Q_strchr( lwrfilename, '.' );
 	last = Q_strrchr( lwrfilename, '.' );
 
-	if( last == NULL )
+	if( first == NULL || last == NULL )
 		return false;
 
-	if( Q_strlen( last ) != 4 )
+	if( first != last )
+		return false;
+
+	if( Q_strlen( first ) != 4 )
 		return false;
 
 	for( i = 0; i < ARRAYSIZE( file_exts ); i++ )
@@ -1133,7 +1131,6 @@ void Test_RunCommon( void )
 {
 	Msg( "Checking COM_IsSafeFileToDownload...\n" );
 
-	TASSERT_EQi( COM_IsSafeFileToDownload( "models/bsg_props/[hl-lab.ru]bush.mdl" ), true );
 	TASSERT_EQi( COM_IsSafeFileToDownload( "!MD5AAB5E8B307672DA86FBD10AC302BC732" ), true );
 	TASSERT_EQi( COM_IsSafeFileToDownload( "!MD56f1ffd8c96bd64c9c27955309f6ecfe6" ), false );
 	TASSERT_EQi( COM_IsSafeFileToDownload( "!MD5AAB5E8B307672DA86FBD10AC302B.exe" ), false );

engine/common/common.h

@@ -76,14 +76,23 @@ XASH SPECIFIC			- sort of hack that works only in Xash3D not in GoldSrc
 
 #define HACKS_RELATED_HLMODS		// some HL-mods works differently under Xash and can't be fixed without some hacks at least at current time
 
-enum dev_level_e
+enum
 {
 	DEV_NONE = 0,
 	DEV_NORMAL,
 	DEV_EXTENDED
 };
 
-typedef enum instance_e
+enum
+{
+	D_INFO = 1,	// "-dev 1", shows various system messages
+	D_WARN,		// "-dev 2", shows not critical system warnings
+	D_ERROR,		// "-dev 3", shows critical warnings
+	D_REPORT,		// "-dev 4", special case for game reports
+	D_NOTE		// "-dev 5", show system notifications for engine developers
+};
+
+typedef enum
 {
 	HOST_NORMAL,	// listen server, singleplayer
 	HOST_DEDICATED,
@@ -99,14 +108,14 @@ typedef enum instance_e
 #include "com_model.h"
 #include "com_strings.h"
 #include "crtlib.h"
-#define FSCALLBACK_OVERRIDE_OPEN
-#define FSCALLBACK_OVERRIDE_LOADFILE
-#define FSCALLBACK_OVERRIDE_MALLOC_LIKE
-#include "fscallback.h"
 #include "cvar.h"
 #include "con_nprint.h"
 #include "crclib.h"
 #include "ref_api.h"
+#define FSCALLBACK_OVERRIDE_OPEN
+#define FSCALLBACK_OVERRIDE_LOADFILE
+#define FSCALLBACK_OVERRIDE_MALLOC_LIKE
+#include "fscallback.h"
 
 // PERFORMANCE INFO
 #define MIN_FPS         20.0f    // host minimum fps value for maxfps.
@@ -137,11 +146,6 @@ typedef enum instance_e
 #define MAX_STATIC_ENTITIES	32	// static entities that moved on the client when level is spawn
 #endif
 
-#define MAX_SERVERINFO_STRING 512  // server handles too many settings. expand to 1024?
-#define MAX_PRINT_MSG         8192 // how many symbols can handle single call of Con_Printf or Con_DPrintf
-#define MAX_TOKEN             2048 // parse token length
-#define MAX_USERMSG_LENGTH    2048 // don't modify it's relies on a client-side definitions
-
 #define GameState		(&host.game)
 
 #define FORCE_DRAW_VERSION_TIME 5.0 // draw version for 5 seconds
@@ -167,11 +171,6 @@ extern convar_t	cl_filterstuffcmd;
 extern convar_t	rcon_password;
 extern convar_t	hpk_custom_file;
 extern convar_t	con_gamemaps;
-extern convar_t fs_mount_lv;
-extern convar_t fs_mount_hd;
-extern convar_t fs_mount_addon;
-extern convar_t fs_mount_l10n;
-extern convar_t ui_language; // historically used for UI, but now controls mounted localization directory
 
 #define Mod_AllowMaterials() ( host_allow_materials.value != 0.0f && !FBitSet( host.features, ENGINE_DISABLE_HDTEXTURES ))
 
@@ -190,7 +189,7 @@ GAMEINFO stuff
 internal shared gameinfo structure (readonly for engine parts)
 ========================================================================
 */
-typedef enum host_status_e
+typedef enum
 {
 	HOST_INIT = 0,	// initalize operations
 	HOST_FRAME,	// host running
@@ -201,7 +200,7 @@ typedef enum host_status_e
 	HOST_CRASHED	// an exception handler called
 } host_status_t;
 
-typedef enum host_state_e
+typedef enum
 {
 	STATE_RUNFRAME = 0,
 	STATE_LOAD_LEVEL,
@@ -210,7 +209,7 @@ typedef enum host_state_e
 	STATE_GAME_SHUTDOWN,
 } host_state_t;
 
-typedef struct game_status_e
+typedef struct
 {
 	host_state_t	curstate;
 	host_state_t	nextstate;
@@ -221,7 +220,7 @@ typedef struct game_status_e
 	qboolean		newGame;		// unload the server.dll before start a new map
 } game_status_t;
 
-typedef enum keydest_e
+typedef enum
 {
 	key_console = 0,
 	key_game,
@@ -229,7 +228,7 @@ typedef enum keydest_e
 	key_message
 } keydest_t;
 
-typedef enum rdtype_e
+typedef enum
 {
 	RD_NONE = 0,
 	RD_CLIENT,
@@ -239,7 +238,7 @@ typedef enum rdtype_e
 #include "net_ws.h"
 
 // console field
-typedef struct field_e
+typedef struct
 {
 	string		buffer;
 	int		cursor;
@@ -257,7 +256,7 @@ typedef struct host_redirect_s
 	int      lines;
 } host_redirect_t;
 
-typedef struct soundlist_e
+typedef struct
 {
 	char		name[MAX_QPATH];
 	short		entnum;
@@ -298,10 +297,11 @@ typedef struct host_parm_s
 
 	host_status_t status;           // global host state
 	game_status_t game;             // game manager
-	instance_t    type;             // running at
+	uint          type;             // running at
 	poolhandle_t  mempool;          // static mempool for misc allocations
 	poolhandle_t  imagepool;        // imagelib mempool
 	poolhandle_t  soundpool;        // soundlib mempool
+	string        finalmsg;         // server shutdown final message
 	string        downloadfile;     // filename to be downloading
 	int           downloadcount;    // how many files remain to downloading
 	char          deferred_cmd[128];// deferred commands
@@ -342,6 +342,7 @@ typedef struct host_parm_s
 	qboolean apply_game_config;   // when true apply only to game cvars and ignore all other commands
 	qboolean apply_opengl_config; // when true apply only to opengl cvars and ignore all other commands
 	qboolean config_executed;     // a bit who indicated was config.cfg already executed e.g. from valve.rc
+	qboolean crashed;             // set to true if crashed
 #if XASH_DLL_LOADER
 	qboolean enabledll;
 #endif
@@ -357,18 +358,16 @@ typedef struct host_parm_s
 	int      window_center_y;
 	string   gamedll;
 	string   clientlib;
-	string   menulib;
 } host_parm_t;
 
 extern host_parm_t	host;
 
-#define CMD_SERVERDLL   BIT( 0 ) // added by server.dll
-#define CMD_CLIENTDLL   BIT( 1 ) // added by client.dll
-#define CMD_GAMEUIDLL   BIT( 2 ) // added by GameUI.dll
-#define CMD_PRIVILEGED  BIT( 3 ) // only available in privileged mode
-#define CMD_FILTERABLE  BIT( 4 ) // filtered in unprivileged mode if cl_filterstuffcmd is 1
-#define CMD_REFDLL      BIT( 5 ) // added by ref.dll
-#define CMD_OVERRIDABLE BIT( 6 ) // can be removed by DLLs if name matches
+#define CMD_SERVERDLL	BIT( 0 )		// added by server.dll
+#define CMD_CLIENTDLL	BIT( 1 )		// added by client.dll
+#define CMD_GAMEUIDLL	BIT( 2 )		// added by GameUI.dll
+#define CMD_PRIVILEGED	BIT( 3 )		// only available in privileged mode
+#define CMD_FILTERABLE  BIT( 4 )		// filtered in unprivileged mode if cl_filterstuffcmd is 1
+#define CMD_REFDLL	BIT( 5 )		// added by ref.dll
 
 typedef void (*xcommand_t)( void );
 
@@ -415,19 +414,15 @@ byte *FS_LoadFile( const char *path, fs_offset_t *filesizeptr, qboolean gamediro
 	MALLOC_LIKE( _Mem_Free, 1 ) WARN_UNUSED_RESULT;
 byte *FS_LoadDirectFile( const char *path, fs_offset_t *filesizeptr )
 	MALLOC_LIKE( _Mem_Free, 1 ) WARN_UNUSED_RESULT;
-void FS_Rescan_f( void );
-void FS_CheckConfig( void );
 
 //
 // cmd.c
 //
-typedef struct cmd_s cmd_t;
 void Cbuf_Clear( void );
 void Cbuf_AddText( const char *text );
 void Cbuf_AddTextf( const char *text, ... ) FORMAT_CHECK( 1 );
 void Cbuf_AddFilteredText( const char *text );
 void Cbuf_InsertText( const char *text );
-void Cbuf_InsertTextLen( const char *text, size_t len, size_t requested_len );
 void Cbuf_ExecStuffCmds( void );
 void Cbuf_Execute (void);
 qboolean Cmd_CurrentCommandIsPrivileged( void );
@@ -435,27 +430,15 @@ int Cmd_Argc( void );
 const char *Cmd_Args( void ) RETURNS_NONNULL;
 const char *Cmd_Argv( int arg ) RETURNS_NONNULL;
 void Cmd_Init( void );
-void Cmd_Shutdown( void );
 void Cmd_Unlink( int group );
-int Cmd_AddCommandEx( const char *cmd_name, xcommand_t function, const char *cmd_desc, int flags, const char *funcname );
-
-static inline int Cmd_AddCommand( const char *cmd_name, xcommand_t function, const char *cmd_desc )
-{
-	return Cmd_AddCommandEx( cmd_name, function, cmd_desc, 0, __func__ );
-}
-
-static inline int Cmd_AddRestrictedCommand( const char *cmd_name, xcommand_t function, const char *cmd_desc )
-{
-	return Cmd_AddCommandEx( cmd_name, function, cmd_desc, CMD_PRIVILEGED, __func__ );
-}
-
-static inline int Cmd_AddCommandWithFlags( const char *cmd_name, xcommand_t function, const char *cmd_desc, int flags )
-{
-	return Cmd_AddCommandEx( cmd_name, function, cmd_desc, flags, __func__ );
-}
-
+void Cmd_AddCommand( const char *cmd_name, xcommand_t function, const char *cmd_desc );
+void Cmd_AddRestrictedCommand( const char *cmd_name, xcommand_t function, const char *cmd_desc );
+void Cmd_AddServerCommand( const char *cmd_name, xcommand_t function );
+int Cmd_AddClientCommand( const char *cmd_name, xcommand_t function );
+int Cmd_AddGameUICommand( const char *cmd_name, xcommand_t function );
+int Cmd_AddRefCommand( const char *cmd_name, xcommand_t function, const char *description );
 void Cmd_RemoveCommand( const char *cmd_name );
-cmd_t *Cmd_Exists( const char *cmd_name );
+qboolean Cmd_Exists( const char *cmd_name );
 void Cmd_LookupCmds( void *buffer, void *ptr, setpair_t callback );
 int Cmd_ListMaps( search_t *t , char *lastmapname, size_t len );
 void Cmd_TokenizeString( const char *text );
@@ -494,7 +477,7 @@ internal sound format
 typically expanded to wav buffer
 ========================================================================
 */
-typedef enum sndformat_e
+typedef enum
 {
 	WF_UNKNOWN = 0,
 	WF_PCMDATA,
@@ -505,7 +488,7 @@ typedef enum sndformat_e
 } sndformat_t;
 
 // wavdata output flags
-typedef enum sndFlags_e
+typedef enum
 {
 	// wavdata->flags
 	SOUND_LOOPED	= BIT( 0 ),	// this is looped sound (contain cue markers)
@@ -515,29 +498,29 @@ typedef enum sndFlags_e
 	SOUND_RESAMPLE	= BIT( 12 ),	// resample sound to specified rate
 } sndFlags_t;
 
-typedef struct wavdata_s
+typedef struct
 {
-	size_t  size;      // for bounds checking
+	word    rate;      // num samples per second (e.g. 11025 - 11 khz)
+	byte    width;     // resolution - bum bits divided by 8 (8 bit is 1, 16 bit is 2)
+	byte    channels;  // num channels (1 - mono, 2 - stereo)
 	uint    loopStart; // offset at this point sound will be looping while playing more than only once
 	uint    samples;   // total samplecount in wav
 	uint    type;      // compression type
 	uint    flags;     // misc sound flags
-	word    rate;      // num samples per second (e.g. 11025 - 11 khz)
-	byte    width;     // resolution - bum bits divided by 8 (8 bit is 1, 16 bit is 2)
-	byte    channels;  // num channels (1 - mono, 2 - stereo)
-	byte    buffer[];  // sound buffer
+	byte   *buffer;    // sound buffer
+	size_t  size;      // for bounds checking
 } wavdata_t;
 
 //
 // soundlib
 //
-typedef struct stream_s stream_t;
 void Sound_Init( void );
 void Sound_Shutdown( void );
 void FS_FreeSound( wavdata_t *pack );
 void FS_FreeStream( stream_t *stream );
 wavdata_t *FS_LoadSound( const char *filename, const byte *buffer, size_t size ) MALLOC_LIKE( FS_FreeSound, 1 ) WARN_UNUSED_RESULT;
 stream_t *FS_OpenStream( const char *filename ) MALLOC_LIKE( FS_FreeStream, 1 ) WARN_UNUSED_RESULT;
+wavdata_t *FS_StreamInfo( stream_t *stream );
 int FS_ReadStream( stream_t *stream, int bytes, void *buffer );
 int FS_SetStreamPos( stream_t *stream, int newpos );
 int FS_GetStreamPos( stream_t *stream );
@@ -551,7 +534,7 @@ qboolean Sound_SupportedFileFormat( const char *fileext );
 typedef void( *pfnChangeGame )( const char *progname );
 
 qboolean Host_IsQuakeCompatible( void );
-void Host_ShutdownWithReason( const char *reason );
+void EXPORT Host_Shutdown( void );
 int EXPORT Host_Main( int argc, char **argv, const char *progname, int bChangeGame, pfnChangeGame func );
 void Host_EndGame( qboolean abort, const char *message, ... ) FORMAT_CHECK( 2 );
 void Host_AbortCurrentFrame( void ) NORETURN;
@@ -559,11 +542,11 @@ void Host_WriteServerConfig( const char *name );
 void Host_WriteOpenGLConfig( void );
 void Host_WriteVideoConfig( void );
 void Host_WriteConfig( void );
+void Host_ShutdownServer( void );
 void Host_Error( const char *error, ... ) FORMAT_CHECK( 1 );
 void Host_ValidateEngineFeatures( uint32_t mask, uint32_t features );
 void Host_Frame( double time );
 void Host_Credits( void );
-void Host_ExitInMain( void );
 
 //
 // host_state.c
@@ -582,19 +565,11 @@ CLIENT / SERVER SYSTEMS
 
 ==============================================================
 */
-#if !XASH_DEDICATED
 void CL_Init( void );
 void CL_Shutdown( void );
 void Host_ClientBegin( void );
 void Host_ClientFrame( void );
 int CL_Active( void );
-#else
-static inline void CL_Init( void ) { }
-static inline void CL_Shutdown( void ) { }
-static inline void Host_ClientBegin( void ) { Cbuf_Execute(); }
-static inline void Host_ClientFrame( void ) { }
-static inline int CL_Active( void ) { return 0; }
-#endif
 
 void SV_Init( void );
 void SV_Shutdown( const char *finalmsg );
@@ -611,7 +586,6 @@ qboolean SV_Active( void );
 */
 char *COM_MemFgets( byte *pMemFile, int fileSize, int *filePos, char *pBuffer, int bufferSize );
 void COM_HexConvert( const char *pszInput, int nInputLength, byte *pOutput );
-byte COM_Nibble( char c );
 int COM_SaveFile( const char *filename, const void *data, int len );
 byte *COM_LoadFileForMe( const char *filename, int *pLength ) MALLOC_LIKE( free, 1 );
 qboolean COM_IsSafeFileToDownload( const char *filename );
@@ -632,7 +606,6 @@ int pfnNumberOfEntities( void );
 int pfnIsInGame( void );
 float pfnTime( void );
 #define copystring( s ) _copystring( host.mempool, s, __FILE__, __LINE__ )
-#define copystringpool( pool, s ) _copystring( pool, s, __FILE__, __LINE__ )
 #define SV_CopyString( s ) _copystring( svgame.stringspool, s, __FILE__, __LINE__ )
 #define freestring( s ) if( s != NULL ) { Mem_Free( s ); s = NULL; }
 char *_copystring( poolhandle_t mempool, const char *s, const char *filename, int fileline );
@@ -683,7 +656,6 @@ int CSCR_WriteGameCVars( file_t *cfg, const char *scriptfilename );
 //
 // hpak.c
 //
-const char *COM_ResourceTypeFromIndex( int index );
 void HPAK_Init( void );
 qboolean HPAK_GetDataPointer( const char *filename, struct resource_s *pRes, byte **buffer, int *size );
 qboolean HPAK_ResourceForHash( const char *filename, byte *hash, struct resource_s *pRes );
@@ -717,32 +689,13 @@ typedef enum connprotocol_e
 struct physent_s;
 struct sv_client_s;
 typedef struct sizebuf_s sizebuf_t;
-int SV_GetMaxClients( void );
-
-#if !XASH_DEDICATED
-qboolean CL_Initialized( void );
 qboolean CL_IsInGame( void );
 qboolean CL_IsInConsole( void );
 qboolean CL_IsIntermission( void );
-qboolean CL_DisableVisibility( void );
-qboolean CL_IsRecordDemo( void );
-qboolean CL_IsPlaybackDemo( void );
-qboolean UI_CreditsActive( void );
-int CL_GetMaxClients( void );
-#else
-static inline qboolean CL_Initialized( void ) { return false; }
-static inline qboolean CL_IsInGame( void ) { return true; } // always true for dedicated
-static inline qboolean CL_IsInConsole( void ) { return false; }
-static inline qboolean CL_IsIntermission( void ) { return false; }
-static inline qboolean CL_DisableVisibility( void ) { return false; }
-static inline qboolean CL_IsRecordDemo( void ) { return false; }
-static inline qboolean CL_IsPlaybackDemo( void ) { return false; }
-static inline qboolean UI_CreditsActive( void ) { return false; }
-static inline int CL_GetMaxClients( void ) { return SV_GetMaxClients(); }
-#endif
-
+qboolean CL_Initialized( void );
 char *CL_Userinfo( void );
 void CL_CharEvent( int key );
+qboolean CL_DisableVisibility( void );
 byte *COM_LoadFile( const char *filename, int usehunk, int *pLength ) MALLOC_LIKE( free, 1 );
 struct cmd_s *Cmd_GetFirstFunctionHandle( void );
 struct cmd_s *Cmd_GetNextFunctionHandle( struct cmd_s *cmd );
@@ -760,7 +713,13 @@ const char *CL_MsgInfo( int cmd );
 void SV_DrawDebugTriangles( void );
 void SV_DrawOrthoTriangles( void );
 double CL_GetDemoFramerate( void );
+qboolean UI_CreditsActive( void );
 void CL_StopPlayback( void );
+int CL_GetMaxClients( void );
+int SV_GetMaxClients( void );
+qboolean CL_IsRecordDemo( void );
+qboolean CL_IsTimeDemo( void );
+qboolean CL_IsPlaybackDemo( void );
 qboolean SV_Initialized( void );
 void CL_ProcessFile( qboolean successfully_received, const char *filename );
 int SV_GetSaveComment( const char *savename, char *comment );
@@ -790,7 +749,7 @@ void Con_NPrintf( int idx, const char *fmt, ... ) FORMAT_CHECK( 2 );
 void Con_NXPrintf( con_nprint_t *info, const char *fmt, ... ) FORMAT_CHECK( 2 );
 void UI_NPrintf( int idx, const char *fmt, ... ) FORMAT_CHECK( 2 );
 void UI_NXPrintf( con_nprint_t *info, const char *fmt, ... ) FORMAT_CHECK( 2 );
-const char *Info_ValueForKey( const char *s, const char *key ) RETURNS_NONNULL NONNULL;
+const char *Info_ValueForKey( const char *s, const char *key );
 void Info_RemovePrefixedKeys( char *start, char prefix );
 qboolean Info_RemoveKey( char *s, const char *key );
 qboolean Info_SetValueForKey( char *s, const char *key, const char *value, int maxsize );
@@ -873,6 +832,13 @@ void V_CheckGamma( void );
 void V_CheckGammaEnd( void );
 intptr_t V_GetGammaPtr( int parm );
 
+//
+// identification.c
+//
+void ID_Init( void );
+const char *ID_GetMD5( void );
+void GAME_EXPORT ID_SetCustomClientID( const char *id );
+
 //
 // masterlist.c
 //

engine/common/con_utils.c

@@ -498,6 +498,7 @@ static qboolean Cmd_GetSoundList( const char *s, char *completedname, int length
 	return true;
 }
 
+#if !XASH_DEDICATED
 /*
 =====================================
 Cmd_GetItemsList
@@ -507,7 +508,6 @@ Prints or complete item classname (weapons only)
 */
 static qboolean Cmd_GetItemsList( const char *s, char *completedname, int length )
 {
-#if !XASH_DEDICATED
 	search_t		*t;
 	string		matchbuf;
 	int		i, numitems;
@@ -521,7 +521,7 @@ static qboolean Cmd_GetItemsList( const char *s, char *completedname, int length
 		Q_strncpy( completedname, matchbuf, length );
 	if( t->numfilenames == 1 ) return true;
 
-	for( i = 0, numitems = 0; i < t->numfilenames; i++ )
+	for(i = 0, numitems = 0; i < t->numfilenames; i++)
 	{
 		if( Q_stricmp( COM_FileExtension( t->filenames[i] ), "txt" ))
 			continue;
@@ -544,8 +544,6 @@ static qboolean Cmd_GetItemsList( const char *s, char *completedname, int length
 		}
 	}
 	return true;
-#endif // !XASH_DEDICATED
-	return false;
 }
 
 /*
@@ -557,7 +555,6 @@ Autocomplete for bind command
 */
 static qboolean Cmd_GetKeysList( const char *s, char *completedname, int length )
 {
-#if !XASH_DEDICATED
 	size_t i, numkeys;
 	string keys[256];
 	string matchbuf;
@@ -598,9 +595,8 @@ static qboolean Cmd_GetKeysList( const char *s, char *completedname, int length
 	}
 
 	return true;
-#endif // !XASH_DEDICATED
-	return false;
 }
+#endif // XASH_DEDICATED
 
 /*
 ===============
@@ -608,20 +604,13 @@ Con_AddCommandToList
 
 ===============
 */
-static void Con_AddCommandToList( const char *s, const char *value, const void *ptoggle, void *_autocompleteList )
+static void Con_AddCommandToList( const char *s, const char *unused1, const char *unused2, void *_autocompleteList )
 {
 	con_autocomplete_t *list = (con_autocomplete_t*)_autocompleteList;
-	qboolean toggle = ptoggle != NULL && *(qboolean *)ptoggle;
 
 	if( *s == '@' ) return; // never show system cvars or cmds
 	if( list->matchCount >= CON_MAXCMDS ) return; // list is full
 
-	if( toggle )
-	{
-		if( Q_strcmp( value, "0" ) && Q_strcmp( value, "1" ))
-			return; // exclude non-toggable cvars
-	}
-
 	if( Q_strnicmp( s, list->completionString, Q_strlen( list->completionString ) ) )
 		return; // no match
 
@@ -645,11 +634,13 @@ Cmd_GetCommandsList
 Autocomplete for bind command
 =====================================
 */
-static qboolean Cmd_GetCommandsAndCvarsList( const char *s, char *completedname, int length, qboolean cmds, qboolean cvars, qboolean toggle )
+static qboolean Cmd_GetCommandsList( const char *s, char *completedname, int length )
 {
 	size_t i;
 	string matchbuf;
-	con_autocomplete_t list = { 0 }; // local autocomplete list
+	con_autocomplete_t list; // local autocomplete list
+
+	memset( &list, 0, sizeof( list ));
 
 	list.completionString = s;
 
@@ -661,16 +652,8 @@ static qboolean Cmd_GetCommandsAndCvarsList( const char *s, char *completedname,
 		return false;
 
 	// find matching commands and variables
-	if( cvars )
-	{
-		Cvar_LookupVars( 0, &toggle, &list, (setpair_t)Con_AddCommandToList );
-	}
-
-	if( cmds )
-	{
-		toggle = false;
-		Cmd_LookupCmds( &toggle, &list, (setpair_t)Con_AddCommandToList );
-	}
+	Cmd_LookupCmds( NULL, &list, (setpair_t)Con_AddCommandToList );
+	Cvar_LookupVars( 0, NULL, &list, (setpair_t)Con_AddCommandToList );
 
 	if( !list.matchCount ) return false;
 	Q_strncpy( matchbuf, list.cmds[0], sizeof( matchbuf ));
@@ -686,7 +669,7 @@ static qboolean Cmd_GetCommandsAndCvarsList( const char *s, char *completedname,
 		Con_Printf( "%16s\n", matchbuf );
 	}
 
-	Con_Printf( "\n^3 %i %s found.\n", list.matchCount, cmds ? "commands" : "variables" );
+	Con_Printf( "\n^3 %i commands found.\n", list.matchCount );
 
 	if( completedname && length )
 	{
@@ -708,30 +691,6 @@ static qboolean Cmd_GetCommandsAndCvarsList( const char *s, char *completedname,
 	return true;
 }
 
-/*
-=====================================
-Cmd_GetCommandsList
-
-Autocomplete for bind command
-=====================================
-*/
-static qboolean Cmd_GetCommandsList( const char *s, char *completedname, int length )
-{
-	return Cmd_GetCommandsAndCvarsList( s, completedname, length, true, true, false );
-}
-
-/*
-=====================================
-Cmd_GetCvarList
-
-Autocomplete for bind command
-=====================================
-*/
-static qboolean Cmd_GetCvarsList( const char *s, char *completedname, int length )
-{
-	qboolean toggle = !Q_stricmp( Cmd_Argv( 0 ), "toggle" );
-	return Cmd_GetCommandsAndCvarsList( s, completedname, length, false, true, toggle );
-}
 
 /*
 =====================================
@@ -1051,38 +1010,37 @@ int GAME_EXPORT Cmd_CheckMapsList( int fRefresh )
 	return Cmd_CheckMapsList_R( fRefresh, true );
 }
 
-// keep this sorted
 static const autocomplete_list_t cmd_list[] =
 {
-{ "bind", 1, Cmd_GetKeysList },
-{ "bind", 2, Cmd_GetCommandsList },
-{ "cd", 1, Cmd_GetCDList },
+{ "map_background", 1, Cmd_GetMapList },
 { "changelevel2", 1, Cmd_GetMapList },
 { "changelevel", 1, Cmd_GetMapList },
-{ "drop", 1, Cmd_GetItemsList },
-{ "entpatch", 1, Cmd_GetMapList },
-{ "exec", 1, Cmd_GetConfigList },
-{ "game", 1, Cmd_GetGamesList },
-{ "give", 1, Cmd_GetItemsList },
-{ "hpkextract", 1, Cmd_GetCustomList },
-{ "hpklist", 1, Cmd_GetCustomList },
-{ "hpkval", 1, Cmd_GetCustomList },
-{ "listdemo", 1, Cmd_GetDemoList, },
-{ "load", 1, Cmd_GetSavesList },
-{ "map", 1, Cmd_GetMapList },
-{ "map_background", 1, Cmd_GetMapList },
-{ "movie", 1, Cmd_GetMovieList },
-{ "mp3", 1, Cmd_GetCDList },
-{ "music", 1, Cmd_GetMusicList, },
-{ "play", 1, Cmd_GetSoundList },
 { "playdemo", 1, Cmd_GetDemoList, },
+{ "timedemo", 1, Cmd_GetDemoList, },
+{ "listdemo", 1, Cmd_GetDemoList, },
 { "playvol", 1, Cmd_GetSoundList },
-{ "reset", 1, Cmd_GetCvarsList },
-{ "save", 1, Cmd_GetSavesList },
-{ "set", 1, Cmd_GetCvarsList },
-{ "timedemo", 1, Cmd_GetDemoList },
-{ "toggle", 1, Cmd_GetCvarsList },
+{ "hpkval", 1, Cmd_GetCustomList },
+{ "hpklist", 1, Cmd_GetCustomList },
+{ "hpkextract", 1, Cmd_GetCustomList },
+{ "entpatch", 1, Cmd_GetMapList },
+{ "music", 1, Cmd_GetMusicList, },
+{ "movie", 1, Cmd_GetMovieList },
+{ "exec", 1, Cmd_GetConfigList },
+#if !XASH_DEDICATED
+{ "give", 1, Cmd_GetItemsList },
+{ "drop", 1, Cmd_GetItemsList },
+{ "bind", 1, Cmd_GetKeysList },
 { "unbind", 1, Cmd_GetKeysList },
+{ "bind", 2, Cmd_GetCommandsList },
+#endif
+{ "game", 1, Cmd_GetGamesList },
+{ "save", 1, Cmd_GetSavesList },
+{ "load", 1, Cmd_GetSavesList },
+{ "play", 1, Cmd_GetSoundList },
+{ "map", 1, Cmd_GetMapList },
+{ "cd", 1, Cmd_GetCDList },
+{ "mp3", 1, Cmd_GetCDList },
+{ NULL }, // termiantor
 };
 
 /*
@@ -1115,12 +1073,12 @@ for various cmds
 */
 static qboolean Cmd_AutocompleteName( const char *source, int arg, char *buffer, size_t bufsize )
 {
-	int i;
+	const autocomplete_list_t	*list;
 
-	for( i = 0; i < ARRAYSIZE( cmd_list ); i++  )
+	for( list = cmd_list; list->name; list++ )
 	{
-		if( cmd_list[i].arg == arg && Cmd_CheckName( cmd_list[i].name ))
-			return cmd_list[i].func( source, buffer, bufsize );
+		if( list->arg == arg && Cmd_CheckName( list->name ))
+			return list->func( source, buffer, bufsize );
 	}
 
 	return false;
@@ -1203,7 +1161,6 @@ void Con_CompleteCommand( field_t *field )
 {
 	field_t	temp;
 	string	filename;
-	qboolean toggle = false;
 	qboolean	nextcmd;
 	int	i;
 
@@ -1238,8 +1195,8 @@ void Con_CompleteCommand( field_t *field )
 	con.shortestMatch[0] = 0;
 
 	// find matching commands and variables
-	Cmd_LookupCmds( &toggle, &con, (setpair_t)Con_AddCommandToList );
-	Cvar_LookupVars( 0, &toggle, &con, (setpair_t)Con_AddCommandToList );
+	Cmd_LookupCmds( NULL, &con, (setpair_t)Con_AddCommandToList );
+	Cvar_LookupVars( 0, NULL, &con, (setpair_t)Con_AddCommandToList );
 
 	if( !con.matchCount ) return; // no matches
 
@@ -1439,7 +1396,7 @@ void Host_WriteConfig( void )
 	{
 		Con_Reportf( "%s()\n", __func__ );
 		FS_Printf( f, "//=======================================================================\n");
-		FS_Printf( f, "//\tGenerated by "XASH_ENGINE_NAME" (%i, %s, %s, %s-%s)\n", Q_buildnum(), g_buildcommit, g_buildbranch, Q_buildos(), Q_buildarch());
+		FS_Printf( f, "//\tGenerated by "XASH_ENGINE_NAME" (%i, %s, %s, %s-%s)\n", Q_buildnum(), Q_buildcommit(), Q_buildbranch(), Q_buildos(), Q_buildarch());
 		FS_Printf( f, "//\t\tconfig.cfg - archive of cvars\n" );
 		FS_Printf( f, "//=======================================================================\n" );
 		Key_WriteBindings( f );
@@ -1487,7 +1444,7 @@ void GAME_EXPORT Host_WriteServerConfig( const char *name )
 	if(( f = FS_Open( newconfigfile, "w", false )) != NULL )
 	{
 		FS_Printf( f, "//=======================================================================\n" );
-		FS_Printf( f, "//\tGenerated by "XASH_ENGINE_NAME" (%i, %s, %s, %s-%s)\n", Q_buildnum(), g_buildcommit, g_buildbranch, Q_buildos(), Q_buildarch());
+		FS_Printf( f, "//\tGenerated by "XASH_ENGINE_NAME" (%i, %s, %s, %s-%s)\n", Q_buildnum(), Q_buildcommit(), Q_buildbranch(), Q_buildos(), Q_buildarch());
 		FS_Printf( f, "//\t\tgame.cfg - multiplayer server temporare config\n" );
 		FS_Printf( f, "//=======================================================================\n" );
 
@@ -1522,7 +1479,7 @@ void Host_WriteOpenGLConfig( void )
 	{
 		Con_Reportf( "%s()\n", __func__ );
 		FS_Printf( f, "//=======================================================================\n" );
-		FS_Printf( f, "//\tGenerated by "XASH_ENGINE_NAME" (%i, %s, %s, %s-%s)\n", Q_buildnum(), g_buildcommit, g_buildbranch, Q_buildos(), Q_buildarch());
+		FS_Printf( f, "//\tGenerated by "XASH_ENGINE_NAME" (%i, %s, %s, %s-%s)\n", Q_buildnum(), Q_buildcommit(), Q_buildbranch(), Q_buildos(), Q_buildarch());
 		FS_Printf( f, "//\t\t%s - archive of renderer implementation cvars\n", name );
 		FS_Printf( f, "//=======================================================================\n" );
 		FS_Printf( f, "\n" );
@@ -1552,7 +1509,7 @@ void Host_WriteVideoConfig( void )
 	{
 		Con_Reportf( "%s()\n", __func__ );
 		FS_Printf( f, "//=======================================================================\n" );
-		FS_Printf( f, "//\tGenerated by "XASH_ENGINE_NAME" (%i, %s, %s, %s-%s)\n", Q_buildnum(), g_buildcommit, g_buildbranch, Q_buildos(), Q_buildarch());
+		FS_Printf( f, "//\tGenerated by "XASH_ENGINE_NAME" (%i, %s, %s, %s-%s)\n", Q_buildnum(), Q_buildcommit(), Q_buildbranch(), Q_buildos(), Q_buildarch());
 		FS_Printf( f, "//\t\tvideo.cfg - archive of renderer variables\n");
 		FS_Printf( f, "//=======================================================================\n" );
 		Cvar_WriteVariables( f, FCVAR_RENDERINFO );
@@ -1578,7 +1535,7 @@ void Key_EnumCmds_f( void )
 	if( f )
 	{
 		FS_Printf( f, "//=======================================================================\n");
-		FS_Printf( f, "//\tGenerated by "XASH_ENGINE_NAME" (%i, %s, %s, %s-%s)\n", Q_buildnum(), g_buildcommit, g_buildbranch, Q_buildos(), Q_buildarch());
+		FS_Printf( f, "//\tGenerated by "XASH_ENGINE_NAME" (%i, %s, %s, %s-%s)\n", Q_buildnum(), Q_buildcommit(), Q_buildbranch(), Q_buildos(), Q_buildarch());
 		FS_Printf( f, "//\t\thelp.txt - xash commands and console variables\n");
 		FS_Printf( f, "//=======================================================================\n");
 

engine/common/crashhandler.c

@@ -0,0 +1,558 @@
+/*
+crashhandler.c - advanced crashhandler
+Copyright (C) 2016 Mittorn
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+*/
+#ifndef _GNU_SOURCE
+#define _GNU_SOURCE
+#endif
+
+#include "common.h"
+
+/*
+================
+Sys_Crash
+
+Crash handler, called from system
+================
+*/
+#if XASH_WIN32
+
+#if DBGHELP
+
+#pragma comment( lib, "dbghelp" )
+
+#include <winnt.h>
+#include <dbghelp.h>
+#include <psapi.h>
+#include <time.h>
+
+#ifndef XASH_SDL
+typedef ULONG_PTR DWORD_PTR, *PDWORD_PTR;
+#endif
+
+static int Sys_ModuleName( HANDLE process, char *name, void *address, int len )
+{
+	DWORD_PTR   baseAddress = 0;
+	static HMODULE     *moduleArray;
+	static unsigned int moduleCount;
+	LPBYTE      moduleArrayBytes;
+	DWORD       bytesRequired;
+	int i;
+
+	if( len < 3 )
+		return 0;
+
+	if( !moduleArray && EnumProcessModules( process, NULL, 0, &bytesRequired ) )
+	{
+		if ( bytesRequired )
+		{
+			moduleArrayBytes = (LPBYTE)LocalAlloc( LPTR, bytesRequired );
+
+			if( moduleArrayBytes && EnumProcessModules( process, (HMODULE *)moduleArrayBytes, bytesRequired, &bytesRequired ) )
+			{
+				moduleCount = bytesRequired / sizeof( HMODULE );
+				moduleArray = (HMODULE *)moduleArrayBytes;
+			}
+		}
+	}
+
+	for( i = 0; i < moduleCount; i++ )
+	{
+		MODULEINFO info;
+		GetModuleInformation( process, moduleArray[i], &info, sizeof(MODULEINFO) );
+
+		if( ( address > info.lpBaseOfDll ) &&
+				( (DWORD64)address < (DWORD64)info.lpBaseOfDll + (DWORD64)info.SizeOfImage ) )
+			return GetModuleBaseName( process, moduleArray[i], name, len );
+	}
+	return Q_snprintf( name, len, "???" );
+}
+
+static void Sys_StackTrace( PEXCEPTION_POINTERS pInfo )
+{
+	char message[8192]; // match *nix Sys_Crash
+	int len = 0;
+	size_t i;
+	HANDLE process = GetCurrentProcess();
+	HANDLE thread = GetCurrentThread();
+	IMAGEHLP_LINE64 line;
+	DWORD dline = 0;
+	DWORD options;
+	CONTEXT context;
+	STACKFRAME64 stackframe;
+	DWORD image;
+
+	context = *pInfo->ContextRecord;
+
+	options = SymGetOptions();
+	options |= SYMOPT_DEBUG;
+	options |= SYMOPT_LOAD_LINES;
+	SymSetOptions( options );
+
+	SymInitialize( process, NULL, TRUE );
+
+	ZeroMemory( &stackframe, sizeof( STACKFRAME64 ));
+
+#ifdef _M_IX86
+	image = IMAGE_FILE_MACHINE_I386;
+	stackframe.AddrPC.Offset = context.Eip;
+	stackframe.AddrPC.Mode = AddrModeFlat;
+	stackframe.AddrFrame.Offset = context.Ebp;
+	stackframe.AddrFrame.Mode = AddrModeFlat;
+	stackframe.AddrStack.Offset = context.Esp;
+	stackframe.AddrStack.Mode = AddrModeFlat;
+#elif _M_X64
+	image = IMAGE_FILE_MACHINE_AMD64;
+	stackframe.AddrPC.Offset = context.Rip;
+	stackframe.AddrPC.Mode = AddrModeFlat;
+	stackframe.AddrFrame.Offset = context.Rsp;
+	stackframe.AddrFrame.Mode = AddrModeFlat;
+	stackframe.AddrStack.Offset = context.Rsp;
+	stackframe.AddrStack.Mode = AddrModeFlat;
+#elif _M_IA64
+	image = IMAGE_FILE_MACHINE_IA64;
+	stackframe.AddrPC.Offset = context.StIIP;
+	stackframe.AddrPC.Mode = AddrModeFlat;
+	stackframe.AddrFrame.Offset = context.IntSp;
+	stackframe.AddrFrame.Mode = AddrModeFlat;
+	stackframe.AddrBStore.Offset = context.RsBSP;
+	stackframe.AddrBStore.Mode = AddrModeFlat;
+	stackframe.AddrStack.Offset = context.IntSp;
+	stackframe.AddrStack.Mode = AddrModeFlat;
+#elif _M_ARM
+	image = IMAGE_FILE_MACHINE_ARMNT;
+	stackframe.AddrPC.Offset = context.Pc;
+	stackframe.AddrPC.Mode = AddrModeFlat;
+	stackframe.AddrFrame.Offset = context.R11;
+	stackframe.AddrFrame.Mode = AddrModeFlat;
+	stackframe.AddrStack.Offset = context.Sp;
+	stackframe.AddrStack.Mode = AddrModeFlat;
+#elif _M_ARM64
+	image = IMAGE_FILE_MACHINE_ARM64;
+	stackframe.AddrPC.Offset = context.Pc;
+	stackframe.AddrPC.Mode = AddrModeFlat;
+	stackframe.AddrFrame.Offset = context.Fp;
+	stackframe.AddrFrame.Mode = AddrModeFlat;
+	stackframe.AddrStack.Offset = context.Sp;
+	stackframe.AddrStack.Mode = AddrModeFlat;	
+#elif
+#error
+#endif
+
+	len = Q_snprintf( message, sizeof( message ), "Ver: " XASH_ENGINE_NAME " " XASH_VERSION " (build %i-%s, %s-%s)\n",
+		Q_buildnum(), Q_buildcommit(), Q_buildos(), Q_buildarch() );
+
+	len += Q_snprintf( message + len, 1024 - len, "Sys_Crash: address %p, code %p\n",
+		pInfo->ExceptionRecord->ExceptionAddress, (void*)pInfo->ExceptionRecord->ExceptionCode );
+	if( SymGetLineFromAddr64( process, (DWORD64)pInfo->ExceptionRecord->ExceptionAddress, &dline, &line ) )
+	{
+		len += Q_snprintf(message + len, 1024 - len, "Exception: %s:%d:%d\n",
+			(char*)line.FileName, (int)line.LineNumber, (int)dline);
+	}
+	if( SymGetLineFromAddr64( process, stackframe.AddrPC.Offset, &dline, &line ) )
+	{
+		len += Q_snprintf(message + len, 1024 - len,"PC: %s:%d:%d\n",
+			(char*)line.FileName, (int)line.LineNumber, (int)dline);
+	}
+	if( SymGetLineFromAddr64( process, stackframe.AddrFrame.Offset, &dline, &line ) )
+	{
+		len += Q_snprintf(message + len, 1024 - len,"Frame: %s:%d:%d\n",
+			(char*)line.FileName, (int)line.LineNumber, (int)dline);
+	}
+	for( i = 0; i < 25; i++ )
+	{
+		char buffer[sizeof(SYMBOL_INFO) + MAX_SYM_NAME * sizeof(TCHAR)];
+		PSYMBOL_INFO symbol = (PSYMBOL_INFO)buffer;
+		BOOL result = StackWalk64(
+			image, process, thread,
+			&stackframe, &context, NULL,
+			SymFunctionTableAccess64, SymGetModuleBase64, NULL);
+		DWORD64 displacement = 0;
+
+		if( !result )
+			break;
+
+		symbol->SizeOfStruct = sizeof(SYMBOL_INFO);
+		symbol->MaxNameLen = MAX_SYM_NAME;
+
+		len += Q_snprintf( message + len, 1024 - len, "% 2d %p",
+			i, (void*)stackframe.AddrPC.Offset );
+		if( SymFromAddr( process, stackframe.AddrPC.Offset, &displacement, symbol ) )
+		{
+			len += Q_snprintf( message + len, 1024 - len, " %s ", symbol->Name );
+		}
+		if( SymGetLineFromAddr64( process, stackframe.AddrPC.Offset, &dline, &line ) )
+		{
+			len += Q_snprintf(message + len, 1024 - len,"(%s:%d:%d) ",
+				(char*)line.FileName, (int)line.LineNumber, (int)dline);
+		}
+		len += Q_snprintf( message + len, 1024 - len, "(");
+		len += Sys_ModuleName( process, message + len, (void*)stackframe.AddrPC.Offset, 1024 - len );
+		len += Q_snprintf( message + len, 1024 - len, ")\n");
+	}
+
+#if XASH_SDL == 2
+	if( host.type != HOST_DEDICATED ) // let system to restart server automaticly
+		SDL_ShowSimpleMessageBox( SDL_MESSAGEBOX_ERROR, "Sys_Crash", message, host.hWnd );
+#endif
+
+	Sys_PrintLog( message );
+
+	SymCleanup( process );
+}
+
+static void Sys_GetProcessName( char *processName, size_t bufferSize )
+{
+	char fullpath[MAX_PATH];
+
+	GetModuleBaseName( GetCurrentProcess(), NULL, fullpath, sizeof( fullpath ) - 1 );
+	COM_FileBase( fullpath, processName, bufferSize );
+}
+
+static void Sys_GetMinidumpFileName( const char *processName, char *mdmpFileName, size_t bufferSize )
+{
+	time_t currentUtcTime = time( NULL );
+	struct tm *currentLocalTime = localtime( &currentUtcTime );
+
+	Q_snprintf( mdmpFileName, bufferSize, "%s_%s_crash_%d%.2d%.2d_%.2d%.2d%.2d.mdmp",
+		processName,
+		Q_buildcommit(),
+		currentLocalTime->tm_year + 1900,
+		currentLocalTime->tm_mon + 1,
+		currentLocalTime->tm_mday,
+		currentLocalTime->tm_hour,
+		currentLocalTime->tm_min,
+		currentLocalTime->tm_sec);
+}
+
+static qboolean Sys_WriteMinidump(PEXCEPTION_POINTERS exceptionInfo, MINIDUMP_TYPE minidumpType)
+{
+	HRESULT errorCode;
+	string processName;
+	string mdmpFileName;
+	MINIDUMP_EXCEPTION_INFORMATION minidumpInfo;
+
+	Sys_GetProcessName( processName, sizeof( processName ));
+	Sys_GetMinidumpFileName( processName, mdmpFileName, sizeof( mdmpFileName ));
+
+	SetLastError( NOERROR );
+	HANDLE fileHandle = CreateFile(
+		mdmpFileName, GENERIC_WRITE, FILE_SHARE_WRITE,
+		NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
+
+	errorCode = HRESULT_FROM_WIN32( GetLastError( ));
+	if( !SUCCEEDED( errorCode )) {
+		CloseHandle( fileHandle );
+		return false;
+	}
+
+	minidumpInfo.ThreadId = GetCurrentThreadId();
+	minidumpInfo.ExceptionPointers = exceptionInfo;
+	minidumpInfo.ClientPointers = FALSE;
+
+	qboolean status = MiniDumpWriteDump(
+		GetCurrentProcess(), GetCurrentProcessId(), fileHandle,
+		minidumpType, &minidumpInfo, NULL, NULL);
+
+	CloseHandle( fileHandle );
+	return status;
+}
+
+#endif /* DBGHELP */
+
+LPTOP_LEVEL_EXCEPTION_FILTER       oldFilter;
+static long _stdcall Sys_Crash( PEXCEPTION_POINTERS pInfo )
+{
+	// save config
+	if( host.status != HOST_CRASHED )
+	{
+		// check to avoid recursive call
+		host.crashed = true;
+
+#ifdef XASH_SDL
+		SDL_SetWindowGrab( host.hWnd, SDL_FALSE );
+#endif // XASH_SDL
+
+#if DBGHELP
+		Sys_StackTrace( pInfo );
+#else
+		Sys_Warn( "Sys_Crash: call %p at address %p", pInfo->ExceptionRecord->ExceptionAddress, pInfo->ExceptionRecord->ExceptionCode );
+#endif
+
+		if( host.type == HOST_NORMAL )
+			CL_Crashed(); // tell client about crash
+		else host.status = HOST_CRASHED;
+
+#if DBGHELP
+		if( Sys_CheckParm( "-minidumps" ))
+		{
+			int minidumpFlags = (
+				MiniDumpWithDataSegs | 
+				MiniDumpWithCodeSegs |
+				MiniDumpWithHandleData | 
+				MiniDumpWithFullMemory |
+				MiniDumpWithFullMemoryInfo |
+				MiniDumpWithIndirectlyReferencedMemory |
+				MiniDumpWithThreadInfo |
+				MiniDumpWithModuleHeaders);
+
+			if( !Sys_WriteMinidump( pInfo, (MINIDUMP_TYPE)minidumpFlags )) {
+				// fallback method, create minidump with minimal info in it
+				Sys_WriteMinidump( pInfo, MiniDumpWithDataSegs );
+			}
+		}
+#endif
+
+		if( host_developer.value <= 0 )
+		{
+			// no reason to call debugger in release build - just exit
+			Sys_Quit();
+			return EXCEPTION_CONTINUE_EXECUTION;
+		}
+
+		// all other states keep unchanged to let debugger find bug
+		Sys_DestroyConsole();
+	}
+
+	if( oldFilter )
+		return oldFilter( pInfo );
+	return EXCEPTION_CONTINUE_EXECUTION;
+}
+
+void Sys_SetupCrashHandler( void )
+{
+	SetErrorMode( SEM_FAILCRITICALERRORS );	// no abort/retry/fail errors
+	oldFilter = SetUnhandledExceptionFilter( Sys_Crash );
+}
+
+void Sys_RestoreCrashHandler( void )
+{
+	// restore filter
+	if( oldFilter ) SetUnhandledExceptionFilter( oldFilter );
+}
+
+#elif XASH_FREEBSD || XASH_NETBSD || XASH_OPENBSD || XASH_ANDROID || XASH_LINUX
+// Posix signal handler
+#ifndef XASH_OPENBSD
+#include <ucontext.h>
+#endif
+#include <signal.h>
+#include <sys/mman.h>
+#include "library.h"
+
+#define STACK_BACKTRACE_STR     "Stack backtrace:\n"
+#define STACK_DUMP_STR          "Stack dump:\n"
+
+#define STACK_BACKTRACE_STR_LEN ( sizeof( STACK_BACKTRACE_STR ) - 1 )
+#define STACK_DUMP_STR_LEN      ( sizeof( STACK_DUMP_STR ) - 1 )
+#define ALIGN( x, y ) (((uintptr_t) ( x ) + (( y ) - 1 )) & ~(( y ) - 1 ))
+
+static struct sigaction oldFilter;
+
+static int Sys_PrintFrame( char *buf, int len, int i, void *addr )
+{
+	Dl_info dlinfo;
+	if( len <= 0 )
+		return 0; // overflow
+
+	if( dladdr( addr, &dlinfo ))
+	{
+		if( dlinfo.dli_sname )
+			return Q_snprintf( buf, len, "%2d: %p <%s+%lu> (%s)\n", i, addr, dlinfo.dli_sname,
+				(unsigned long)addr - (unsigned long)dlinfo.dli_saddr, dlinfo.dli_fname ); // print symbol, module and address
+
+		return Q_snprintf( buf, len, "%2d: %p (%s)\n", i, addr, dlinfo.dli_fname ); // print module and address
+	}
+
+	return Q_snprintf( buf, len, "%2d: %p\n", i, addr ); // print only address
+}
+
+static void Sys_Crash( int signal, siginfo_t *si, void *context)
+{
+	void *pc = NULL, **bp = NULL, **sp = NULL; // this must be set for every OS!
+	char message[8192];
+	int len, logfd, i = 0;
+
+#if XASH_OPENBSD
+	struct sigcontext *ucontext = (struct sigcontext*)context;
+#else
+	ucontext_t *ucontext = (ucontext_t*)context;
+#endif
+
+#if XASH_AMD64
+	#if XASH_FREEBSD
+		pc = (void*)ucontext->uc_mcontext.mc_rip;
+		bp = (void**)ucontext->uc_mcontext.mc_rbp;
+		sp = (void**)ucontext->uc_mcontext.mc_rsp;
+	#elif XASH_NETBSD
+		pc = (void*)ucontext->uc_mcontext.__gregs[_REG_RIP];
+		bp = (void**)ucontext->uc_mcontext.__gregs[_REG_RBP];
+		sp = (void**)ucontext->uc_mcontext.__gregs[_REG_RSP];
+	#elif XASH_OPENBSD
+		pc = (void*)ucontext->sc_rip;
+		bp = (void**)ucontext->sc_rbp;
+		sp = (void**)ucontext->sc_rsp;
+	#else
+		pc = (void*)ucontext->uc_mcontext.gregs[REG_RIP];
+		bp = (void**)ucontext->uc_mcontext.gregs[REG_RBP];
+		sp = (void**)ucontext->uc_mcontext.gregs[REG_RSP];
+	#endif
+#elif XASH_X86
+	#if XASH_FREEBSD
+		pc = (void*)ucontext->uc_mcontext.mc_eip;
+		bp = (void**)ucontext->uc_mcontext.mc_ebp;
+		sp = (void**)ucontext->uc_mcontext.mc_esp;
+	#elif XASH_NETBSD
+		pc = (void*)ucontext->uc_mcontext.__gregs[_REG_EIP];
+		bp = (void**)ucontext->uc_mcontext.__gregs[_REG_EBP];
+		sp = (void**)ucontext->uc_mcontext.__gregs[_REG_ESP];
+	#elif XASH_OPENBSD
+		pc = (void*)ucontext->sc_eip;
+		bp = (void**)ucontext->sc_ebp;
+		sp = (void**)ucontext->sc_esp;
+	#else
+		pc = (void*)ucontext->uc_mcontext.gregs[REG_EIP];
+		bp = (void**)ucontext->uc_mcontext.gregs[REG_EBP];
+		sp = (void**)ucontext->uc_mcontext.gregs[REG_ESP];
+	#endif
+#elif XASH_ARM && XASH_64BIT
+	pc = (void*)ucontext->uc_mcontext.pc;
+	bp = (void*)ucontext->uc_mcontext.regs[29];
+	sp = (void*)ucontext->uc_mcontext.sp;
+#elif XASH_ARM
+	pc = (void*)ucontext->uc_mcontext.arm_pc;
+	bp = (void*)ucontext->uc_mcontext.arm_fp;
+	sp = (void*)ucontext->uc_mcontext.arm_sp;
+#endif
+
+	// safe actions first, stack and memory may be corrupted
+	len = Q_snprintf( message, sizeof( message ), "Ver: " XASH_ENGINE_NAME " " XASH_VERSION " (build %i-%s, %s-%s)\n",
+		Q_buildnum(), Q_buildcommit(), Q_buildos(), Q_buildarch() );
+
+#if !XASH_FREEBSD && !XASH_NETBSD && !XASH_OPENBSD
+	len += Q_snprintf( message + len, sizeof( message ) - len, "Crash: signal %d errno %d with code %d at %p %p\n", signal, si->si_errno, si->si_code, si->si_addr, si->si_ptr );
+#else
+	len += Q_snprintf( message + len, sizeof( message ) - len, "Crash: signal %d errno %d with code %d at %p\n", signal, si->si_errno, si->si_code, si->si_addr );
+#endif
+
+	write( STDERR_FILENO, message, len );
+
+	// flush buffers before writing directly to descriptors
+	fflush( stdout );
+	fflush( stderr );
+
+	// now get log fd and write trace directly to log
+	logfd = Sys_LogFileNo();
+	write( logfd, message, len );
+
+	if( pc && bp && sp )
+	{
+		size_t pagesize = sysconf( _SC_PAGESIZE );
+
+		// try to print backtrace
+		write( STDERR_FILENO, STACK_BACKTRACE_STR, STACK_BACKTRACE_STR_LEN );
+		write( logfd, STACK_BACKTRACE_STR, STACK_BACKTRACE_STR_LEN );
+		Q_strncpy( message + len, STACK_BACKTRACE_STR, sizeof( message ) - len );
+		len += STACK_BACKTRACE_STR_LEN;
+
+// false on success, true on failure
+#define try_allow_read(pointer, pagesize) \
+	((mprotect( (char *)ALIGN( (pointer), (pagesize) ), (pagesize), PROT_READ | PROT_WRITE | PROT_EXEC ) == -1) && \
+	( mprotect( (char *)ALIGN( (pointer), (pagesize) ), (pagesize), PROT_READ | PROT_EXEC ) == -1) && \
+	( mprotect( (char *)ALIGN( (pointer), (pagesize) ), (pagesize), PROT_READ | PROT_WRITE ) == -1) && \
+	( mprotect( (char *)ALIGN( (pointer), (pagesize) ), (pagesize), PROT_READ ) == -1))
+
+		do
+		{
+			int line = Sys_PrintFrame( message + len, sizeof( message ) - len, ++i, pc);
+			write( STDERR_FILENO, message + len, line );
+			write( logfd, message + len, line );
+			len += line;
+			//if( !dladdr(bp,0) ) break; // only when bp is in module
+			if( try_allow_read( bp, pagesize ) )
+				break;
+			if( try_allow_read( bp[0], pagesize ) )
+				break;
+			pc = bp[1];
+			bp = (void**)bp[0];
+		}
+		while( bp && i < 128 );
+
+		// try to print stack
+		write( STDERR_FILENO, STACK_DUMP_STR, STACK_DUMP_STR_LEN );
+		write( logfd, STACK_DUMP_STR, STACK_DUMP_STR_LEN );
+		Q_strncpy( message + len, STACK_DUMP_STR, sizeof( message ) - len );
+		len += STACK_DUMP_STR_LEN;
+
+		if( !try_allow_read( sp, pagesize ) )
+		{
+			for( i = 0; i < 32; i++ )
+			{
+				int line = Sys_PrintFrame( message + len, sizeof( message ) - len, i, sp[i] );
+				write( STDERR_FILENO, message + len, line );
+				write( logfd, message + len, line );
+				len += line;
+			}
+		}
+
+#undef try_allow_read
+	}
+
+	// put MessageBox as Sys_Error
+	Msg( "%s\n", message );
+#ifdef XASH_SDL
+	SDL_SetWindowGrab( host.hWnd, SDL_FALSE );
+#endif
+	host.crashed = true;
+	Platform_MessageBox( "Xash Error", message, false );
+
+	// log saved, now we can try to save configs and close log correctly, it may crash
+	if( host.type == HOST_NORMAL )
+		CL_Crashed();
+	host.status = HOST_CRASHED;
+
+
+	Sys_Quit();
+}
+
+void Sys_SetupCrashHandler( void )
+{
+	struct sigaction act = { 0 };
+	act.sa_sigaction = Sys_Crash;
+	act.sa_flags = SA_SIGINFO | SA_ONSTACK;
+	sigaction( SIGSEGV, &act, &oldFilter );
+	sigaction( SIGABRT, &act, &oldFilter );
+	sigaction( SIGBUS,  &act, &oldFilter );
+	sigaction( SIGILL,  &act, &oldFilter );
+}
+
+void Sys_RestoreCrashHandler( void )
+{
+	sigaction( SIGSEGV, &oldFilter, NULL );
+	sigaction( SIGABRT, &oldFilter, NULL );
+	sigaction( SIGBUS,  &oldFilter, NULL );
+	sigaction( SIGILL,  &oldFilter, NULL );
+}
+
+#else
+
+void Sys_SetupCrashHandler( void )
+{
+	// stub
+}
+
+void Sys_RestoreCrashHandler( void )
+{
+	// stub
+}
+#endif

engine/common/cvar.c

@@ -19,7 +19,6 @@ GNU General Public License for more details.
 #include "eiface.h" // ARRAYSIZE
 
 static convar_t	*cvar_vars = NULL; // head of list
-static poolhandle_t cvar_pool;
 CVAR_DEFINE_AUTO( cmd_scripting, "0", FCVAR_ARCHIVE|FCVAR_PRIVILEGED, "enable simple condition checking and variable operations" );
 
 typedef struct cvar_filter_quirks_s
@@ -153,7 +152,7 @@ static qboolean Cvar_UpdateInfo( convar_t *var, const char *value, qboolean noti
 {
 	if( FBitSet( var->flags, FCVAR_USERINFO ))
 	{
-		if( Host_IsDedicated() )
+		if ( Host_IsDedicated() )
 		{
 			// g-cont. this is a very strange behavior...
 			char *info = SV_Serverinfo();
@@ -432,9 +431,8 @@ convar_t *Cvar_Get( const char *name, const char *value, int flags, const char *
 			if( COM_CheckStringEmpty( var->desc ))
 			{
 				// directly set value
-				size_t len = Q_strlen( value ) + 1;
-				var->string = Mem_Realloc( cvar_pool, var->string, len );
-				Q_strncpy( var->string, value, len );
+				freestring( var->string );
+				var->string = copystring( value );
 				var->value = Q_atof( var->string );
 				SetBits( var->flags, flags );
 
@@ -450,25 +448,22 @@ convar_t *Cvar_Get( const char *name, const char *value, int flags, const char *
 
 		if( FBitSet( var->flags, FCVAR_ALLOCATED ) && Q_strcmp( var_desc, var->desc ))
 		{
-			size_t len = Q_strlen( var_desc ) + 1;
-
 			if( !FBitSet( flags, FCVAR_GLCONFIG ))
 				Con_Reportf( "%s change description from %s to %s\n", var->name, var->desc, var_desc );
-
 			// update description if needs
-			var->desc = Mem_Realloc( cvar_pool, var->desc, len );
-			Q_strncpy( var->desc, var_desc, len );
+			freestring( var->desc );
+			var->desc = copystring( var_desc );
 		}
 
 		return var;
 	}
 
 	// allocate a new cvar
-	var = Mem_Malloc( cvar_pool, sizeof( *var ));
-	var->name = copystringpool( cvar_pool, name );
-	var->string = copystringpool( cvar_pool, value );
-	var->def_string = copystringpool( cvar_pool, value );
-	var->desc = copystringpool( cvar_pool, var_desc );
+	var = Z_Malloc( sizeof( *var ));
+	var->name = copystring( name );
+	var->string = copystring( value );
+	var->def_string = copystring( value );
+	var->desc = copystring( var_desc );
 	var->value = Q_atof( var->string );
 	var->flags = flags|FCVAR_ALLOCATED;
 
@@ -554,7 +549,7 @@ void Cvar_RegisterVariable( convar_t *var )
 	if( FBitSet( var->flags, FCVAR_EXTENDED ))
 		var->def_string = var->string; // just swap pointers
 
-	var->string = copystringpool( cvar_pool, var->string );
+	var->string = copystring( var->string );
 	var->value = Q_atof( var->string );
 
 	// find the supposed position in chain (alphanumerical order)
@@ -606,10 +601,9 @@ Cvar_Set2
 static convar_t *Cvar_Set2( const char *var_name, const char *value )
 {
 	convar_t	*var;
+	const char	*pszValue;
 	qboolean	dll_variable = false;
 	qboolean	force = false;
-	const char *fixed_string;
-	size_t fixed_string_len;
 
 	if( !Cvar_ValidateVarName( var_name, false ))
 	{
@@ -673,20 +667,19 @@ static convar_t *Cvar_Set2( const char *var_name, const char *value )
 			return var;
 	}
 
-	fixed_string = Cvar_ValidateString( var, value );
+	pszValue = Cvar_ValidateString( var, value );
 
 	// nothing to change
-	if( !Q_strcmp( fixed_string, var->string ))
+	if( !Q_strcmp( pszValue, var->string ))
 		return var;
 
 	// fill it cls.userinfo, svs.serverinfo
-	if( !Cvar_UpdateInfo( var, fixed_string, true ))
+	if( !Cvar_UpdateInfo( var, pszValue, true ))
 		return var;
 
-	// and finally change the cvar itself
-	fixed_string_len = Q_strlen( fixed_string ) + 1;
-	var->string = Mem_Realloc( cvar_pool, var->string, fixed_string_len );
-	Q_strncpy( var->string, fixed_string, fixed_string_len );
+	// and finally changed the cvar itself
+	freestring( var->string );
+	var->string = copystring( pszValue );
 	var->value = Q_atof( var->string );
 
 	// tell engine about changes
@@ -703,8 +696,7 @@ way to change value for many cvars
 */
 void GAME_EXPORT Cvar_DirectSet( convar_t *var, const char *value )
 {
-	const char *fixed_string;
-	size_t fixed_string_len;
+	const char	*pszValue;
 
 	if( unlikely( !var )) return;	// ???
 
@@ -734,20 +726,19 @@ void GAME_EXPORT Cvar_DirectSet( convar_t *var, const char *value )
 		value = var->def_string; // reset to default value
 	}
 
-	fixed_string = Cvar_ValidateString( var, value );
+	pszValue = Cvar_ValidateString( var, value );
 
 	// nothing to change
-	if( !Q_strcmp( fixed_string, var->string ))
+	if( !Q_strcmp( pszValue, var->string ))
 		return;
 
 	// fill it cls.userinfo, svs.serverinfo
-	if( !Cvar_UpdateInfo( var, fixed_string, true ))
+	if( !Cvar_UpdateInfo( var, pszValue, true ))
 		return;
 
-	// and finally change the cvar itself
-	fixed_string_len = Q_strlen( fixed_string ) + 1;
-	var->string = Mem_Realloc( cvar_pool, var->string, fixed_string_len );
-	Q_strncpy( var->string, fixed_string, fixed_string_len );
+	// and finally changed the cvar itself
+	freestring( var->string );
+	var->string = copystring( pszValue );
 	var->value = Q_atof( var->string );
 
 	// tell engine about changes
@@ -781,8 +772,7 @@ can set any protected cvars
 */
 void Cvar_FullSet( const char *var_name, const char *value, int flags )
 {
-	convar_t *var = Cvar_FindVar( var_name );
-	size_t len = Q_strlen( value ) + 1;
+	convar_t	*var = Cvar_FindVar( var_name );
 
 	if( !var )
 	{
@@ -790,8 +780,8 @@ void Cvar_FullSet( const char *var_name, const char *value, int flags )
 		return;
 	}
 
-	var->string = Mem_Realloc( cvar_pool, var->string, len );
-	Q_strncpy( var->string, value, len );
+	freestring( var->string );
+	var->string = copystring( value );
 	var->value = Q_atof( var->string );
 	SetBits( var->flags, flags );
 
@@ -1199,7 +1189,6 @@ static void Cvar_List_f( void )
 	for( var = cvar_vars; var; var = var->next )
 	{
 		char value[MAX_VA_STRING];
-		char *p;
 
 		if( var->name[0] == '@' )
 			continue;	// never shows system cvars
@@ -1207,9 +1196,7 @@ static void Cvar_List_f( void )
 		if( match && !Q_strnicmpext( match, var->name, matchlen ))
 			continue;
 
-		p = Q_strchr( var->string, '^' );
-
-		if( IsColorString( p ))
+		if( Q_colorstr( var->string ))
 			Q_snprintf( value, sizeof( value ), "\"%s\"", var->string );
 		else Q_snprintf( value, sizeof( value ), "\"^2%s^7\"", var->string );
 
@@ -1270,7 +1257,7 @@ pending_cvar_t *Cvar_PrepareToUnlink( int group )
 			continue;
 
 		namelen = Q_strlen( cv->name ) + 1;
-		p = Mem_Malloc( cvar_pool, sizeof( *list ) + namelen );
+		p = Mem_Malloc( host.mempool, sizeof( *list ) + namelen );
 		p->next = NULL;
 		p->cv_cur = cv;
 		p->cv_next = cv->next;
@@ -1346,7 +1333,6 @@ Reads in all archived cvars
 */
 void Cvar_Init( void )
 {
-	cvar_pool = Mem_AllocPool( "Console Variables" );
 	cvar_vars = NULL;
 	cvar_active_filter_quirks = NULL;
 	Cvar_RegisterVariable( &cmd_scripting );
@@ -1359,11 +1345,6 @@ void Cvar_Init( void )
 	Cmd_AddCommand( "cvarlist", Cvar_List_f, "display all console variables beginning with the specified prefix" );
 }
 
-void Cvar_Shutdown( void )
-{
-	Mem_FreePool( &cvar_pool );
-}
-
 /*
 ============
 Cvar_PostFSInit

engine/common/cvar.h

@@ -30,8 +30,6 @@ typedef struct pending_cvar_s
 	char      cv_name[];
 } pending_cvar_t;
 
-typedef void (*setpair_t)( const char *key, const void *value, const void *buffer, void *numpairs );
-
 cvar_t *Cvar_GetList( void );
 #define Cvar_FindVar( name )	Cvar_FindVarExt( name, 0 )
 convar_t *Cvar_FindVarExt( const char *var_name, int ignore_group );
@@ -54,7 +52,6 @@ void Cvar_Reset( const char *var_name );
 void Cvar_SetCheatState( void );
 qboolean Cvar_CommandWithPrivilegeCheck( convar_t *v, qboolean isPrivileged );
 void Cvar_Init( void );
-void Cvar_Shutdown( void );
 void Cvar_PostFSInit( void );
 void Cvar_Unlink( int group );
 

engine/common/dedicated.c

@@ -49,6 +49,52 @@ const char *CL_MsgInfo( int cmd )
 	return sz;
 }
 
+int GAME_EXPORT CL_Active( void )
+{
+	return false;
+}
+
+qboolean CL_Initialized( void )
+{
+	return false;
+}
+
+qboolean CL_IsInGame( void )
+{
+	return true;	// always active for dedicated servers
+}
+
+qboolean CL_IsInConsole( void )
+{
+	return false;
+}
+
+qboolean CL_IsIntermission( void )
+{
+	return false;
+}
+
+qboolean CL_IsPlaybackDemo( void )
+{
+	return false;
+}
+
+qboolean CL_IsRecordDemo( void )
+{
+	return false;
+}
+
+
+qboolean CL_DisableVisibility( void )
+{
+	return false;
+}
+
+void CL_Init( void )
+{
+
+}
+
 void Key_Init( void )
 {
 
@@ -84,6 +130,16 @@ void CL_WriteMessageHistory( void )
 
 }
 
+void Host_ClientBegin( void )
+{
+	Cbuf_Execute();
+}
+
+void Host_ClientFrame( void )
+{
+
+}
+
 void Host_InputFrame( void )
 {
 }
@@ -103,6 +159,11 @@ void GAME_EXPORT S_StopSound(int entnum, int channel, const char *soundname)
 
 }
 
+int GAME_EXPORT CL_GetMaxClients( void )
+{
+	return 0;
+}
+
 void IN_TouchInitConfig( void )
 {
 
@@ -113,6 +174,11 @@ void CL_Disconnect( void )
 
 }
 
+void CL_Shutdown( void )
+{
+
+}
+
 void R_ClearStaticEntities( void )
 {
 
@@ -123,6 +189,11 @@ void Host_Credits( void )
 
 }
 
+qboolean UI_CreditsActive( void )
+{
+	return false;
+}
+
 void S_StopBackgroundTrack( void )
 {
 
@@ -133,6 +204,11 @@ void SCR_BeginLoadingPlaque( qboolean is_background )
 
 }
 
+int S_GetCurrentDynamicSounds( soundlist_t *pout, int size )
+{
+	return 0;
+}
+
 void S_StopAllSounds( qboolean ambient )
 {
 

engine/common/filesystem_engine.c

@@ -1,4 +1,4 @@
-/*
+ /*
 filesystem.c - game filesystem based on DP fs
 Copyright (C) 2003-2006 Mathieu Olivier
 Copyright (C) 2000-2007 DarkPlaces contributors
@@ -16,23 +16,11 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.
 */
 
-#if XASH_SDL == 2
-#include <SDL.h> // SDL_GetBasePath
-#elif XASH_SDL == 3
-#include <SDL3/SDL.h>
-#endif
-
 #include <errno.h>
 #include "common.h"
 #include "library.h"
 #include "platform/platform.h"
 
-CVAR_DEFINE_AUTO( fs_mount_hd, "0", FCVAR_ARCHIVE|FCVAR_PRIVILEGED|FCVAR_LATCH, "mount high definition content folder" );
-CVAR_DEFINE_AUTO( fs_mount_lv, "0", FCVAR_ARCHIVE|FCVAR_PRIVILEGED|FCVAR_LATCH, "mount low violence models content folder" );
-CVAR_DEFINE_AUTO( fs_mount_addon, "0", FCVAR_ARCHIVE|FCVAR_PRIVILEGED|FCVAR_LATCH, "mount addon content folder" );
-CVAR_DEFINE_AUTO( fs_mount_l10n, "0", FCVAR_ARCHIVE|FCVAR_PRIVILEGED|FCVAR_LATCH, "mount localization content folder" );
-CVAR_DEFINE_AUTO( ui_language, "english", FCVAR_ARCHIVE|FCVAR_PRIVILEGED|FCVAR_LATCH, "selected game language" );
-
 fs_api_t g_fsapi;
 fs_globals_t *FI;
 
@@ -81,23 +69,9 @@ void *FS_GetNativeObject( const char *obj )
 	return NULL;
 }
 
-void FS_Rescan_f( void )
+static void FS_Rescan_f( void )
 {
-	uint32_t flags = 0;
-
-	// FIXME: VFS shouldn't care about this, allow engine to mount gamedirs
-	if( fs_mount_lv.value ) SetBits( flags, FS_MOUNT_LV );
-	if( fs_mount_hd.value ) SetBits( flags, FS_MOUNT_HD );
-	if( fs_mount_addon.value ) SetBits( flags, FS_MOUNT_ADDON );
-	if( fs_mount_l10n.value ) SetBits( flags, FS_MOUNT_L10N );
-
-	g_fsapi.Rescan( flags, ui_language.string );
-
-	ClearBits( fs_mount_lv.flags, FCVAR_CHANGED );
-	ClearBits( fs_mount_hd.flags, FCVAR_CHANGED );
-	ClearBits( fs_mount_addon.flags, FCVAR_CHANGED );
-	ClearBits( fs_mount_l10n.flags, FCVAR_CHANGED );
-	ClearBits( ui_language.flags, FCVAR_CHANGED );
+	FS_Rescan();
 }
 
 static void FS_ClearPaths_f( void )
@@ -110,11 +84,6 @@ static void FS_Path_f_( void )
 	FS_Path_f();
 }
 
-static void FS_MakeGameInfo_f( void )
-{
-	g_fsapi.MakeGameInfo();
-}
-
 static const fs_interface_t fs_memfuncs =
 {
 	Con_Printf,
@@ -209,23 +178,14 @@ static qboolean FS_DetermineRootDirectory( char *out, size_t size )
 #elif XASH_PSVITA
 	if( PSVita_GetBasePath( out, size ))
 		return true;
-	Sys_Error( "couldn't find %s data directory", XASH_ENGINE_NAME );
+	Sys_Error( "couldn't find Xash3D data directory" );
 	return false;
-#elif ( XASH_SDL >= 2 ) && !XASH_NSWITCH // GetBasePath not impl'd in switch-sdl2
+#elif ( XASH_SDL == 2 ) && !XASH_NSWITCH // GetBasePath not impl'd in switch-sdl2
 	path = SDL_GetBasePath();
-
-#if XASH_APPLE
-	if( path != NULL && Q_stristr( path, ".app" ))
-	{
-		SDL_free((void *)path );
-		path = SDL_GetPrefPath( NULL, XASH_ENGINE_NAME );
-	}
-#endif
-
 	if( path != NULL )
 	{
 		Q_strncpy( out, path, size );
-		SDL_free((void *)path );
+		SDL_free(( void *)path );
 		return true;
 	}
 
@@ -262,12 +222,6 @@ static qboolean FS_DetermineReadOnlyRootDirectory( char *out, size_t size )
 	return false;
 }
 
-void FS_CheckConfig( void )
-{
-	if( fs_mount_lv.value || fs_mount_hd.value || fs_mount_addon.value || fs_mount_l10n.value )
-		FS_Rescan_f();
-}
-
 /*
 ================
 FS_Init
@@ -318,21 +272,12 @@ void FS_Init( const char *basedir )
 	Cmd_AddRestrictedCommand( "fs_rescan", FS_Rescan_f, "rescan filesystem search pathes" );
 	Cmd_AddRestrictedCommand( "fs_path", FS_Path_f_, "show filesystem search pathes" );
 	Cmd_AddRestrictedCommand( "fs_clearpaths", FS_ClearPaths_f, "clear filesystem search pathes" );
-	Cmd_AddRestrictedCommand( "fs_make_gameinfo", FS_MakeGameInfo_f, "create gameinfo.txt for current running game" );
-
-	Cvar_RegisterVariable( &fs_mount_hd );
-	Cvar_RegisterVariable( &fs_mount_lv );
-	Cvar_RegisterVariable( &fs_mount_addon );
-	Cvar_RegisterVariable( &fs_mount_l10n );
 
 	if( !Sys_GetParmFromCmdLine( "-dll", host.gamedll ))
 		host.gamedll[0] = 0;
 
 	if( !Sys_GetParmFromCmdLine( "-clientlib", host.clientlib ))
 		host.clientlib[0] = 0;
-
-	if( !Sys_GetParmFromCmdLine( "-menulib", host.menulib ))
-		host.menulib[0] = 0;
 }
 
 /*

engine/common/host.c

@@ -14,6 +14,9 @@ GNU General Public License for more details.
 */
 
 #include "build.h"
+#ifdef XASH_SDL
+#include <SDL.h>
+#endif // XASH_SDL
 #include <stdarg.h>  // va_args
 #if !XASH_WIN32
 #include <unistd.h> // fork
@@ -40,27 +43,6 @@ GNU General Public License for more details.
 static pfnChangeGame	pChangeGame = NULL;
 host_parm_t		host;	// host parms
 
-#if XASH_ANDROID
-static jmp_buf return_from_main_buf;
-
-/*
-===============
-Host_ExitInMain
-
-On some platforms (e.g. Android) we can't exit with exit(3) as calling it would
-kill wrapper process (e.g. app_process) too early, before all resources would
-be freed, contexts released, files closed, etc, etc...
-
-To fix this, we create jmp_buf in Host_Main function, when jumping into with
-non-zero value will immediately return from it with `error_on_exit`.
-===============
-*/
-void Host_ExitInMain( void )
-{
-	longjmp( return_from_main_buf, 1 );
-}
-#endif // XASH_ANDROID
-
 #ifdef XASH_ENGINE_TESTS
 struct tests_stats_s tests_stats;
 #endif
@@ -137,8 +119,7 @@ static void Sys_PrintUsage( const char *exename )
 
 "\nCommon options:\n"
 	O("-dev [level]       ", "set log verbosity 0-2")
-	O("-log [file name]   ", "write log to \"engine.log\" or [file name] if specified")
-	O("-logtime           ", "enable writing timestamps to the log file")
+	O("-log               ", "write log to \"engine.log\"")
 	O("-nowriteconfig     ", "disable config save")
 	O("-noch              ", "disable crashhandler")
 #if XASH_WIN32 // !!!!
@@ -174,7 +155,6 @@ static void Sys_PrintUsage( const char *exename )
 	O("-dll <path>        ", "override server DLL path")
 #if !XASH_DEDICATED
 	O("-clientlib <path>  ", "override client DLL path")
-	O("-menulib <path>    ", "override menu DLL path")
 	O("-console           ", "run engine with console enabled")
 	O("-toconsole         ", "run engine witn console open")
 	O("-oldfont           ", "enable unused Quake font in Half-Life")
@@ -200,6 +180,7 @@ static void Sys_PrintUsage( const char *exename )
 	O("-daemonize         ", "run engine as a daemon")
 #endif
 #if XASH_SDL == 2
+	O("-sdl_joy_old_api   ","use SDL legacy joystick API")
 	O("-sdl_renderer <n>  ","use alternative SDL_Renderer for software")
 #endif // XASH_SDL
 #if XASH_ANDROID && !XASH_SDL
@@ -228,7 +209,7 @@ static void Sys_PrintUsage( const char *exename )
 	fprintf( stderr, usage_str, exename );
 #endif
 
-	Sys_Quit( NULL );
+	Sys_Quit();
 }
 
 static void Sys_PrintBugcompUsage( const char *exename )
@@ -253,7 +234,12 @@ static void Sys_PrintBugcompUsage( const char *exename )
 	fprintf( stderr, usage_str, exename );
 #endif
 
-	Sys_Quit( NULL );
+	Sys_Quit();
+}
+
+void Host_ShutdownServer( void )
+{
+	SV_Shutdown( "Server was killed\n" );
 }
 
 /*
@@ -381,8 +367,9 @@ static void Host_NewInstance( const char *name, const char *finalmsg )
 	if( !pChangeGame ) return;
 
 	host.change_game = true;
+	Q_strncpy( host.finalmsg, finalmsg, sizeof( host.finalmsg ));
 
-	if( !Sys_NewInstance( name, finalmsg ))
+	if( !Sys_NewInstance( name ))
 		pChangeGame( name ); // call from hl.exe
 }
 
@@ -436,7 +423,8 @@ static void Host_Exec_f( void )
 {
 	string cfgpath;
 	byte *f;
-	fs_offset_t len;
+	char *txt;
+	fs_offset_t	len;
 
 	if( Cmd_Argc() != 2 )
 	{
@@ -491,29 +479,20 @@ static void Host_Exec_f( void )
 		return;
 	}
 
-	// len is fs_offset_t, which can be larger than size_t
-	if( len >= SIZE_MAX )
-	{
-		Con_Reportf( "%s: %s is too long\n", __func__, Cmd_Argv( 1 ));
-		return;
-	}
-
 	if( !Q_stricmp( "config.cfg", cfgpath ))
 		host.config_executed = true;
 
+	// adds \n\0 at end of the file
+	txt = Z_Calloc( len + 2 );
+	memcpy( txt, f, len );
+	txt[len] = '\n';
+	txt[len + 1] = '\0';
+	Mem_Free( f );
+
 	if( !host.apply_game_config )
 		Con_Printf( "execing %s\n", Cmd_Argv( 1 ));
-
-	// adds \n at end of the file
-	// FS_LoadFile always null terminates
-	if( f[len - 1] != '\n' )
-	{
-		Cbuf_InsertTextLen( f, len, len + 1 );
-		Cbuf_InsertTextLen( "\n", 1, 1 );
-	}
-	else Cbuf_InsertTextLen( f, len, len );
-
-	Mem_Free( f );
+	Cbuf_InsertText( txt );
+	Mem_Free( txt );
 }
 
 /*
@@ -539,6 +518,13 @@ static void Host_MemStats_f( void )
 	}
 }
 
+static void Host_Minimize_f( void )
+{
+#ifdef XASH_SDL
+	if( host.hWnd ) SDL_MinimizeWindow( host.hWnd );
+#endif
+}
+
 /*
 =================
 Host_RegisterDecal
@@ -609,7 +595,7 @@ static void Host_GetCommands( void )
 {
 	char	*cmd;
 
-	while( ( cmd = Platform_Input() ) )
+	while( ( cmd = Sys_Input() ) )
 	{
 		Cbuf_AddText( cmd );
 		Cbuf_Execute();
@@ -689,17 +675,17 @@ static qboolean Host_Autosleep( double dt, double scale )
 		static double timewindow; // allocate a time window for sleeps
 		static int counter; // for debug
 		static double realsleeptime;
-		const double sleeptime = sleep * 0.000001;
+		const double sleeptime = sleep * 0.001;
 
 		if( dt < targetframetime * scale )
 		{
 			// if we have allocated time window, try to sleep
 			if( timewindow > realsleeptime )
 			{
-				// Platform_Sleep isn't guaranteed to sleep an exact amount of microseconds
+				// Platform_Sleep isn't guaranteed to sleep an exact amount of milliseconds
 				// so we measure the real sleep time and use it to decrease the window
 				double t1 = Sys_DoubleTime(), t2;
-				Platform_NanoSleep( sleep * 1000 ); // in usec!
+				Platform_Sleep( sleep ); // in msec!
 				t2 = Sys_DoubleTime();
 				realsleeptime = t2 - t1;
 
@@ -828,11 +814,11 @@ void GAME_EXPORT Host_Error( const char *error, ... )
 	}
 	else
 	{
-		Con_Printf( "%s: %s", __func__, hosterror1 );
 		if( host.allow_console )
 		{
 			UI_SetActiveMenu( false );
 			Key_SetKeyDest( key_console );
+			Con_Printf( "%s: %s", __func__, hosterror1 );
 		}
 		else Platform_MessageBox( "Host Error", hosterror1, true );
 	}
@@ -849,12 +835,13 @@ void GAME_EXPORT Host_Error( const char *error, ... )
 	recursive = true;
 	Q_strncpy( hosterror2, hosterror1, sizeof( hosterror2 ));
 	host.errorframe = host.framecount; // to avoid multply calls per frame
+	Q_snprintf( host.finalmsg, sizeof( host.finalmsg ), "Server crashed: %s", hosterror1 );
 
 	// clearing cmd buffer to prevent execute any commands
 	COM_InitHostState();
 	Cbuf_Clear();
 
-	SV_Shutdown( "Server was killed due to an error\n" );
+	Host_ShutdownServer();
 	CL_Drop(); // drop clients
 
 	// recreate world if needs
@@ -933,7 +920,7 @@ static void Host_RunTests( int stage )
 #endif
 		Msg( "Done! %d passed, %d failed\n", tests_stats.passed, tests_stats.failed );
 		error_on_exit = tests_stats.failed > 0 ? EXIT_FAILURE : EXIT_SUCCESS;
-		Sys_Quit( NULL );
+		Sys_Quit();
 	}
 }
 #endif
@@ -1035,7 +1022,7 @@ static void Host_InitCommon( int argc, char **argv, const char *progname, qboole
 	}
 
 	if( !Sys_CheckParm( "-noch" ))
-		Sys_SetupCrashHandler( argv[0] );
+		Sys_SetupCrashHandler();
 
 #if XASH_DLL_LOADER
 	host.enabledll = !Sys_CheckParm( "-nodll" );
@@ -1122,7 +1109,7 @@ static void Host_InitCommon( int argc, char **argv, const char *progname, qboole
 #if XASH_DEDICATED
 	Platform_SetupSigtermHandling();
 #endif
-	Platform_Init( Host_IsDedicated( ) || developer >= DEV_EXTENDED, basedir );
+	Platform_Init( Host_IsDedicated( ) || developer >= DEV_EXTENDED );
 	FS_Init( basedir );
 
 	Sys_InitLog();
@@ -1180,11 +1167,6 @@ static void Host_FreeCommon( void )
 	FS_Shutdown();
 }
 
-static void Sys_Quit_f( void )
-{
-	Sys_Quit( "command" );
-}
-
 /*
 =================
 Host_Main
@@ -1224,17 +1206,9 @@ int EXPORT Host_Main( int argc, char **argv, const char *progname, int bChangeGa
 
 	Cvar_Getf( "buildnum", FCVAR_READ_ONLY, "returns a current build number", "%i", Q_buildnum_compat());
 	Cvar_Getf( "ver", FCVAR_READ_ONLY, "shows an engine version", "%i/%s (hw build %i)", PROTOCOL_VERSION, XASH_COMPAT_VERSION, Q_buildnum_compat());
-	Cvar_Getf( "host_ver", FCVAR_READ_ONLY, "detailed info about this build", "%i " XASH_VERSION " %s %s %s", Q_buildnum(), Q_buildos(), Q_buildarch(), g_buildcommit);
+	Cvar_Getf( "host_ver", FCVAR_READ_ONLY, "detailed info about this build", "%i " XASH_VERSION " %s %s %s", Q_buildnum(), Q_buildos(), Q_buildarch(), Q_buildcommit());
 	Cvar_Getf( "host_lowmemorymode", FCVAR_READ_ONLY, "indicates if engine compiled for low RAM consumption (0 - normal, 1 - low engine limits, 2 - low protocol limits)", "%i", XASH_LOW_MEMORY );
 
-	Cvar_Get( "host_hl25_extended_structs",
-#if SUPPORT_HL25_EXTENDED_STRUCTS
-		"1",
-#else
-		"0",
-#endif
-		FCVAR_READ_ONLY, "indicates if engine was compiled with extended msurface_t struct" );
-
 	Mod_Init();
 	NET_Init();
 	NET_InitMasters();
@@ -1255,6 +1229,7 @@ int EXPORT Host_Main( int argc, char **argv, const char *progname, int bChangeGa
 	CL_Init();
 
 	HTTP_Init();
+	ID_Init();
 	SoundList_Init();
 
 	if( Host_IsDedicated( ))
@@ -1266,10 +1241,10 @@ int EXPORT Host_Main( int argc, char **argv, const char *progname, int bChangeGa
 		// disable texture replacements for dedicated
 		Cvar_FullSet( "host_allow_materials", "0", FCVAR_READ_ONLY );
 
-		Cmd_AddRestrictedCommand( "quit", Sys_Quit_f, "quit the game" );
-		Cmd_AddRestrictedCommand( "exit", Sys_Quit_f, "quit the game" );
+		Cmd_AddRestrictedCommand( "quit", Sys_Quit, "quit the game" );
+		Cmd_AddRestrictedCommand( "exit", Sys_Quit, "quit the game" );
 	}
-	else Cmd_AddRestrictedCommand( "minimize", Platform_Minimize_f, "minimize main window to tray" );
+	else Cmd_AddRestrictedCommand( "minimize", Host_Minimize_f, "minimize main window to tray" );
 
 	host.errorframe = 0;
 
@@ -1310,7 +1285,6 @@ int EXPORT Host_Main( int argc, char **argv, const char *progname, int bChangeGa
 	Cmd_RemoveCommand( "setgl" );
 	Cbuf_ExecStuffCmds();	// execute stuffcmds (commandline)
 	SCR_CheckStartupVids();	// must be last
-	FS_CheckConfig();
 
 	if( Sys_GetParmFromCmdLine( "-timedemo", demoname ))
 		Cbuf_AddTextf( "timedemo %s\n", demoname );
@@ -1339,13 +1313,8 @@ int EXPORT Host_Main( int argc, char **argv, const char *progname, int bChangeGa
 	// check after all configs were executed
 	HPAK_CheckIntegrity( hpk_custom_file.string );
 
-#if XASH_ANDROID
-	if( setjmp( return_from_main_buf ))
-		return error_on_exit;
-#endif // XASH_ANDROID
-
 	// main window message loop
-	while( host.status != HOST_CRASHED )
+	while( !host.crashed )
 	{
 		newtime = Sys_DoubleTime ();
 		COM_Frame( newtime - oldtime );
@@ -1356,31 +1325,20 @@ int EXPORT Host_Main( int argc, char **argv, const char *progname, int bChangeGa
 	return 0;
 }
 
-void EXPORT Host_Shutdown( void );
-void EXPORT Host_Shutdown( void )
-{
-	Host_ShutdownWithReason( "launcher shutdown" );
-}
-
 /*
 =================
 Host_Shutdown
 =================
 */
-void Host_ShutdownWithReason( const char *reason )
+void EXPORT Host_Shutdown( void )
 {
 	qboolean error = host.status == HOST_ERR_FATAL;
 
-	if( host.shutdown_issued )
-		return;
-
+	if( host.shutdown_issued ) return;
 	host.shutdown_issued = true;
 
-	if( reason != NULL )
-		Con_Printf( S_NOTE "Issuing host shutdown due to reason \"%s\"\n", reason );
-
-	if( host.status != HOST_ERR_FATAL )
-		host.status = HOST_SHUTDOWN; // prepare host to normal shutdown
+	if( host.status != HOST_ERR_FATAL ) host.status = HOST_SHUTDOWN; // prepare host to normal shutdown
+	if( !host.change_game ) Q_strncpy( host.finalmsg, "Server shutdown", sizeof( host.finalmsg ));
 
 #if !XASH_DEDICATED
 	if( host.type == HOST_NORMAL && !error )
@@ -1399,14 +1357,10 @@ void Host_ShutdownWithReason( const char *reason )
 	Host_FreeCommon();
 	Platform_Shutdown();
 
-	BaseCmd_Shutdown();
-	Cmd_Shutdown();
-	Cvar_Shutdown();
-
 	// must be last, console uses this
 	Mem_FreePool( &host.mempool );
 
 	// restore filter
 	Sys_RestoreCrashHandler();
-	Sys_CloseLog( reason );
+	Sys_CloseLog();
 }

engine/common/hpak.c

@@ -38,7 +38,7 @@ static void HPAK_MaxSize_f( void )
 	Con_Printf( S_ERROR "hpk_maxsize is deprecated, use hpk_max_size\n" );
 }
 
-const char *COM_ResourceTypeFromIndex( int type )
+static const char *HPAK_TypeFromIndex( int type )
 {
 	switch( type )
 	{
@@ -104,7 +104,7 @@ static void HPAK_CreatePak( const char *filename, resource_t *pResource, byte *p
 	string		pakname;
 	byte		md5[16];
 	file_t		*fout;
-	MD5Context_t	ctx = { 0 };
+	MD5Context_t	ctx;
 
 	if( !COM_CheckString( filename ))
 		return;
@@ -125,6 +125,7 @@ static void HPAK_CreatePak( const char *filename, resource_t *pResource, byte *p
 	}
 
 	// let's hash it.
+	memset( &ctx, 0, sizeof( MD5Context_t ));
 	MD5Init( &ctx );
 
 	if( pData == NULL )
@@ -213,18 +214,19 @@ void HPAK_AddLump( qboolean bUseQueue, const char *name, resource_t *pResource,
 	file_t		*file_src;
 	file_t		*file_dst;
 	byte		md5[16];
-	MD5Context_t	ctx = { 0 };
+	MD5Context_t	ctx;
 
 	if( pData == NULL && pFile == NULL )
 		return;
 
 	if( pResource->nDownloadSize < HPAK_ENTRY_MIN_SIZE || pResource->nDownloadSize > HPAK_ENTRY_MAX_SIZE )
 	{
-		Con_Printf( S_ERROR "%s: invalid size %s\n", name, Q_memprint( pResource->nDownloadSize ));
+		Con_Printf( S_ERROR "%s: invalid size %s\n", name, Q_pretifymem( pResource->nDownloadSize, 2 ));
 		return;
 	}
 
 	// hash it
+	memset( &ctx, 0, sizeof( MD5Context_t ));
 	MD5Init( &ctx );
 
 	if( !pData )
@@ -441,7 +443,7 @@ static qboolean HPAK_Validate( const char *filename, qboolean quiet, qboolean de
 		if( dataDir[i].disksize < HPAK_ENTRY_MIN_SIZE || dataDir[i].disksize > HPAK_ENTRY_MAX_SIZE )
 		{
 			// odd max size
-			Con_DPrintf( S_ERROR "%s: lump %i has invalid size %s\n", __func__, i, Q_memprint( dataDir[i].disksize ));
+			Con_DPrintf( S_ERROR "%s: lump %i has invalid size %s\n", __func__, i, Q_pretifymem( dataDir[i].disksize, 2 ));
 			Mem_Free( dataDir );
 			FS_Close( f );
 			if( delete ) FS_Delete( pakname );
@@ -461,8 +463,8 @@ static qboolean HPAK_Validate( const char *filename, qboolean quiet, qboolean de
 
 		if( !quiet )
 		{
-			Con_Printf( "%i:      %s %s %s:   ", i, COM_ResourceTypeFromIndex( pRes->type ),
-				Q_memprint( pRes->nDownloadSize ), pRes->szFileName );
+			Con_Printf( "%i:      %s %s %s:   ", i, HPAK_TypeFromIndex( pRes->type ),
+				Q_pretifymem( pRes->nDownloadSize, 2 ), pRes->szFileName );
 		}
 
 		if( memcmp( md5, pRes->rgucMD5_hash, 0x10 ))
@@ -942,7 +944,7 @@ static void HPAK_List_f( void )
 	{
 		entry = &directory.entries[nCurrent];
 		COM_FileBase( entry->resource.szFileName, lumpname, sizeof( lumpname ));
-		type = COM_ResourceTypeFromIndex( entry->resource.type );
+		type = HPAK_TypeFromIndex( entry->resource.type );
 		size = Q_memprint( entry->resource.nDownloadSize );
 
 		Con_Printf( "%i: %10s %s %s\n  :  %s\n", nCurrent + 1, type, size, lumpname, MD5_Print( entry->resource.rgucMD5_hash ));
@@ -1037,7 +1039,7 @@ static void HPAK_Extract_f( void )
 			continue;
 
 		COM_FileBase( entry->resource.szFileName, lumpname, sizeof( lumpname ) );
-		type = COM_ResourceTypeFromIndex( entry->resource.type );
+		type = HPAK_TypeFromIndex( entry->resource.type );
 		size = Q_memprint( entry->resource.nDownloadSize );
 
 		Con_Printf( "Extracting %i: %10s %s %s\n", nCurrent + 1, type, size, lumpname );

engine/common/identification.c

@@ -19,8 +19,8 @@ GNU General Public License for more details.
 #if !XASH_WIN32
 #include <dirent.h>
 #endif
-
 static char id_md5[33];
+static char id_customid[MAX_STRING];
 
 /*
 ==========================================================
@@ -365,10 +365,10 @@ static int ID_GetKeyData( HKEY hRootKey, char *subKey, char *value, LPBYTE data,
 {
 	HKEY hKey;
 
-	if( RegOpenKeyExA( hRootKey, subKey, 0, KEY_QUERY_VALUE, &hKey ) != ERROR_SUCCESS )
+	if( RegOpenKeyEx( hRootKey, subKey, 0, KEY_QUERY_VALUE, &hKey ) != ERROR_SUCCESS )
 		return 0;
 
-	if( RegQueryValueExA( hKey, value, NULL, NULL, data, &cbData ) != ERROR_SUCCESS )
+	if( RegQueryValueEx( hKey, value, NULL, NULL, data, &cbData ) != ERROR_SUCCESS )
 	{
 		RegCloseKey( hKey );
 		return 0;
@@ -377,14 +377,13 @@ static int ID_GetKeyData( HKEY hRootKey, char *subKey, char *value, LPBYTE data,
 	RegCloseKey( hKey );
 	return 1;
 }
-
-static int ID_SetKeyData( HKEY hRootKey, char *subKey, DWORD dwType, char *value, LPBYTE data, DWORD cbData )
+static int ID_SetKeyData( HKEY hRootKey, char *subKey, DWORD dwType, char *value, LPBYTE data, DWORD cbData)
 {
 	HKEY hKey;
-	if( RegCreateKeyA( hRootKey, subKey, &hKey ) != ERROR_SUCCESS )
+	if( RegCreateKey( hRootKey, subKey, &hKey ) != ERROR_SUCCESS )
 		return 0;
 
-	if( RegSetValueExA( hKey, value, 0, dwType, data, cbData ) != ERROR_SUCCESS )
+	if( RegSetValueEx( hKey, value, 0, dwType, data, cbData ) != ERROR_SUCCESS )
 	{
 		RegCloseKey( hKey );
 		return 0;
@@ -396,7 +395,7 @@ static int ID_SetKeyData( HKEY hRootKey, char *subKey, DWORD dwType, char *value
 
 #define BUFSIZE 4096
 
-static int ID_RunWMIC( char *buffer, const wchar_t *cmdline )
+static int ID_RunWMIC(char *buffer, const char *cmdline)
 {
 	HANDLE g_IN_Rd = NULL;
 	HANDLE g_IN_Wr = NULL;
@@ -404,92 +403,75 @@ static int ID_RunWMIC( char *buffer, const wchar_t *cmdline )
 	HANDLE g_OUT_Wr = NULL;
 	DWORD dwRead;
 	BOOL bSuccess = FALSE;
-	wchar_t *cmdline_copy;
+	SECURITY_ATTRIBUTES saAttr;
 
-	PROCESS_INFORMATION pi = { 0 };
-	SECURITY_ATTRIBUTES saAttr =
-	{
-		.nLength = sizeof( SECURITY_ATTRIBUTES ),
-		.bInheritHandle = TRUE,
-		.lpSecurityDescriptor = NULL,
-	};
+	STARTUPINFO si = {0};
+
+	PROCESS_INFORMATION pi = {0};
+	saAttr.nLength = sizeof(SECURITY_ATTRIBUTES);
+	saAttr.bInheritHandle = TRUE;
+	saAttr.lpSecurityDescriptor = NULL;
 
 	CreatePipe( &g_IN_Rd, &g_IN_Wr, &saAttr, 0 );
 	CreatePipe( &g_OUT_Rd, &g_OUT_Wr, &saAttr, 0 );
 	SetHandleInformation( g_IN_Wr, HANDLE_FLAG_INHERIT, 0 );
 
-	STARTUPINFO si =
-	{
-		.cb = sizeof( STARTUPINFO ),
-		.dwFlags = STARTF_USESTDHANDLES,
-		.hStdInput = g_IN_Rd,
-		.hStdOutput = g_OUT_Wr,
-		.hStdError = g_OUT_Wr,
-		.wShowWindow = SW_HIDE,
-		.dwFlags = STARTF_USESTDHANDLES,
-	};
+	si.cb = sizeof(STARTUPINFO);
+	si.dwFlags = STARTF_USESTDHANDLES;
+	si.hStdInput = g_IN_Rd;
+	si.hStdOutput = g_OUT_Wr;
+	si.hStdError = g_OUT_Wr;
+	si.wShowWindow = SW_HIDE;
+	si.dwFlags |= STARTF_USESTDHANDLES;
 
-	cmdline_copy = malloc( wcslen( cmdline ) * sizeof( *cmdline_copy ));
+	CreateProcess( NULL, (char*)cmdline, NULL, NULL, true, CREATE_NO_WINDOW , NULL, NULL, &si, &pi );
 
-	if( !CreateProcessW( NULL, cmdline_copy, NULL, NULL, true, CREATE_NO_WINDOW, NULL, NULL, &si, &pi ))
-		goto err;
+	CloseHandle( g_OUT_Wr );
+	CloseHandle( g_IN_Wr );
 
 	WaitForSingleObject( pi.hProcess, 500 );
 
 	bSuccess = ReadFile( g_OUT_Rd, buffer, BUFSIZE, &dwRead, NULL );
 	buffer[BUFSIZE-1] = 0;
-
-	TerminateProcess( pi.hProcess, 0 );
-
-	CloseHandle( pi.hProcess );
-	CloseHandle( pi.hThread );
-
-err:
-	CloseHandle( g_IN_Wr );
-	CloseHandle( g_OUT_Wr );
 	CloseHandle( g_IN_Rd );
 	CloseHandle( g_OUT_Rd );
 
-	free( cmdline_copy );
-
 	return bSuccess;
 }
 
-static int ID_ProcessWMIC( bloomfilter_t *value, const wchar_t *cmdline )
+static int ID_ProcessWMIC( bloomfilter_t *value, const char *cmdline )
 {
 	char buffer[BUFSIZE], token[BUFSIZE], *pbuf;
 	int count = 0;
 
-	if( !ID_RunWMIC( buffer, cmdline ))
+	if( !ID_RunWMIC( buffer, cmdline ) )
 		return 0;
-
 	pbuf = COM_ParseFile( buffer, token, sizeof( token )); // Header
-	while( pbuf = COM_ParseFile( pbuf, token, sizeof( token )))
+	while( pbuf = COM_ParseFile( pbuf, token, sizeof( token ) ) )
 	{
-		if( !ID_VerifyHEX( token ))
+		if( !ID_VerifyHEX( token ) )
 			continue;
 
 		*value |= BloomFilter_ProcessStr( token );
-		count++;
+		count ++;
 	}
 
 	return count;
 }
 
-static int ID_CheckWMIC( bloomfilter_t value, const wchar_t *cmdline )
+static int ID_CheckWMIC( bloomfilter_t value, const char *cmdline )
 {
 	char buffer[BUFSIZE], token[BUFSIZE], *pbuf;
 	int count = 0;
 
-	if( !ID_RunWMIC( buffer, cmdline ))
+	if( !ID_RunWMIC( buffer, cmdline ) )
 		return 0;
-
 	pbuf = COM_ParseFile( buffer, token, sizeof( token )); // Header
-	while( pbuf = COM_ParseFile( pbuf, token, sizeof( token )))
+	while( pbuf = COM_ParseFile( pbuf, token, sizeof( token ) ) )
 	{
 		bloomfilter_t filter;
 
-		if( !ID_VerifyHEX( token ))
+		if( !ID_VerifyHEX( token ) )
 			continue;
 
 		filter = BloomFilter_ProcessStr( token );
@@ -505,10 +487,6 @@ static int ID_CheckWMIC( bloomfilter_t value, const wchar_t *cmdline )
 char *IOS_GetUDID( void );
 #endif
 
-#if XASH_PSVITA
-int PSVita_GetPSID( char *buf, const size_t buflen );
-#endif
-
 static bloomfilter_t ID_GenerateRawId( void )
 {
 	bloomfilter_t value = 0;
@@ -530,22 +508,14 @@ static bloomfilter_t ID_GenerateRawId( void )
 	count += ID_ProcessNetDevices( &value );
 #endif
 #if XASH_WIN32
-	count += ID_ProcessWMIC( &value, L"wmic path win32_physicalmedia get SerialNumber " );
-	count += ID_ProcessWMIC( &value, L"wmic bios get serialnumber " );
+	count += ID_ProcessWMIC( &value, "wmic path win32_physicalmedia get SerialNumber " );
+	count += ID_ProcessWMIC( &value, "wmic bios get serialnumber " );
 #endif
 #if XASH_IOS
 	{
 		value |= BloomFilter_ProcessStr(IOS_GetUDID());
 		count ++;
 	}
-#endif
-#if XASH_PSVITA
-	{
-		char data[16];
-		PSVita_GetPSID( data, sizeof( data ));
-		value |= BloomFilter_Process( data, sizeof( data ));
-		count ++;
-	}
 #endif
 	return value;
 }
@@ -574,8 +544,8 @@ static uint ID_CheckRawId( bloomfilter_t filter )
 #endif
 
 #if XASH_WIN32
-	count += ID_CheckWMIC( filter, L"wmic path win32_physicalmedia get SerialNumber" );
-	count += ID_CheckWMIC( filter, L"wmic bios get serialnumber" );
+	count += ID_CheckWMIC( filter, "wmic path win32_physicalmedia get SerialNumber" );
+	count += ID_CheckWMIC( filter, "wmic bios get serialnumber" );
 #endif
 
 #if XASH_IOS
@@ -585,15 +555,6 @@ static uint ID_CheckRawId( bloomfilter_t filter )
 		value = 0;
 	}
 #endif
-#if XASH_PSVITA
-	{
-		char data[16];
-		PSVita_GetPSID( data, sizeof( data ));
-		value = BloomFilter_Process( data, sizeof( data ));
-		count += (filter & value) == value;
-		value = 0;
-	}
-#endif
 #if 0
 	Msg( "%s: %d\n", __func__, count );
 #endif
@@ -629,12 +590,28 @@ static void ID_Check( void )
 
 const char *ID_GetMD5( void )
 {
+	if( id_customid[0] )
+		return id_customid;
 	return id_md5;
 }
 
+/*
+===============
+ID_SetCustomClientID
+
+===============
+*/
+void GAME_EXPORT ID_SetCustomClientID( const char *id )
+{
+	if( !id )
+		return;
+
+	Q_strncpy( id_customid, id, sizeof( id_customid  ) );
+}
+
 void ID_Init( void )
 {
-	MD5Context_t hash = { 0 };
+	MD5Context_t hash = {0};
 	byte md5[16];
 	int i;
 
@@ -655,7 +632,7 @@ void ID_Init( void )
 #elif XASH_WIN32
 	{
 		CHAR szBuf[MAX_PATH];
-		ID_GetKeyData( HKEY_CURRENT_USER, "Software\\"XASH_ENGINE_NAME"\\", "xash_id", szBuf, MAX_PATH );
+		ID_GetKeyData( HKEY_CURRENT_USER, "Software\\Xash3D\\", "xash_id", szBuf, MAX_PATH );
 
 		sscanf(szBuf, "%016"PRIX64, &id);
 		id ^= SYSTEM_XOR_MASK;
@@ -709,7 +686,7 @@ void ID_Init( void )
 	{
 		CHAR Buf[MAX_PATH];
 		sprintf( Buf, "%016"PRIX64, id^SYSTEM_XOR_MASK );
-		ID_SetKeyData( HKEY_CURRENT_USER, "Software\\"XASH_ENGINE_NAME"\\", REG_SZ, "xash_id", Buf, Q_strlen(Buf) );
+		ID_SetKeyData( HKEY_CURRENT_USER, "Software\\Xash3D\\", REG_SZ, "xash_id", Buf, Q_strlen(Buf) );
 	}
 #else
 	{

engine/common/imagelib/imagelib.h

@@ -45,6 +45,7 @@ typedef enum
 
 typedef struct loadformat_s
 {
+	const char *formatstring;
 	const char *ext;
 	qboolean (*loadfunc)( const char *name, const byte *buffer, fs_offset_t filesize );
 	image_hint_t hint;
@@ -52,6 +53,7 @@ typedef struct loadformat_s
 
 typedef struct saveformat_s
 {
+	const char *formatstring;
 	const char *ext;
 	qboolean (*savefunc)( const char *name, rgbdata_t *pix );
 } savepixformat_t;

engine/common/imagelib/img_main.c

@@ -15,7 +15,6 @@ GNU General Public License for more details.
 
 #include <math.h>
 #include "imagelib.h"
-#include "eiface.h" // ARRAYSIZE
 
 // global image variables
 imglib_t	image;
@@ -68,6 +67,7 @@ static const cubepack_t load_cubemap[] =
 { "3Ds Sky1", skybox_qv1 },
 { "3Ds Sky2", skybox_qv2 },
 { "3Ds Cube", cubemap_v1 },
+{ NULL, NULL },
 };
 
 // soul of ImageLib - table of image format constants
@@ -211,7 +211,7 @@ static const loadpixformat_t *Image_GetLoadFormatForExtension( const char *ext )
 	if( !COM_CheckStringEmpty( ext ))
 		return NULL;
 
-	for( format = image.loadformats; format->ext; format++ )
+	for( format = image.loadformats; format->formatstring; format++ )
 	{
 		if( !Q_stricmp( ext, format->ext ))
 			return format;
@@ -237,7 +237,7 @@ static qboolean Image_ProbeLoadBuffer( const loadpixformat_t *fmt, const char *n
 	// bruteforce all loaders
 	if( !fmt )
 	{
-		for( fmt = image.loadformats; fmt->ext; fmt++ )
+		for( fmt = image.loadformats; fmt->formatstring; fmt++ )
 		{
 			if( Image_ProbeLoadBuffer_( fmt, name, buf, size, override_hint ))
 				 return true;
@@ -256,7 +256,7 @@ static qboolean Image_ProbeLoad_( const loadpixformat_t *fmt, const char *name,
 	string path;
 	byte *f;
 
-	Q_snprintf( path, sizeof( path ), "%s%s.%s", name, suffix, fmt->ext );
+	Q_snprintf( path, sizeof( path ), fmt->formatstring, name, suffix, fmt->ext );
 	f = FS_LoadFile( path, &filesize, false );
 
 	if( f )
@@ -274,7 +274,7 @@ static qboolean Image_ProbeLoad( const loadpixformat_t *fmt, const char *name, c
 	if( !fmt )
 	{
 		// bruteforce all formats to allow implicit extension
-		for( fmt = image.loadformats; fmt->ext; fmt++ )
+		for( fmt = image.loadformats; fmt->formatstring; fmt++ )
 		{
 			if( Image_ProbeLoad_( fmt, name, suffix, override_hint ))
 				return true;
@@ -297,8 +297,9 @@ rgbdata_t *FS_LoadImage( const char *filename, const byte *buffer, size_t size )
 {
 	const char	*ext = COM_FileExtension( filename );
 	string		loadname;
-	int		i, j;
+	int		i;
 	const loadpixformat_t *extfmt;
+	const cubepack_t	*cmap;
 
 	Q_strncpy( loadname, filename, sizeof( loadname ));
 	Image_Reset(); // clear old image
@@ -316,10 +317,8 @@ rgbdata_t *FS_LoadImage( const char *filename, const byte *buffer, size_t size )
 		return ImagePack();
 
 	// check all cubemap sides with package suffix
-	for( j = 0; j < ARRAYSIZE( load_cubemap ); j++ )
+	for( cmap = load_cubemap; cmap && cmap->type; cmap++ )
 	{
-		const cubepack_t	*cmap = &load_cubemap[j];
-
 		for( i = 0; i < 6; i++ )
 		{
 			if( Image_ProbeLoad( extfmt, loadname, cmap->type[i].suf, cmap->type[i].hint ))
@@ -417,13 +416,14 @@ qboolean FS_SaveImage( const char *filename, rgbdata_t *pix )
 		picBuffer = pix->buffer;
 
 		// save all sides seperately
-		for( format = image.saveformats; format && format->ext; format++ )
+		for( format = image.saveformats; format && format->formatstring; format++ )
 		{
 			if( !Q_stricmp( ext, format->ext ))
 			{
 				for( i = 0; i < 6; i++ )
 				{
-					Q_snprintf( path, sizeof( path ), "%s%s.%s", savename, box[i].suf, format->ext );
+					Q_snprintf( path, sizeof( path ),
+						format->formatstring, savename, box[i].suf, format->ext );
 					if( !format->savefunc( path, pix )) break; // there were errors
 					pix->buffer += pix->size; // move pointer
 				}
@@ -441,11 +441,12 @@ qboolean FS_SaveImage( const char *filename, rgbdata_t *pix )
 	}
 	else
 	{
-		for( format = image.saveformats; format && format->ext; format++ )
+		for( format = image.saveformats; format && format->formatstring; format++ )
 		{
 			if( !Q_stricmp( ext, format->ext ))
 			{
-				Q_snprintf( path, sizeof( path ), "%s.%s", savename, format->ext );
+				Q_snprintf( path, sizeof( path ),
+					format->formatstring, savename, "", format->ext );
 				if( format->savefunc( path, pix ))
 				{
 					// clear any force flags

engine/common/imagelib/img_png.c

@@ -46,7 +46,7 @@ qboolean Image_LoadPNG( const char *name, const byte *buffer, fs_offset_t filesi
 	short		p, a, b, c, pa, pb, pc;
 	byte		*buf_p, *pixbuf, *raw, *prior, *idat_buf = NULL, *uncompressed_buffer = NULL;
 	byte		*pallete = NULL, *trns = NULL;
-	uint	 	chunk_len, trns_len = 0, plte_len = 0, crc32, crc32_check, oldsize = 0, newsize = 0, rowsize;
+	uint	 	chunk_len, trns_len, plte_len, crc32, crc32_check, oldsize = 0, newsize = 0, rowsize;
 	uint		uncompressed_size, pixel_size, pixel_count, i, y, filter_type, chunk_sign, r_alpha, g_alpha, b_alpha;
 	qboolean 	has_iend_chunk = false;
 	z_stream 	stream = {0};

engine/common/imagelib/img_utils.c

@@ -90,23 +90,23 @@ static byte palette_hl[768] =
 // stub
 static const loadpixformat_t load_null[] =
 {
-{ NULL, NULL, IL_HINT_NO }
+{ NULL, NULL, NULL, IL_HINT_NO }
 };
 
 static const loadpixformat_t load_game[] =
 {
-{ "dds", Image_LoadDDS, IL_HINT_NO },   // dds for world and studio models
-{ "bmp", Image_LoadBMP, IL_HINT_NO },   // WON menu images
-{ "tga", Image_LoadTGA, IL_HINT_NO },   // hl vgui menus
-{ "png", Image_LoadPNG, IL_HINT_NO },   // NightFire 007 menus
-{ "mip", Image_LoadMIP, IL_HINT_NO },   // hl textures from wad or buffer
-{ "mdl", Image_LoadMDL, IL_HINT_HL },   // hl studio model skins
-{ "spr", Image_LoadSPR, IL_HINT_HL },   // hl sprite frames
-{ "lmp", Image_LoadLMP, IL_HINT_NO },   // hl menu images (cached.wad etc)
-{ "fnt", Image_LoadFNT, IL_HINT_HL },   // hl console font (fonts.wad etc)
-{ "pal", Image_LoadPAL, IL_HINT_NO },   // install studio\sprite palette
-{ "ktx2", Image_LoadKTX2, IL_HINT_NO }, // ktx2 for world and studio models
-{ NULL, NULL, IL_HINT_NO }
+{ "%s%s.%s", "dds", Image_LoadDDS, IL_HINT_NO },	// dds for world and studio models
+{ "%s%s.%s", "bmp", Image_LoadBMP, IL_HINT_NO },	// WON menu images
+{ "%s%s.%s", "tga", Image_LoadTGA, IL_HINT_NO },	// hl vgui menus
+{ "%s%s.%s", "png", Image_LoadPNG, IL_HINT_NO },	// NightFire 007 menus
+{ "%s%s.%s", "mip", Image_LoadMIP, IL_HINT_NO },	// hl textures from wad or buffer
+{ "%s%s.%s", "mdl", Image_LoadMDL, IL_HINT_HL },	// hl studio model skins
+{ "%s%s.%s", "spr", Image_LoadSPR, IL_HINT_HL },	// hl sprite frames
+{ "%s%s.%s", "lmp", Image_LoadLMP, IL_HINT_NO },	// hl menu images (cached.wad etc)
+{ "%s%s.%s", "fnt", Image_LoadFNT, IL_HINT_HL },	// hl console font (fonts.wad etc)
+{ "%s%s.%s", "pal", Image_LoadPAL, IL_HINT_NO },	// install studio\sprite palette
+{ "%s%s.%s", "ktx2", Image_LoadKTX2, IL_HINT_NO },	// ktx2 for world and studio models
+{ NULL, NULL, NULL, IL_HINT_NO }
 };
 
 /*
@@ -119,16 +119,16 @@ static const loadpixformat_t load_game[] =
 // stub
 static const savepixformat_t save_null[] =
 {
-{ NULL, NULL }
+{ NULL, NULL, NULL }
 };
 
 // Xash3D normal instance
 static const savepixformat_t save_game[] =
 {
-{ "tga", Image_SaveTGA }, // tga screenshots
-{ "bmp", Image_SaveBMP }, // bmp levelshots or screenshots
-{ "png", Image_SavePNG }, // png screenshots
-{ NULL, NULL }
+{ "%s%s.%s", "tga", Image_SaveTGA },		// tga screenshots
+{ "%s%s.%s", "bmp", Image_SaveBMP },		// bmp levelshots or screenshots
+{ "%s%s.%s", "png", Image_SavePNG },		// png screenshots
+{ NULL, NULL, NULL }
 };
 
 void Image_Setup( void )

engine/common/imagelib/img_wad.c

@@ -28,20 +28,12 @@ Image_LoadPAL
 qboolean Image_LoadPAL( const char *name, const byte *buffer, fs_offset_t filesize )
 {
 	int	rendermode = LUMP_NORMAL;
-	byte pal[768];
 
-	if( filesize > sizeof( pal ))
+	if( filesize != 768 )
 	{
-		Con_DPrintf( S_ERROR "%s: (%s) have invalid size (%li should be less or equal than %zu)\n", __func__, name, (long)filesize, sizeof( pal ));
+		Con_DPrintf( S_ERROR "%s: (%s) have invalid size (%li should be %d)\n", __func__, name, (long)filesize, 768 );
 		return false;
 	}
-	else if( filesize < sizeof( pal ) && buffer != NULL )
-	{
-		// palette might be truncated, fill it with zeros
-		memset( pal, 0, sizeof( pal ));
-		memcpy( pal, buffer, filesize );
-		buffer = pal;
-	}
 
 	if( name[0] == '#' )
 	{