RomkaZVO/xash3d-fwgs
1
0
Fork 0
mirror of https://github.com/FWGS/xash3d-fwgs.git synced 2026-08-06 12:25:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

engine: client: prevent a crash in goldsrc delta entities parser

Browse Source
This commit is contained in:
Alibek Omarov
2026-01-13 05:43:09 +05:00
parent 79f7fba83c
commit f5b2c4f7af
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
engine/client/cl_parse_gs.c
View File

@@ -206,6 +206,7 @@ static void CL_DeltaEntityGS( const delta_header_t *hdr, sizebuf_t *msg, frame_t
qboolean newent = from == NULL;
int pack = frame->num_entities;
qboolean has_update = msg != NULL;
static entity_state_t nullent;
// alloc next slot to store update
to = &cls.packet_entities[cls.next_client_entities % cls.num_client_entities];
@@ -233,7 +234,17 @@ static void CL_DeltaEntityGS( const delta_header_t *hdr, sizebuf_t *msg, frame_t
if( hdr->instanced )
from = &cl.instanced_baseline[hdr->instanced_baseline_index];
else if( hdr->offset != 0 )
from = &cls.packet_entities[(cls.next_client_entities - hdr->offset) % cls.num_client_entities];
{
// FIXME: the usage of `offset` is incorrect here as the entities might
// not be ordered in cls.packet_entities the same way as on server
// catch the error, print the scary message and fix it up to nullent
if( cls.next_client_entities - hdr->offset < 0 )
{
Con_Printf( S_ERROR "%s: prevented delta-ing from invalid entity (%d - %d < 0)\n", __func__, cls.next_client_entities, hdr->offset );
from = &nullent;
}
else from = &cls.packet_entities[(cls.next_client_entities - hdr->offset ) % cls.num_client_entities];
}
else
from = &ent->baseline;
}