RomkaZVO/xash3d-fwgs
1
0
Fork 0
mirror of https://github.com/FWGS/xash3d-fwgs.git synced 2026-08-05 03:24:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

engine: server: add rate limiting for updating client's resources data too often

Browse Source
This commit is contained in:
Alibek Omarov
2026-04-19 22:29:56 +05:00
parent 5383e36af5
commit bbf8ab378d
3 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
engine/server/server.h
View File

@@ -252,6 +252,7 @@ typedef struct sv_client_s
double userinfo_penalty;
double overflow_warn_time;
double resourcelist_next_changetime;
client_frame_t *frames; // updates can be delta'd from here
event_state_t events; // delta-updated events cycle
@@ -419,6 +420,7 @@ extern convar_t sv_skyvec_z;
extern convar_t sv_consistency;
extern convar_t sv_password;
extern convar_t sv_uploadmax;
extern convar_t sv_upload_penalty_time;
extern convar_t sv_trace_messages;
extern convar_t sv_enttools_enable;
extern convar_t sv_enttools_maxfire;

10
engine/server/sv_client.c
View File

@@ -3465,6 +3465,16 @@ static void SV_ParseResourceList( sv_client_t *cl, sizebuf_t *msg )
SV_AddToResourceList( resource, &cl->resourcesneeded );
}
if( host.realtime < cl->resourcelist_next_changetime )
{
Con_Reportf( "%s: ignoring resource list update from %s: too soon\n", __func__, cl->name );
SV_ClearResourceList( &cl->resourcesneeded );
SV_ClearResourceList( &cl->resourcesonhand );
return;
}
cl->resourcelist_next_changetime = host.realtime + sv_upload_penalty_time.value;
totalsize = COM_SizeofResourceList( &cl->resourcesneeded, &ri );
if( totalsize != 0 && sv_allow_upload.value )

2
engine/server/sv_main.c
View File

@@ -55,6 +55,7 @@ CVAR_DEFINE( sv_allow_upload, "sv_allowupload", "1", FCVAR_SERVER, "allow upload
CVAR_DEFINE( sv_allow_download, "sv_allowdownload", "1", FCVAR_SERVER, "allow downloading custom resources to the client" );
static CVAR_DEFINE_AUTO( sv_allow_dlfile, "1", 0, "compatibility cvar, does nothing" );
CVAR_DEFINE_AUTO( sv_uploadmax, "0.5", FCVAR_SERVER, "max size to upload custom resources (500 kB as default)" );
CVAR_DEFINE_AUTO( sv_upload_penalty_time, "60", FCVAR_ARCHIVE, "allow custom resource updates only once in this timewindow (set 0 to disable)" );
CVAR_DEFINE_AUTO( sv_downloadurl, "", FCVAR_PROTECTED, "location from which clients can download missing files" );
CVAR_DEFINE( sv_consistency, "mp_consistency", "1", FCVAR_SERVER, "enbale consistency check in multiplayer" );
CVAR_DEFINE_AUTO( mp_logecho, "1", 0, "log multiplayer frags to server logfile" );
@@ -941,6 +942,7 @@ void SV_Init( void )
Cvar_RegisterVariable( &sv_send_logos );
Cvar_RegisterVariable( &sv_send_resources );
Cvar_RegisterVariable( &sv_uploadmax );
Cvar_RegisterVariable( &sv_upload_penalty_time );
Cvar_RegisterVariable( &sv_version );
Cvar_RegisterVariable( &sv_instancedbaseline );
Cvar_RegisterVariable( &sv_contact );