RomkaZVO/xash3d-fwgs
1
0
Fork 0
mirror of https://github.com/FWGS/xash3d-fwgs.git synced 2026-08-05 03:24:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

engine: validate paths before downloading

Browse Source
This commit is contained in:
Alibek Omarov
2026-05-17 10:41:59 +05:00
parent 5d7ed9d8a7
commit 9082a47348
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
engine/common/http/net_http_xash.c
View File

@@ -18,7 +18,6 @@ GNU General Public License for more details.
#include "client.h" // ConnectionProgress #include "client.h" // ConnectionProgress
#include "netchan.h" #include "netchan.h"
#include "xash3d_mathlib.h" #include "xash3d_mathlib.h"
#include "ipv6text.h"
#include "net_ws_private.h" #include "net_ws_private.h"
#include "miniz.h" #include "miniz.h"
@@ -943,6 +942,12 @@ void HTTP_AddDownload( const char *path, int size, qboolean process, resource_t
{ {
httpfile_t *httpfile; httpfile_t *httpfile;
if( COM_CheckNastyPath( path ))
{
Con_Printf( S_ERROR "%s: refused to download %s, nasty path\n", __func__, path );
return;
}
if( !http.first_server ) if( !http.first_server )
{ {
Con_Printf( S_ERROR "no servers to download %s\n", path ); Con_Printf( S_ERROR "no servers to download %s\n", path );

2
engine/common/net_chan.c
View File

@@ -1233,7 +1233,7 @@ qboolean Netchan_CopyFileFragments( netchan_t *chan, sizebuf_t *msg )
Netchan_FlushIncoming( chan, FRAG_FILE_STREAM ); Netchan_FlushIncoming( chan, FRAG_FILE_STREAM );
return false; return false;
} }
else if( filename[0] != '!' && !COM_IsSafeFileToDownload( filename )) else if( filename[0] != '!' && ( COM_CheckNastyPath( filename ) || !COM_IsSafeFileToDownload( filename )))
{ {
Con_Printf( S_ERROR "file fragment received with bad path, ignoring\n" ); Con_Printf( S_ERROR "file fragment received with bad path, ignoring\n" );
Netchan_FlushIncoming( chan, FRAG_FILE_STREAM ); Netchan_FlushIncoming( chan, FRAG_FILE_STREAM );