From 4f554e7b8b15df474b93a2ec48982afe3a6baab7 Mon Sep 17 00:00:00 2001 From: Mohamad Kanjo <56826704+MohiMad@users.noreply.github.com> Date: Wed, 5 Aug 2026 23:42:24 +0200 Subject: [PATCH] engine: client: deliver keys in Key_Event regardless of whether the client.dll handled them or not + expanded comment I have also removed the comment at the return statement, as its now misleading --- engine/client/input/in_keys.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/engine/client/input/in_keys.c b/engine/client/input/in_keys.c index 14e71949..84ca4fd2 100644 --- a/engine/client/input/in_keys.c +++ b/engine/client/input/in_keys.c @@ -722,8 +722,12 @@ void GAME_EXPORT Key_Event( int key, int down ) keys[key].gamedown = false; keys[key].repeats = 0; } - VGui_KeyEvent( key, down ); // resolves issue #1923 - return; // handled in client.dll + + // deliver keys regardless of whether the client.dll handled them or not + // reproduces GoldSrc behavior, where keys are passed even if the client.dll claims to have handled them + // this is needed for Cry of fear's Computer interface input, for more context, see https://github.com/FWGS/xash3d-fwgs/issues/1923 + VGui_KeyEvent( key, down ); + return; } }